-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function named zetteldeft-upsert #95
base: master
Are you sure you want to change the base?
Conversation
e6407d5
to
425375e
Compare
- Create zetteldeft--upsert that prompts the user for a choice among several - Create zetteldeft--list-upsert-choices that creates the list of possible choices.
I've just tried the
Any idea what I'm missing? |
We use first, second, and third because they're cleaner than the alternatives in my opinion.
I finally had a look at this. It turns out that 3486781 fixes it, sort of. But the end result is far worse. I think it could be improved by filtering the result of I'm sorry for taking so long to respond. |
@EFLS I've been using a personal branch for months which includes my completing read enhancements and this upsert functionality. I can't remember for sure but I think what I did was create the upsert code in my personal branch which already included my completing read changes. Then I cherry-picked it back into a branch dedicated to upsert -- but I made mistakes, which you bumped into in #95 (comment). I think it'll be easier to clean this up over once #91 lands. |
ref #94
@EFLS I started using this today. I bound it to
C-c d u
.I wouldn't accept this as-is (if nothing else, the name doesn't fit with the general aesthetic you've laid out for zetteldeft commands) but I hope it can be the basis for something that is inclusionworthy.
For completeness' sake, I think there should be equivalent functions for
zetteldeft-new-file-and-backlink
andzetteldeft-new-file-and-link
. It might be worthwhile to rework them all.