Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option for combining positive and negative intervals in interval indexers. #361

Closed
alexandermorgan opened this issue Aug 26, 2015 · 4 comments
Assignees

Comments

@alexandermorgan
Copy link
Contributor

There are currently settings to allow for analysis with or without interval quality and with simple or compound intervals, but a new setting is needed to provide absolute intervals (referred to as "canonical" intervals in other closed issues pertaining to the n-gram indexer). This would combine, for example, P4s and -P4s, meaning that the count would not be effected by which voice is on top. While less pressing, this may be a desirable setting to add tot he horizontal interval indexer too. These must be user-controllable settings because different queries will require different settings. The default should be kept as it is, where uncrossed and crossed versions of intervals are counted separately.

@alexandermorgan
Copy link
Contributor Author

This looks like a good opportunity to simplify how settings are passed to the interval indexer's "real_indexer_func".

@mrbannon
Copy link
Contributor

Could you please put this in the vis-rodan github? It's not a client issue
but a wrapper issue. Tx.

On Wed, Aug 26, 2015 at 3:40 PM, Alexander Morgan notifications@github.com
wrote:

This looks like a good opportunity to simply how settings are passed to
the interval indexer's "real_indexer_func".


Reply to this email directly or view it on GitHub
#361 (comment)
.

@crantila
Copy link
Member

VIS used to have this capability, but I don't think it ever made it into the Framework era. Not sure what Ryan means—this definitely seems like a setting for the IntervalIndexer.

@alexandermorgan
Copy link
Contributor Author

I agree that this should be in VIS itself because this will change the way the indexer_func in interval.py will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants