feature-password-group-swift #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianmo
previously requested changes
Jun 7, 2017
There was a problem hiding this comment.
@padthaitofuhot Thanks for adding support to Password Groups!
I've checked it out and fixed a few issues. I also sent a PR to your source branch in order to update this PR. padthaitofuhot#1
…up-swift Fix various errors from PR EMCECS#37
|
Neato. I didn't know you could put a PR on another PR like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: I haven't tested this locally.
I braindumped the implementation and shipped the PR to see what the nose smells.
😹