Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding filtering capacity when requesting layers #17

Closed
wants to merge 13 commits into from

Conversation

annakrystalli
Copy link
Collaborator

@annakrystalli annakrystalli commented Aug 17, 2021

Work in progress - Not Ready to Merge

@salvafern , I've made a start on introducing filtering capacity. Feel free to test this branch out if you like. Feedback welcome!

Still needs tests and a good vignette so feel free to share any interesting examples if you come up with any. I 've made a list of examples to include below.

  • Added facility for passing cql filters to emodnet_get_layers()
  • Added suite of functions to get, summarise and present layer and feature metadata to facilitate filtering
  • Add tests for attribute functions
  • Add tests for filtering
  • Add vignette to demo more complex use of filtering including

@annakrystalli annakrystalli marked this pull request as draft August 17, 2021 18:25
@annakrystalli
Copy link
Collaborator Author

FYI, in the previous commits, I'd written function to present attribute data which were erroneously based on cached data! 🤦‍♀️

I've rewritten then to extract data either from layer metadata or from the server by only downloading attribute data (which is generally much faster without the geometries).

Have now also added tests for the new functions

@codecov-commenter
Copy link

Codecov Report

Merging #17 (00c1ae4) into master (3ba5d0e) will decrease coverage by 7.67%.
The diff coverage is 75.86%.

❗ Current head 00c1ae4 differs from pull request most recent head 52d50cf. Consider uploading reports for the commit 52d50cf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   91.11%   83.43%   -7.68%     
==========================================
  Files           3        4       +1     
  Lines          90      169      +79     
==========================================
+ Hits           82      141      +59     
- Misses          8       28      +20     
Impacted Files Coverage Δ
R/layers.R 66.66% <42.85%> (-16.67%) ⬇️
R/layer_attributes.R 85.93% <85.93%> (ø)
R/info.R 94.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba5d0e...52d50cf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants