-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding filtering capacity when requesting layers #17
Conversation
…nction to get layer attribute tbl
FYI, in the previous commits, I'd written function to present attribute data which were erroneously based on cached data! 🤦♀️ I've rewritten then to extract data either from layer metadata or from the server by only downloading attribute data (which is generally much faster without the geometries). Have now also added tests for the new functions |
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 91.11% 83.43% -7.68%
==========================================
Files 3 4 +1
Lines 90 169 +79
==========================================
+ Hits 82 141 +59
- Misses 8 28 +20
Continue to review full report at Codecov.
|
Work in progress - Not Ready to Merge
@salvafern , I've made a start on introducing filtering capacity. Feel free to test this branch out if you like. Feedback welcome!
Still needs tests and a good vignette so feel free to share any interesting examples if you come up with any. I 've made a list of examples to include below.
emodnet_get_layers()
INTERSECTS