Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Months of Commits, Fork needs an update #1

Merged
merged 293 commits into from
Dec 14, 2019
Merged

Conversation

EOBGames
Copy link
Owner

14/12/2019
Starting language stuff, need updated files.

tgstation-server and others added 30 commits November 26, 2019 03:15
This PR converts gulag item reclaimer UI to tgui-next with some slight tweaks regarding size and text.
IE8 has an issue where the type prop on input is read only once the element is created, and with however inferno is creating objects it's not setting the prop on the actual true creation.
So instead here's a fallback where if ie8 is detected it doesn't even pass the type parameter since it defaults to text.

* Hack to get input working on IE8
* Remove input type altogether
With current editor config, if you have trailing whitespace on final new line, it doesn't get trimmed, and no extra newline gets added, which breaks linters.

Whitespace trimming is good overall. And an additional "utf-8" enforcement.

Webedit kung-fu.
* Unfucking this except for real this time

* This ought to do it

* Adds Detective access to the Security Office door

* How did those get in here?

* Seriously git what the hell

* Fixed the same issue on Kilo and Pubby
* | || || |_

* weight and prints
…ction (#47894)

* start

* new images

* more finished

* lessgo

* yaga

* better

* ty zxaber
tgui-net the Ore Box, it now updates automatically as you add ores, looks fancy, and includes instructions.
A kilt designed out of monster bits, pretty hardcore right?
It has the same protection as the other tribal accessories. crafted using 2 watcher sinew and one bones. Will show over any clothing or suit.
About The Pull Request

Attacking someone with a gun at point blank with grab intent will now hold them at gunpoint. This means you will automatically shoot the target if they move or attack, though they're still free to rummage around in their (or your, if you continue standing next to them) inventory, speak (including using radios), and throw things. The shooter may roam around a 3 tile box radius without breaking the hold-up, allowing them to reposition themselves, though breaking visibility will break the hold-up. In addition, if you're several tiles away and they make a break for it, they may be able to dodge the projectile. Tactical choices!


For the first 3 seconds after the hold-up, any triggered reaction shot will deal normal damage.
Between 3-10 seconds after, any triggered reaction shot will deal double damage.
After 10 seconds, the reaction shot will deal 2.5x damage.

The ramp-up is to give weapons with weaker per-shot damage like disablers, laser guns, and the .38 the ability to be useful for arrests and stick ups, without affecting combat balance too much. If you got someone you're trying to kill to hold still for 2 seconds at point blank range, you may as well just keep shooting them rather than fiddle with holding them up. If you're gonna resist, it's best to do it quickly!

Lastly, if the shooter is attacked and takes damage from anything, they have a chance to flinch and fire in reaction. This is a 50% chance, unless they're hit in the arm holding the gun, in which case it's an 80% chance.

Why It's Good For The Game

Adds in mechanical backing for taking people hostage or being able to arrest people with the threat of violence rather than actually carrying out that violence. Trying to take hostages or hold people up right now will just get you immediately shove spammed mid-"DROP $500 OR FAILRP" unless the other person feels like playing along. This makes cooperating or risking getting shot an actual choice, increasing mechanical depth while also adding more roleplay potential.

Also yes, the target cuffing themselves will not trigger the reaction shot, so holding someone up, backing up, and throwing cuffs at them is a valid move.
tgstation-server and others added 5 commits December 13, 2019 17:49
* Delete stale.yml

* Create stale.yml

* it's log, log

it's better than bad, it's good.

* no comment

* the key to getting this merged

* chassis nullified
* Fixes emagging stuff without user

* Fixes missing initalizes

* Fixes deconstructing for materials

* Fixes tracker bullets runtime.
@EOBGames EOBGames merged commit 0e1f3c5 into EOBGames:master Dec 14, 2019
EOBGames pushed a commit that referenced this pull request Dec 18, 2019
* Language holder refactor

* Ironed out bugs, testing

* adds sourced language, blocking list. more useful helpers.

* Replaced old usage

* Adresses requests

* Autodoc attempt #1

* Fixed monkeyize (again)

* Travis happy

* Language menu updated

* Final pass
EOBGames pushed a commit that referenced this pull request Jan 22, 2020
EOBGames pushed a commit that referenced this pull request Jan 22, 2020
EOBGames pushed a commit that referenced this pull request Feb 21, 2020
EOBGames pushed a commit that referenced this pull request Feb 21, 2020
EOBGames pushed a commit that referenced this pull request Feb 29, 2020
Fix Farquaar's Repository
EOBGames pushed a commit that referenced this pull request Mar 25, 2020
Updating fork, because I don't know other ways.
EOBGames pushed a commit that referenced this pull request Mar 25, 2020
Service lathe door access to Psych
EOBGames pushed a commit that referenced this pull request Apr 7, 2020
* monkey cube suicide

* fuck

i used True instead of TRUE

* fixes indentation

it returned early

* adds delay

stops suicide from being instant

* fixes visible_message

it was called on src, which was qdeleted

* removes disfiguration

now everyone can see what you've done

* revises suicide

adds qdeleted checks, switches to do_after, hides cube

* commit suggestion #1

it is what it is

Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>

* commit suggestion #2

i'm just going to assume this works and if travis yells at me that'll be how it goes

Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>

* switches sleep call to timer + callback

splits off the end of the suicide into a finish_suicide proc

* monke

i typed "monkecube" instead of "monkeycube". this fixes that

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
EOBGames added a commit that referenced this pull request May 24, 2020
Ought to fix linter/runtime issues + cleans up readable files
EOBGames pushed a commit that referenced this pull request Jul 21, 2020
EOBGames pushed a commit that referenced this pull request Aug 25, 2020
EOBGames pushed a commit that referenced this pull request Sep 1, 2020
EOBGames pushed a commit that referenced this pull request Sep 1, 2020
EOBGames pushed a commit that referenced this pull request Sep 9, 2020
EOBGames pushed a commit that referenced this pull request Sep 9, 2020
EOBGames pushed a commit that referenced this pull request Sep 16, 2020
EOBGames added a commit that referenced this pull request Sep 29, 2021
commit c10e1e6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 20:55:39 2021 -0700

    Automatic changelog generation for PR tgstation#61746 [ci skip]

commit 9bcc80c
Author: 567Turtle <91508746+567Turtle@users.noreply.github.com>
Date:   Tue Sep 28 22:55:36 2021 -0500

    Constructable Filing Cabinets (tgstation#61746)

commit 2fd4e1d
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Tue Sep 28 19:12:45 2021 -0700

    adds tralezab as a codeowner of datum ais (tgstation#61769)

commit f45fb5d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:34 2021 -0700

    Automatic changelog generation for PR tgstation#61739 [ci skip]

commit 8473d44
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:30 2021 -0600

    Ditches the Spare Monkey-Operated Firealarm in Kilostaiton Genetics (tgstation#61739)

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit e135108
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:14 2021 -0700

    Automatic changelog generation for PR tgstation#61738 [ci skip]

commit b626fad
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:10 2021 -0600

    Removes Duplicate Disposals Pipe and Glass Table from MetaENG (tgstation#61738)

    * Removes Duplicate Disposals Pipe and Glass Table from MetaENG

    * Plumbing and Power too

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit 87cf6e7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:28 2021 -0700

    Automatic changelog generation for PR tgstation#61733 [ci skip]

commit 6174323
Author: esainane <esainane+github@gmail.com>
Date:   Wed Sep 29 13:51:25 2021 +1300

    Derelict: Remove duplicate APCs (tgstation#61733)

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/bridge/access` at (66,80) and (63,61).
    This removes the APC at (63,61) and the two wires leading up to it.

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/hallway/secondary` at (35,23) and (58,24).
    This removes the APC at (58,24), which is directly over a wire path,
    so does not require any power cables to be removed.

commit a43209f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:11 2021 -0700

    Automatic changelog generation for PR tgstation#61735 [ci skip]

commit 9e40039
Author: Iamgoofball <iamgoofball@gmail.com>
Date:   Tue Sep 28 17:51:08 2021 -0700

    Fixes references to now dead gangs in Families objectives. (tgstation#61735)

commit 44c424f
Author: Changelogs <action@github.com>
Date:   Wed Sep 29 00:11:00 2021 +0000

    Automatic changelog compile [ci skip]

commit 9d200cb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:07:45 2021 -0700

    Automatic changelog generation for PR tgstation#61532 [ci skip]

commit 65267ba
Author: Krysonism <49783092+Krysonism@users.noreply.github.com>
Date:   Wed Sep 29 02:07:41 2021 +0200

    Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. (tgstation#61532)

    * doggy dog world

    * space begone

    * suggestions from review

    * removes frog related oopsie

    * indent fix

commit 67194ea
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:52:16 2021 -0700

    Automatic changelog generation for PR tgstation#61722 [ci skip]

commit 61c30cc
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date:   Wed Sep 29 01:52:12 2021 +0200

    ntoscard templates fix (tgstation#61722)

commit 378da49
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:47:47 2021 -0700

    Automatic changelog generation for PR tgstation#61730 [ci skip]

commit 81989f0
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Wed Sep 29 01:47:44 2021 +0200

    Fix baselighting not respecting changeturfs (tgstation#61730)

commit 1846c2d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 15:03:30 2021 -0700

    Automatic changelog generation for PR tgstation#61716 [ci skip]

commit e330485
Author: Thunder12345 <Thunder12345@users.noreply.github.com>
Date:   Tue Sep 28 23:03:27 2021 +0100

    Replaces CTF hardsuits with new armoured vests (tgstation#61716)

    Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk>

commit 84c7b68
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 14:21:30 2021 -0700

    Automatic changelog generation for PR tgstation#61736 [ci skip]

commit 643645b
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date:   Tue Sep 28 18:21:27 2021 -0300

    Makes colo cup sprites actually consistent, and a small edit to a joke. (tgstation#61736)

    * Update drinks.dm

    * adds actual colo cups sprites lol im dumb

    * fixes a small sprite error

commit c1fd222
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Tue Sep 28 17:16:09 2021 -0400

    dehardcodes limb icons (tgstation#61570)

    This is a small change aimed at helping downstream modularity.
    Currently the file these sprites use are hardcoded with a define, this removes that and instead moves it to a var.

    I guess the thing is defaults should be overridable, it's just we've never ran into a case where it's needed, so adding that functionality on its own looks really weird

    annoying. I don't like adding stuff that's only useful to downstreams, for various reasons, but this seems ok after some thought. fulfills the promise of _DEFAULT.
    -Lemon

commit eec8463
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 12:45:42 2021 -0700

    Automatic changelog generation for PR tgstation#61694 [ci skip]

commit 496a768
Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Date:   Tue Sep 28 15:45:38 2021 -0400

    [MDB Ignore] Make shuttle windows deconstructable (tgstation#61694)

    * shuttle windows

    * refactor reinf windows

    plasma and shuttle only

    * messed up one change

    * i am actually blind

    * made and did file

commit a66ef31
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Tue Sep 28 14:15:11 2021 -0500

    Corrects mapload args that sprug up in the past few days (tgstation#61759)

    See tgstation#61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated.

commit 4fc5897
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 11:56:21 2021 -0700

    Automatic changelog generation for PR tgstation#61725 [ci skip]

commit 43a2b90
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 20:56:17 2021 +0200

    renames enable debug verbs to enable mapping verbs (tgstation#61725)

    its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs

commit 4413bbc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 08:00:07 2021 -0700

    Automatic changelog generation for PR tgstation#61724 [ci skip]

commit a23b275
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Tue Sep 28 08:00:01 2021 -0700

    Fixes check AI laws collapsing, making them unreadable (tgstation#61724)

    Previously, this would be putting (x2) next to the first 3 laws, and it would look like the 2nd cyborg had no laws.

commit a62262f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:58:50 2021 -0700

    Automatic changelog generation for PR tgstation#61723 [ci skip]

commit 4eee6a1
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Tue Sep 28 15:58:47 2021 +0100

    Fixes contractor drop pods not being clickable due to suspected BYOND issue. (tgstation#61723)

    Fixes tgstation#61695

    When breaking the entire problem down, I identified the point in time at which the pod stopped being clickable
    Spawning in pods manually and running their various procs couldn't replicate the issue. As a result, I eliminated pod code as the root cause and focused on the pod_landingzone that control them.

    I considered the debris as a possible cause following:
    tgstation#61695

    However, removing the debris actually removed ALL clickable area for the pods. The debris overlap was the only part that let me click on the pods.

    So then I set to hacking away at any animation code. At one point I removed both the animates

    animate(pod.get_filter("motionblur"), y = 0, time = pod.delays[POD_FALLING], flags = ANIMATION_PARALLEL)
    animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING, flags = ANIMATION_PARALLEL) //Make the pod fall! At an angle!
    from /obj/effect/pod_landingzone/proc/beginLaunch and the problem still persisted.

    When I removed pod.add_filter("motionblur",1,list("type"="motion_blur", "x"=0, "y"=3)) after this (the effect was permanently on the pod which made it pretty obvious as a possible cause) the problem vanished entirely.

    Without the motion blur filter applied, pods now function properly.

    As a result, I believe this is a BYOND issue. Someone with more brains than me can probably work out a test case. Until someone with more brains than me comes along to fix it, removing the motion blur filter is my solution.

commit 1859df5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:55:59 2021 -0700

    Automatic changelog generation for PR tgstation#61229 [ci skip]

commit 29c49fd
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Tue Sep 28 07:55:55 2021 -0700

    Ports animated locker doors (tgstation#61229)

    ## About The Pull Request
    Ports locker door animations from Yogstation!

    yogstation13/Yogstation#9706
    Skyrat-SS13/Skyrat-tg#6767

    ## Why It's Good For The Game
    The locker opening animation is really nice, it's a shame we don't have it yet.

commit 6189b88
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:08:57 2021 -0700

    Automatic changelog generation for PR tgstation#61692 [ci skip]

commit df1260f
Author: CRITAWAKETS <sebastienracicot@hotmail.com>
Date:   Tue Sep 28 05:08:53 2021 -0400

    Fixes the auxiliary base construction console. (tgstation#61692)

commit c254707
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:05:30 2021 -0700

    Automatic changelog generation for PR tgstation#61698 [ci skip]

commit 6317b7b
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Tue Sep 28 11:05:27 2021 +0200

    Fix connect loc not respecting phasing in some cases when it should (tgstation#61698)

commit 26df314
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 00:01:11 2021 -0700

    Automatic changelog generation for PR tgstation#60920 [ci skip]

commit ff41f8a
Author: twilightwanderer <88540658+twilightwanderer@users.noreply.github.com>
Date:   Tue Sep 28 10:01:07 2021 +0300

    Fixing the chat client (tgstation#60920)

    Corrects the chat restriction on using ASII characters only. (This PR was created for Skyrat-TG, but the collaborator of that repository asked me to adapt this PR for tgstation.)

    This will fix tgstation#54598
    In the original code, the chat client uses only ASII standard characters, which is very limited in its capabilities. For example, does not allow you to use specialized characters, which would have taken the atmosphere of the old messengers, as well as regional characters. The lack of regional characters complicates the game for non-English-speaking servers. For example, the Russian-speaking player community Space Station 13 The Fluffy Frontier uses the original Skyrat-tg build. And the players of this community almost do not use the chat client to communicate due to the fact that they can not use Cyrillic characters.

commit 3b275f8
Author: Sheits <81964183+Sheits@users.noreply.github.com>
Date:   Tue Sep 28 16:57:52 2021 +1000

    Creates fly.ts for the new tgui prefs menu (tgstation#61728)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit 32518f6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 22:52:08 2021 -0700

    Automatic changelog generation for PR tgstation#61715 [ci skip]

commit 76c6754
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 07:52:05 2021 +0200

    secret recipes are now actually secret (tgstation#61715)

commit 67e7261
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 20:38:52 2021 -0700

    Automatic changelog generation for PR tgstation#61714 [ci skip]

commit 1f000ba
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Mon Sep 27 20:38:49 2021 -0700

    Fix word bounds on filters, where they would only be applied at the beginning (tgstation#61714)

commit 563cb1d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 19:06:06 2021 -0700

    Automatic changelog generation for PR tgstation#61607 [ci skip]

commit 744679b
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Mon Sep 27 20:06:02 2021 -0600

    Adds brand new ruins to the Icebox Ruins roster. (tgstation#61607)

commit 69fc80f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:52:00 2021 -0700

    Automatic changelog generation for PR tgstation#61680 [ci skip]

commit dbfa6c0
Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Date:   Tue Sep 28 01:51:57 2021 +0100

    Fix Genturf on Icebox (tgstation#61680)

commit a19f273
Author: Changelogs <action@github.com>
Date:   Tue Sep 28 00:11:28 2021 +0000

    Automatic changelog compile [ci skip]

commit c277a6f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:08:07 2021 -0700

    Automatic changelog generation for PR tgstation#61621 [ci skip]

commit 3c5d622
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Tue Sep 28 02:08:03 2021 +0200

    You can now use backslashes as an escape character for text modification. (tgstation#61621)

commit eac67c9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:04:30 2021 -0700

    Automatic changelog generation for PR tgstation#61719 [ci skip]

commit 74be623
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 02:04:27 2021 +0200

    Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits (tgstation#61719)

commit ca4524e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 16:35:18 2021 -0700

    Automatic changelog generation for PR tgstation#61726 [ci skip]

commit d9ede13
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Mon Sep 27 16:35:15 2021 -0700

    if you give a monkey an instrument, it will begin playing the donkey kong theme (tgstation#61726)
EOBGames pushed a commit that referenced this pull request Sep 29, 2021
…th of selected simple mobs. (tgstation#61532)

* doggy dog world

* space begone

* suggestions from review

* removes frog related oopsie

* indent fix
EOBGames added a commit that referenced this pull request Sep 29, 2021
commit c10e1e6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 20:55:39 2021 -0700

    Automatic changelog generation for PR tgstation#61746 [ci skip]

commit 9bcc80c
Author: 567Turtle <91508746+567Turtle@users.noreply.github.com>
Date:   Tue Sep 28 22:55:36 2021 -0500

    Constructable Filing Cabinets (tgstation#61746)

commit 2fd4e1d
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Tue Sep 28 19:12:45 2021 -0700

    adds tralezab as a codeowner of datum ais (tgstation#61769)

commit f45fb5d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:34 2021 -0700

    Automatic changelog generation for PR tgstation#61739 [ci skip]

commit 8473d44
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:30 2021 -0600

    Ditches the Spare Monkey-Operated Firealarm in Kilostaiton Genetics (tgstation#61739)

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit e135108
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:14 2021 -0700

    Automatic changelog generation for PR tgstation#61738 [ci skip]

commit b626fad
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:10 2021 -0600

    Removes Duplicate Disposals Pipe and Glass Table from MetaENG (tgstation#61738)

    * Removes Duplicate Disposals Pipe and Glass Table from MetaENG

    * Plumbing and Power too

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit 87cf6e7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:28 2021 -0700

    Automatic changelog generation for PR tgstation#61733 [ci skip]

commit 6174323
Author: esainane <esainane+github@gmail.com>
Date:   Wed Sep 29 13:51:25 2021 +1300

    Derelict: Remove duplicate APCs (tgstation#61733)

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/bridge/access` at (66,80) and (63,61).
    This removes the APC at (63,61) and the two wires leading up to it.

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/hallway/secondary` at (35,23) and (58,24).
    This removes the APC at (58,24), which is directly over a wire path,
    so does not require any power cables to be removed.

commit a43209f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:11 2021 -0700

    Automatic changelog generation for PR tgstation#61735 [ci skip]

commit 9e40039
Author: Iamgoofball <iamgoofball@gmail.com>
Date:   Tue Sep 28 17:51:08 2021 -0700

    Fixes references to now dead gangs in Families objectives. (tgstation#61735)

commit 44c424f
Author: Changelogs <action@github.com>
Date:   Wed Sep 29 00:11:00 2021 +0000

    Automatic changelog compile [ci skip]

commit 9d200cb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:07:45 2021 -0700

    Automatic changelog generation for PR tgstation#61532 [ci skip]

commit 65267ba
Author: Krysonism <49783092+Krysonism@users.noreply.github.com>
Date:   Wed Sep 29 02:07:41 2021 +0200

    Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. (tgstation#61532)

    * doggy dog world

    * space begone

    * suggestions from review

    * removes frog related oopsie

    * indent fix

commit 67194ea
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:52:16 2021 -0700

    Automatic changelog generation for PR tgstation#61722 [ci skip]

commit 61c30cc
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date:   Wed Sep 29 01:52:12 2021 +0200

    ntoscard templates fix (tgstation#61722)

commit 378da49
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:47:47 2021 -0700

    Automatic changelog generation for PR tgstation#61730 [ci skip]

commit 81989f0
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Wed Sep 29 01:47:44 2021 +0200

    Fix baselighting not respecting changeturfs (tgstation#61730)

commit 1846c2d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 15:03:30 2021 -0700

    Automatic changelog generation for PR tgstation#61716 [ci skip]

commit e330485
Author: Thunder12345 <Thunder12345@users.noreply.github.com>
Date:   Tue Sep 28 23:03:27 2021 +0100

    Replaces CTF hardsuits with new armoured vests (tgstation#61716)

    Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk>

commit 84c7b68
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 14:21:30 2021 -0700

    Automatic changelog generation for PR tgstation#61736 [ci skip]

commit 643645b
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date:   Tue Sep 28 18:21:27 2021 -0300

    Makes colo cup sprites actually consistent, and a small edit to a joke. (tgstation#61736)

    * Update drinks.dm

    * adds actual colo cups sprites lol im dumb

    * fixes a small sprite error

commit c1fd222
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Tue Sep 28 17:16:09 2021 -0400

    dehardcodes limb icons (tgstation#61570)

    This is a small change aimed at helping downstream modularity.
    Currently the file these sprites use are hardcoded with a define, this removes that and instead moves it to a var.

    I guess the thing is defaults should be overridable, it's just we've never ran into a case where it's needed, so adding that functionality on its own looks really weird

    annoying. I don't like adding stuff that's only useful to downstreams, for various reasons, but this seems ok after some thought. fulfills the promise of _DEFAULT.
    -Lemon

commit eec8463
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 12:45:42 2021 -0700

    Automatic changelog generation for PR tgstation#61694 [ci skip]

commit 496a768
Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Date:   Tue Sep 28 15:45:38 2021 -0400

    [MDB Ignore] Make shuttle windows deconstructable (tgstation#61694)

    * shuttle windows

    * refactor reinf windows

    plasma and shuttle only

    * messed up one change

    * i am actually blind

    * made and did file

commit a66ef31
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Tue Sep 28 14:15:11 2021 -0500

    Corrects mapload args that sprug up in the past few days (tgstation#61759)

    See tgstation#61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated.

commit 4fc5897
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 11:56:21 2021 -0700

    Automatic changelog generation for PR tgstation#61725 [ci skip]

commit 43a2b90
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 20:56:17 2021 +0200

    renames enable debug verbs to enable mapping verbs (tgstation#61725)

    its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs

commit 4413bbc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 08:00:07 2021 -0700

    Automatic changelog generation for PR tgstation#61724 [ci skip]

commit a23b275
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Tue Sep 28 08:00:01 2021 -0700

    Fixes check AI laws collapsing, making them unreadable (tgstation#61724)

    Previously, this would be putting (x2) next to the first 3 laws, and it would look like the 2nd cyborg had no laws.

commit a62262f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:58:50 2021 -0700

    Automatic changelog generation for PR tgstation#61723 [ci skip]

commit 4eee6a1
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Tue Sep 28 15:58:47 2021 +0100

    Fixes contractor drop pods not being clickable due to suspected BYOND issue. (tgstation#61723)

    Fixes tgstation#61695

    When breaking the entire problem down, I identified the point in time at which the pod stopped being clickable
    Spawning in pods manually and running their various procs couldn't replicate the issue. As a result, I eliminated pod code as the root cause and focused on the pod_landingzone that control them.

    I considered the debris as a possible cause following:
    tgstation#61695

    However, removing the debris actually removed ALL clickable area for the pods. The debris overlap was the only part that let me click on the pods.

    So then I set to hacking away at any animation code. At one point I removed both the animates

    animate(pod.get_filter("motionblur"), y = 0, time = pod.delays[POD_FALLING], flags = ANIMATION_PARALLEL)
    animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING, flags = ANIMATION_PARALLEL) //Make the pod fall! At an angle!
    from /obj/effect/pod_landingzone/proc/beginLaunch and the problem still persisted.

    When I removed pod.add_filter("motionblur",1,list("type"="motion_blur", "x"=0, "y"=3)) after this (the effect was permanently on the pod which made it pretty obvious as a possible cause) the problem vanished entirely.

    Without the motion blur filter applied, pods now function properly.

    As a result, I believe this is a BYOND issue. Someone with more brains than me can probably work out a test case. Until someone with more brains than me comes along to fix it, removing the motion blur filter is my solution.

commit 1859df5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:55:59 2021 -0700

    Automatic changelog generation for PR tgstation#61229 [ci skip]

commit 29c49fd
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Tue Sep 28 07:55:55 2021 -0700

    Ports animated locker doors (tgstation#61229)

    ## About The Pull Request
    Ports locker door animations from Yogstation!

    yogstation13/Yogstation#9706
    Skyrat-SS13/Skyrat-tg#6767

    ## Why It's Good For The Game
    The locker opening animation is really nice, it's a shame we don't have it yet.

commit 6189b88
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:08:57 2021 -0700

    Automatic changelog generation for PR tgstation#61692 [ci skip]

commit df1260f
Author: CRITAWAKETS <sebastienracicot@hotmail.com>
Date:   Tue Sep 28 05:08:53 2021 -0400

    Fixes the auxiliary base construction console. (tgstation#61692)

commit c254707
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:05:30 2021 -0700

    Automatic changelog generation for PR tgstation#61698 [ci skip]

commit 6317b7b
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Tue Sep 28 11:05:27 2021 +0200

    Fix connect loc not respecting phasing in some cases when it should (tgstation#61698)

commit 26df314
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 00:01:11 2021 -0700

    Automatic changelog generation for PR tgstation#60920 [ci skip]

commit ff41f8a
Author: twilightwanderer <88540658+twilightwanderer@users.noreply.github.com>
Date:   Tue Sep 28 10:01:07 2021 +0300

    Fixing the chat client (tgstation#60920)

    Corrects the chat restriction on using ASII characters only. (This PR was created for Skyrat-TG, but the collaborator of that repository asked me to adapt this PR for tgstation.)

    This will fix tgstation#54598
    In the original code, the chat client uses only ASII standard characters, which is very limited in its capabilities. For example, does not allow you to use specialized characters, which would have taken the atmosphere of the old messengers, as well as regional characters. The lack of regional characters complicates the game for non-English-speaking servers. For example, the Russian-speaking player community Space Station 13 The Fluffy Frontier uses the original Skyrat-tg build. And the players of this community almost do not use the chat client to communicate due to the fact that they can not use Cyrillic characters.

commit 3b275f8
Author: Sheits <81964183+Sheits@users.noreply.github.com>
Date:   Tue Sep 28 16:57:52 2021 +1000

    Creates fly.ts for the new tgui prefs menu (tgstation#61728)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit 32518f6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 22:52:08 2021 -0700

    Automatic changelog generation for PR tgstation#61715 [ci skip]

commit 76c6754
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 07:52:05 2021 +0200

    secret recipes are now actually secret (tgstation#61715)

commit 67e7261
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 20:38:52 2021 -0700

    Automatic changelog generation for PR tgstation#61714 [ci skip]

commit 1f000ba
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Mon Sep 27 20:38:49 2021 -0700

    Fix word bounds on filters, where they would only be applied at the beginning (tgstation#61714)

commit 563cb1d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 19:06:06 2021 -0700

    Automatic changelog generation for PR tgstation#61607 [ci skip]

commit 744679b
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Mon Sep 27 20:06:02 2021 -0600

    Adds brand new ruins to the Icebox Ruins roster. (tgstation#61607)

commit 69fc80f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:52:00 2021 -0700

    Automatic changelog generation for PR tgstation#61680 [ci skip]

commit dbfa6c0
Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Date:   Tue Sep 28 01:51:57 2021 +0100

    Fix Genturf on Icebox (tgstation#61680)

commit a19f273
Author: Changelogs <action@github.com>
Date:   Tue Sep 28 00:11:28 2021 +0000

    Automatic changelog compile [ci skip]

commit c277a6f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:08:07 2021 -0700

    Automatic changelog generation for PR tgstation#61621 [ci skip]

commit 3c5d622
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Tue Sep 28 02:08:03 2021 +0200

    You can now use backslashes as an escape character for text modification. (tgstation#61621)

commit eac67c9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:04:30 2021 -0700

    Automatic changelog generation for PR tgstation#61719 [ci skip]

commit 74be623
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 02:04:27 2021 +0200

    Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits (tgstation#61719)

commit ca4524e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 16:35:18 2021 -0700

    Automatic changelog generation for PR tgstation#61726 [ci skip]

commit d9ede13
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Mon Sep 27 16:35:15 2021 -0700

    if you give a monkey an instrument, it will begin playing the donkey kong theme (tgstation#61726)
EOBGames added a commit that referenced this pull request Sep 29, 2021
commit c10e1e6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 20:55:39 2021 -0700

    Automatic changelog generation for PR tgstation#61746 [ci skip]

commit 9bcc80c
Author: 567Turtle <91508746+567Turtle@users.noreply.github.com>
Date:   Tue Sep 28 22:55:36 2021 -0500

    Constructable Filing Cabinets (tgstation#61746)

commit 2fd4e1d
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Tue Sep 28 19:12:45 2021 -0700

    adds tralezab as a codeowner of datum ais (tgstation#61769)

commit f45fb5d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:34 2021 -0700

    Automatic changelog generation for PR tgstation#61739 [ci skip]

commit 8473d44
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:30 2021 -0600

    Ditches the Spare Monkey-Operated Firealarm in Kilostaiton Genetics (tgstation#61739)

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit e135108
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:14 2021 -0700

    Automatic changelog generation for PR tgstation#61738 [ci skip]

commit b626fad
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:10 2021 -0600

    Removes Duplicate Disposals Pipe and Glass Table from MetaENG (tgstation#61738)

    * Removes Duplicate Disposals Pipe and Glass Table from MetaENG

    * Plumbing and Power too

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit 87cf6e7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:28 2021 -0700

    Automatic changelog generation for PR tgstation#61733 [ci skip]

commit 6174323
Author: esainane <esainane+github@gmail.com>
Date:   Wed Sep 29 13:51:25 2021 +1300

    Derelict: Remove duplicate APCs (tgstation#61733)

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/bridge/access` at (66,80) and (63,61).
    This removes the APC at (63,61) and the two wires leading up to it.

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/hallway/secondary` at (35,23) and (58,24).
    This removes the APC at (58,24), which is directly over a wire path,
    so does not require any power cables to be removed.

commit a43209f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:11 2021 -0700

    Automatic changelog generation for PR tgstation#61735 [ci skip]

commit 9e40039
Author: Iamgoofball <iamgoofball@gmail.com>
Date:   Tue Sep 28 17:51:08 2021 -0700

    Fixes references to now dead gangs in Families objectives. (tgstation#61735)

commit 44c424f
Author: Changelogs <action@github.com>
Date:   Wed Sep 29 00:11:00 2021 +0000

    Automatic changelog compile [ci skip]

commit 9d200cb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:07:45 2021 -0700

    Automatic changelog generation for PR tgstation#61532 [ci skip]

commit 65267ba
Author: Krysonism <49783092+Krysonism@users.noreply.github.com>
Date:   Wed Sep 29 02:07:41 2021 +0200

    Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. (tgstation#61532)

    * doggy dog world

    * space begone

    * suggestions from review

    * removes frog related oopsie

    * indent fix

commit 67194ea
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:52:16 2021 -0700

    Automatic changelog generation for PR tgstation#61722 [ci skip]

commit 61c30cc
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date:   Wed Sep 29 01:52:12 2021 +0200

    ntoscard templates fix (tgstation#61722)

commit 378da49
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:47:47 2021 -0700

    Automatic changelog generation for PR tgstation#61730 [ci skip]

commit 81989f0
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Wed Sep 29 01:47:44 2021 +0200

    Fix baselighting not respecting changeturfs (tgstation#61730)

commit 1846c2d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 15:03:30 2021 -0700

    Automatic changelog generation for PR tgstation#61716 [ci skip]

commit e330485
Author: Thunder12345 <Thunder12345@users.noreply.github.com>
Date:   Tue Sep 28 23:03:27 2021 +0100

    Replaces CTF hardsuits with new armoured vests (tgstation#61716)

    Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk>

commit 84c7b68
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 14:21:30 2021 -0700

    Automatic changelog generation for PR tgstation#61736 [ci skip]

commit 643645b
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date:   Tue Sep 28 18:21:27 2021 -0300

    Makes colo cup sprites actually consistent, and a small edit to a joke. (tgstation#61736)

    * Update drinks.dm

    * adds actual colo cups sprites lol im dumb

    * fixes a small sprite error

commit c1fd222
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Tue Sep 28 17:16:09 2021 -0400

    dehardcodes limb icons (tgstation#61570)

    This is a small change aimed at helping downstream modularity.
    Currently the file these sprites use are hardcoded with a define, this removes that and instead moves it to a var.

    I guess the thing is defaults should be overridable, it's just we've never ran into a case where it's needed, so adding that functionality on its own looks really weird

    annoying. I don't like adding stuff that's only useful to downstreams, for various reasons, but this seems ok after some thought. fulfills the promise of _DEFAULT.
    -Lemon

commit eec8463
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 12:45:42 2021 -0700

    Automatic changelog generation for PR tgstation#61694 [ci skip]

commit 496a768
Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Date:   Tue Sep 28 15:45:38 2021 -0400

    [MDB Ignore] Make shuttle windows deconstructable (tgstation#61694)

    * shuttle windows

    * refactor reinf windows

    plasma and shuttle only

    * messed up one change

    * i am actually blind

    * made and did file

commit a66ef31
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Tue Sep 28 14:15:11 2021 -0500

    Corrects mapload args that sprug up in the past few days (tgstation#61759)

    See tgstation#61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated.

commit 4fc5897
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 11:56:21 2021 -0700

    Automatic changelog generation for PR tgstation#61725 [ci skip]

commit 43a2b90
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 20:56:17 2021 +0200

    renames enable debug verbs to enable mapping verbs (tgstation#61725)

    its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs

commit 4413bbc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 08:00:07 2021 -0700

    Automatic changelog generation for PR tgstation#61724 [ci skip]

commit a23b275
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Tue Sep 28 08:00:01 2021 -0700

    Fixes check AI laws collapsing, making them unreadable (tgstation#61724)

    Previously, this would be putting (x2) next to the first 3 laws, and it would look like the 2nd cyborg had no laws.

commit a62262f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:58:50 2021 -0700

    Automatic changelog generation for PR tgstation#61723 [ci skip]

commit 4eee6a1
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Tue Sep 28 15:58:47 2021 +0100

    Fixes contractor drop pods not being clickable due to suspected BYOND issue. (tgstation#61723)

    Fixes tgstation#61695

    When breaking the entire problem down, I identified the point in time at which the pod stopped being clickable
    Spawning in pods manually and running their various procs couldn't replicate the issue. As a result, I eliminated pod code as the root cause and focused on the pod_landingzone that control them.

    I considered the debris as a possible cause following:
    tgstation#61695

    However, removing the debris actually removed ALL clickable area for the pods. The debris overlap was the only part that let me click on the pods.

    So then I set to hacking away at any animation code. At one point I removed both the animates

    animate(pod.get_filter("motionblur"), y = 0, time = pod.delays[POD_FALLING], flags = ANIMATION_PARALLEL)
    animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING, flags = ANIMATION_PARALLEL) //Make the pod fall! At an angle!
    from /obj/effect/pod_landingzone/proc/beginLaunch and the problem still persisted.

    When I removed pod.add_filter("motionblur",1,list("type"="motion_blur", "x"=0, "y"=3)) after this (the effect was permanently on the pod which made it pretty obvious as a possible cause) the problem vanished entirely.

    Without the motion blur filter applied, pods now function properly.

    As a result, I believe this is a BYOND issue. Someone with more brains than me can probably work out a test case. Until someone with more brains than me comes along to fix it, removing the motion blur filter is my solution.

commit 1859df5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:55:59 2021 -0700

    Automatic changelog generation for PR tgstation#61229 [ci skip]

commit 29c49fd
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Tue Sep 28 07:55:55 2021 -0700

    Ports animated locker doors (tgstation#61229)

    ## About The Pull Request
    Ports locker door animations from Yogstation!

    yogstation13/Yogstation#9706
    Skyrat-SS13/Skyrat-tg#6767

    ## Why It's Good For The Game
    The locker opening animation is really nice, it's a shame we don't have it yet.

commit 6189b88
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:08:57 2021 -0700

    Automatic changelog generation for PR tgstation#61692 [ci skip]

commit df1260f
Author: CRITAWAKETS <sebastienracicot@hotmail.com>
Date:   Tue Sep 28 05:08:53 2021 -0400

    Fixes the auxiliary base construction console. (tgstation#61692)

commit c254707
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:05:30 2021 -0700

    Automatic changelog generation for PR tgstation#61698 [ci skip]

commit 6317b7b
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Tue Sep 28 11:05:27 2021 +0200

    Fix connect loc not respecting phasing in some cases when it should (tgstation#61698)

commit 26df314
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 00:01:11 2021 -0700

    Automatic changelog generation for PR tgstation#60920 [ci skip]

commit ff41f8a
Author: twilightwanderer <88540658+twilightwanderer@users.noreply.github.com>
Date:   Tue Sep 28 10:01:07 2021 +0300

    Fixing the chat client (tgstation#60920)

    Corrects the chat restriction on using ASII characters only. (This PR was created for Skyrat-TG, but the collaborator of that repository asked me to adapt this PR for tgstation.)

    This will fix tgstation#54598
    In the original code, the chat client uses only ASII standard characters, which is very limited in its capabilities. For example, does not allow you to use specialized characters, which would have taken the atmosphere of the old messengers, as well as regional characters. The lack of regional characters complicates the game for non-English-speaking servers. For example, the Russian-speaking player community Space Station 13 The Fluffy Frontier uses the original Skyrat-tg build. And the players of this community almost do not use the chat client to communicate due to the fact that they can not use Cyrillic characters.

commit 3b275f8
Author: Sheits <81964183+Sheits@users.noreply.github.com>
Date:   Tue Sep 28 16:57:52 2021 +1000

    Creates fly.ts for the new tgui prefs menu (tgstation#61728)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit 32518f6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 22:52:08 2021 -0700

    Automatic changelog generation for PR tgstation#61715 [ci skip]

commit 76c6754
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 07:52:05 2021 +0200

    secret recipes are now actually secret (tgstation#61715)

commit 67e7261
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 20:38:52 2021 -0700

    Automatic changelog generation for PR tgstation#61714 [ci skip]

commit 1f000ba
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Mon Sep 27 20:38:49 2021 -0700

    Fix word bounds on filters, where they would only be applied at the beginning (tgstation#61714)

commit 563cb1d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 19:06:06 2021 -0700

    Automatic changelog generation for PR tgstation#61607 [ci skip]

commit 744679b
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Mon Sep 27 20:06:02 2021 -0600

    Adds brand new ruins to the Icebox Ruins roster. (tgstation#61607)

commit 69fc80f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:52:00 2021 -0700

    Automatic changelog generation for PR tgstation#61680 [ci skip]

commit dbfa6c0
Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Date:   Tue Sep 28 01:51:57 2021 +0100

    Fix Genturf on Icebox (tgstation#61680)

commit a19f273
Author: Changelogs <action@github.com>
Date:   Tue Sep 28 00:11:28 2021 +0000

    Automatic changelog compile [ci skip]

commit c277a6f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:08:07 2021 -0700

    Automatic changelog generation for PR tgstation#61621 [ci skip]

commit 3c5d622
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Tue Sep 28 02:08:03 2021 +0200

    You can now use backslashes as an escape character for text modification. (tgstation#61621)

commit eac67c9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:04:30 2021 -0700

    Automatic changelog generation for PR tgstation#61719 [ci skip]

commit 74be623
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 02:04:27 2021 +0200

    Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits (tgstation#61719)

commit ca4524e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 16:35:18 2021 -0700

    Automatic changelog generation for PR tgstation#61726 [ci skip]

commit d9ede13
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Mon Sep 27 16:35:15 2021 -0700

    if you give a monkey an instrument, it will begin playing the donkey kong theme (tgstation#61726)
EOBGames pushed a commit that referenced this pull request Jan 11, 2022
…on#63858)

* Pipe direction fix. (#1)

* Test

* Test

* Forgot to do this thing.

* Okay

* Why did I do that?

* Arghh

* Not sure how that got here.

* Revert "Pipe direction fix. (#1)" (#2)

This reverts commit 7ffd5b5.

* Smart pipes direction fix.

Hi

* Revert "Pipe direction fix. (#1)" (#4)

* Gaming

* Flushed

* Okay

* Changes a number.

Co-authored-by: 170141183460469231731687303715884105727 <58013024+170141183460469231731687303715884105727@users.noreply.github.com>
EOBGames pushed a commit that referenced this pull request Nov 26, 2022
…ed volume (tgstation#71327)

## About The Pull Request

Simple Unit Test that seeks to ensure that we don't put too much of a
reagent in a container when the container doesn't have enough volume to
accept all of it. Nothing bad would happen, but it's just silly really.

I also fixed all of the instances that this was broken in.
## Why It's Good For The Game

Prevents buggy regressions, such as those found in tgstation#71206.

```txt
[2022-11-18 03:32:30.736]     FAILURE #1: Canned Laughter (/obj/item/reagent_containers/cup/soda_cans/canned_laughter) has 50 units of reagents, but only 30 units of space. at code/modules/unit_tests/container_sanity.dm:21
 -     FAILURE #2: T-Borg's tonic water (/obj/item/reagent_containers/cup/soda_cans/tonic) has 50 units of reagents, but only 30 units of space. at code/modules/unit_tests/container_sanity.dm:21
 -     FAILURE #3: The soda water (/obj/item/reagent_containers/cup/soda_cans/sodawater) has 50 units of reagents, but only 30 units of space. at code/modules/unit_tests/container_sanity.dm:21
```
## Changelog

:cl:
fix: Canned Laughter, T-Borg's Tonic Water, and Soda Water cans should
all come with the expected marketed 50 units of goodness, rather than
cheaping out on materials for only 30 units of can volume.
/:cl:

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
EOBGames pushed a commit that referenced this pull request Sep 23, 2023
…nent (tgstation#77539)

## About The Pull Request

Hey there,

I've personally fallen for this stupid thing twice (in tgstation#77503 and tgstation#75627
(d357516)), so I decided to spend a few
hours to crack out a unit test to ensure that I (and no one else) falls
for this stupid thing again.

Let me know if there's a smarter way to code something like this, but I
couldn't figure out a better way to accomodate the current framework and
be as agnostic to certain oddities as possible.
## Why It's Good For The Game
Catches stuff like this:

```txt
[2023-08-11 21:10:04.019]     FAILURE #1: The mob Garden Gnome does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #2: The mob the morph does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #3: The mob the guard spiderling (946) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #4: The mob the ambush spiderling (255) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #5: The mob the scout spiderling (375) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #6: The mob the flesh spiderling (337) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #7: The mob the hunter spiderling (869) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #8: The mob the nurse spiderling (629) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #9: The mob the tangle spiderling (19) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #10: The mob the broodmother spiderling (855) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #11: The mob the viper spiderling (519) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #12: The mob the tarantula spiderling (963) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #13: The mob the spiderling (100) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
```

(ignore the part about gnomes and morphs, this was an earlier version of
the unit test. everything else was relevant and is fixed)
## Changelog
:cl:
fix: Growing spiders will now retaliate against you like they were
always meant to.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet