Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. #61532

Krysonism · 2021-09-17T23:44:01Z

About The Pull Request

This PR introduces a new craftable food: dog eat dog envirochow

Feeding this to a beast, bug or reptile increases its maximum health by 10 hp or 10% of what their maximum health was when the first stack was applied, whichever is greater.

It also heals them for 20hp or 20% of their maximum health, whichever is greater.

Maxium of 3 applications for a 30 hp or 30% health increase.

the recipe is:

2 corgi meat, 5 vitamin

The crafting category is meat.

Why It's Good For The Game

This PR adds some value to the corgi mob, which is interesting since it can be obtained through a several methods.

Previously people who did cytology would almost exclusively try to grow the biggest meanest mob and disregard everything else.

And even those who chose to make a utility creature, would probably choose to make cats since they are more profitable or carps since you can ride them and their meat is more useful.

This addition makes corgi farming a good side activity while you wait for sentience potions for your bigger mobs.

It also affirms the goal of cytology to make scientists create a few quality mob they are invested in, rather the quantity approach seen with gold slime strategies.

Changelog

🆑
expansion: Added new food, envirochow; it permanently increases the max hp of animals.
/:cl:

Krysonism · 2021-09-17T23:45:48Z

nooooooo i accidentally tagged it as mechanic

Krysonism · 2021-09-17T23:53:28Z

I want slimes and oozes to be able to use this in the future, but it turns out there isn't a slime biotype yet.

TemporalOroboros · 2021-09-17T23:56:55Z

Just so you know, the MOB_BEAST bit means this can be applied to goliath broodmothers. Otherwise, I look forward to the eventually inevitable swarm of 40 health bees.

Bawhoppen · 2021-09-28T00:01:44Z

We get close to readding steal corgi meat objective every day

tralezab

final note: thanks for cleaning up dmis a bit

code/game/objects/items/food/misc.dm

code/__DEFINES/status_effects.dm

code/datums/status_effects/buffs.dm

code/datums/status_effects/status_effect.dm

tralezab

i missed one last thing, everything else looks good

tralezab · 2021-09-28T23:30:46Z

code/game/objects/items/food/misc.dm

+	hungry_pet.visible_message(span_notice("[hungry_pet] chows down on [src]."),
+						span_nicegreen("You chow down on [src]."),
+						span_notice("You hear sloppy eating noises."))


only indent once for the visible message, kinda like how you don't want to over-indent for lists

commit c10e1e6 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 20:55:39 2021 -0700 Automatic changelog generation for PR tgstation#61746 [ci skip] commit 9bcc80c Author: 567Turtle <91508746+567Turtle@users.noreply.github.com> Date: Tue Sep 28 22:55:36 2021 -0500 Constructable Filing Cabinets (tgstation#61746) commit 2fd4e1d Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Tue Sep 28 19:12:45 2021 -0700 adds tralezab as a codeowner of datum ais (tgstation#61769) commit f45fb5d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:52:34 2021 -0700 Automatic changelog generation for PR tgstation#61739 [ci skip] commit 8473d44 Author: Zytolg <33048583+Zytolg@users.noreply.github.com> Date: Tue Sep 28 18:52:30 2021 -0600 Ditches the Spare Monkey-Operated Firealarm in Kilostaiton Genetics (tgstation#61739) Co-authored-by: Zytolg <theoriginaldash@gmail,com> commit e135108 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:52:14 2021 -0700 Automatic changelog generation for PR tgstation#61738 [ci skip] commit b626fad Author: Zytolg <33048583+Zytolg@users.noreply.github.com> Date: Tue Sep 28 18:52:10 2021 -0600 Removes Duplicate Disposals Pipe and Glass Table from MetaENG (tgstation#61738) * Removes Duplicate Disposals Pipe and Glass Table from MetaENG * Plumbing and Power too Co-authored-by: Zytolg <theoriginaldash@gmail,com> commit 87cf6e7 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:51:28 2021 -0700 Automatic changelog generation for PR tgstation#61733 [ci skip] commit 6174323 Author: esainane <esainane+github@gmail.com> Date: Wed Sep 29 13:51:25 2021 +1300 Derelict: Remove duplicate APCs (tgstation#61733) Two APCs were fighting for control over `/area/ruin/space/derelict/bridge/access` at (66,80) and (63,61). This removes the APC at (63,61) and the two wires leading up to it. Two APCs were fighting for control over `/area/ruin/space/derelict/hallway/secondary` at (35,23) and (58,24). This removes the APC at (58,24), which is directly over a wire path, so does not require any power cables to be removed. commit a43209f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:51:11 2021 -0700 Automatic changelog generation for PR tgstation#61735 [ci skip] commit 9e40039 Author: Iamgoofball <iamgoofball@gmail.com> Date: Tue Sep 28 17:51:08 2021 -0700 Fixes references to now dead gangs in Families objectives. (tgstation#61735) commit 44c424f Author: Changelogs <action@github.com> Date: Wed Sep 29 00:11:00 2021 +0000 Automatic changelog compile [ci skip] commit 9d200cb Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:07:45 2021 -0700 Automatic changelog generation for PR tgstation#61532 [ci skip] commit 65267ba Author: Krysonism <49783092+Krysonism@users.noreply.github.com> Date: Wed Sep 29 02:07:41 2021 +0200 Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. (tgstation#61532) * doggy dog world * space begone * suggestions from review * removes frog related oopsie * indent fix commit 67194ea Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 16:52:16 2021 -0700 Automatic changelog generation for PR tgstation#61722 [ci skip] commit 61c30cc Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com> Date: Wed Sep 29 01:52:12 2021 +0200 ntoscard templates fix (tgstation#61722) commit 378da49 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 16:47:47 2021 -0700 Automatic changelog generation for PR tgstation#61730 [ci skip] commit 81989f0 Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Wed Sep 29 01:47:44 2021 +0200 Fix baselighting not respecting changeturfs (tgstation#61730) commit 1846c2d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 15:03:30 2021 -0700 Automatic changelog generation for PR tgstation#61716 [ci skip] commit e330485 Author: Thunder12345 <Thunder12345@users.noreply.github.com> Date: Tue Sep 28 23:03:27 2021 +0100 Replaces CTF hardsuits with new armoured vests (tgstation#61716) Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk> commit 84c7b68 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 14:21:30 2021 -0700 Automatic changelog generation for PR tgstation#61736 [ci skip] commit 643645b Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com> Date: Tue Sep 28 18:21:27 2021 -0300 Makes colo cup sprites actually consistent, and a small edit to a joke. (tgstation#61736) * Update drinks.dm * adds actual colo cups sprites lol im dumb * fixes a small sprite error commit c1fd222 Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Tue Sep 28 17:16:09 2021 -0400 dehardcodes limb icons (tgstation#61570) This is a small change aimed at helping downstream modularity. Currently the file these sprites use are hardcoded with a define, this removes that and instead moves it to a var. I guess the thing is defaults should be overridable, it's just we've never ran into a case where it's needed, so adding that functionality on its own looks really weird annoying. I don't like adding stuff that's only useful to downstreams, for various reasons, but this seems ok after some thought. fulfills the promise of _DEFAULT. -Lemon commit eec8463 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 12:45:42 2021 -0700 Automatic changelog generation for PR tgstation#61694 [ci skip] commit 496a768 Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com> Date: Tue Sep 28 15:45:38 2021 -0400 [MDB Ignore] Make shuttle windows deconstructable (tgstation#61694) * shuttle windows * refactor reinf windows plasma and shuttle only * messed up one change * i am actually blind * made and did file commit a66ef31 Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Tue Sep 28 14:15:11 2021 -0500 Corrects mapload args that sprug up in the past few days (tgstation#61759) See tgstation#61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated. commit 4fc5897 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 11:56:21 2021 -0700 Automatic changelog generation for PR tgstation#61725 [ci skip] commit 43a2b90 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Tue Sep 28 20:56:17 2021 +0200 renames enable debug verbs to enable mapping verbs (tgstation#61725) its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs commit 4413bbc Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 08:00:07 2021 -0700 Automatic changelog generation for PR tgstation#61724 [ci skip] commit a23b275 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Tue Sep 28 08:00:01 2021 -0700 Fixes check AI laws collapsing, making them unreadable (tgstation#61724) Previously, this would be putting (x2) next to the first 3 laws, and it would look like the 2nd cyborg had no laws. commit a62262f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 07:58:50 2021 -0700 Automatic changelog generation for PR tgstation#61723 [ci skip] commit 4eee6a1 Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Date: Tue Sep 28 15:58:47 2021 +0100 Fixes contractor drop pods not being clickable due to suspected BYOND issue. (tgstation#61723) Fixes tgstation#61695 When breaking the entire problem down, I identified the point in time at which the pod stopped being clickable Spawning in pods manually and running their various procs couldn't replicate the issue. As a result, I eliminated pod code as the root cause and focused on the pod_landingzone that control them. I considered the debris as a possible cause following: tgstation#61695 However, removing the debris actually removed ALL clickable area for the pods. The debris overlap was the only part that let me click on the pods. So then I set to hacking away at any animation code. At one point I removed both the animates animate(pod.get_filter("motionblur"), y = 0, time = pod.delays[POD_FALLING], flags = ANIMATION_PARALLEL) animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING, flags = ANIMATION_PARALLEL) //Make the pod fall! At an angle! from /obj/effect/pod_landingzone/proc/beginLaunch and the problem still persisted. When I removed pod.add_filter("motionblur",1,list("type"="motion_blur", "x"=0, "y"=3)) after this (the effect was permanently on the pod which made it pretty obvious as a possible cause) the problem vanished entirely. Without the motion blur filter applied, pods now function properly. As a result, I believe this is a BYOND issue. Someone with more brains than me can probably work out a test case. Until someone with more brains than me comes along to fix it, removing the motion blur filter is my solution. commit 1859df5 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 07:55:59 2021 -0700 Automatic changelog generation for PR tgstation#61229 [ci skip] commit 29c49fd Author: dragomagol <66640614+dragomagol@users.noreply.github.com> Date: Tue Sep 28 07:55:55 2021 -0700 Ports animated locker doors (tgstation#61229) ## About The Pull Request Ports locker door animations from Yogstation! yogstation13/Yogstation#9706 Skyrat-SS13/Skyrat-tg#6767 ## Why It's Good For The Game The locker opening animation is really nice, it's a shame we don't have it yet. commit 6189b88 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 02:08:57 2021 -0700 Automatic changelog generation for PR tgstation#61692 [ci skip] commit df1260f Author: CRITAWAKETS <sebastienracicot@hotmail.com> Date: Tue Sep 28 05:08:53 2021 -0400 Fixes the auxiliary base construction console. (tgstation#61692) commit c254707 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 02:05:30 2021 -0700 Automatic changelog generation for PR tgstation#61698 [ci skip] commit 6317b7b Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Tue Sep 28 11:05:27 2021 +0200 Fix connect loc not respecting phasing in some cases when it should (tgstation#61698) commit 26df314 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 00:01:11 2021 -0700 Automatic changelog generation for PR tgstation#60920 [ci skip] commit ff41f8a Author: twilightwanderer <88540658+twilightwanderer@users.noreply.github.com> Date: Tue Sep 28 10:01:07 2021 +0300 Fixing the chat client (tgstation#60920) Corrects the chat restriction on using ASII characters only. (This PR was created for Skyrat-TG, but the collaborator of that repository asked me to adapt this PR for tgstation.) This will fix tgstation#54598 In the original code, the chat client uses only ASII standard characters, which is very limited in its capabilities. For example, does not allow you to use specialized characters, which would have taken the atmosphere of the old messengers, as well as regional characters. The lack of regional characters complicates the game for non-English-speaking servers. For example, the Russian-speaking player community Space Station 13 The Fluffy Frontier uses the original Skyrat-tg build. And the players of this community almost do not use the chat client to communicate due to the fact that they can not use Cyrillic characters. commit 3b275f8 Author: Sheits <81964183+Sheits@users.noreply.github.com> Date: Tue Sep 28 16:57:52 2021 +1000 Creates fly.ts for the new tgui prefs menu (tgstation#61728) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 32518f6 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 22:52:08 2021 -0700 Automatic changelog generation for PR tgstation#61715 [ci skip] commit 76c6754 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Tue Sep 28 07:52:05 2021 +0200 secret recipes are now actually secret (tgstation#61715) commit 67e7261 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 20:38:52 2021 -0700 Automatic changelog generation for PR tgstation#61714 [ci skip] commit 1f000ba Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Mon Sep 27 20:38:49 2021 -0700 Fix word bounds on filters, where they would only be applied at the beginning (tgstation#61714) commit 563cb1d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 19:06:06 2021 -0700 Automatic changelog generation for PR tgstation#61607 [ci skip] commit 744679b Author: Zytolg <33048583+Zytolg@users.noreply.github.com> Date: Mon Sep 27 20:06:02 2021 -0600 Adds brand new ruins to the Icebox Ruins roster. (tgstation#61607) commit 69fc80f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 17:52:00 2021 -0700 Automatic changelog generation for PR tgstation#61680 [ci skip] commit dbfa6c0 Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com> Date: Tue Sep 28 01:51:57 2021 +0100 Fix Genturf on Icebox (tgstation#61680) commit a19f273 Author: Changelogs <action@github.com> Date: Tue Sep 28 00:11:28 2021 +0000 Automatic changelog compile [ci skip] commit c277a6f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 17:08:07 2021 -0700 Automatic changelog generation for PR tgstation#61621 [ci skip] commit 3c5d622 Author: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Tue Sep 28 02:08:03 2021 +0200 You can now use backslashes as an escape character for text modification. (tgstation#61621) commit eac67c9 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 17:04:30 2021 -0700 Automatic changelog generation for PR tgstation#61719 [ci skip] commit 74be623 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Tue Sep 28 02:04:27 2021 +0200 Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits (tgstation#61719) commit ca4524e Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 16:35:18 2021 -0700 Automatic changelog generation for PR tgstation#61726 [ci skip] commit d9ede13 Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Mon Sep 27 16:35:15 2021 -0700 if you give a monkey an instrument, it will begin playing the donkey kong theme (tgstation#61726)

…uffs health of selected simple mobs. (tgstation#879) * Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. (tgstation#61532) * doggy dog world * space begone * suggestions from review * removes frog related oopsie * indent fix * Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com>

doggy dog world

19134c7

Krysonism requested review from ShizCalev and Twaticus as code owners September 17, 2021 23:44

tgstation-server added Feature Exposes new bugs in interesting ways Sprites A bikeshed full of soulless bikes. labels Sep 17, 2021

space begone

6f75aec

Twaticus approved these changes Sep 20, 2021

View reviewed changes

github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Sep 23, 2021

conflict fix

8bc624c

tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Sep 26, 2021

tralezab requested changes Sep 28, 2021

View reviewed changes

tralezab marked this pull request as draft September 28, 2021 11:15

Krysonism added 2 commits September 29, 2021 00:58

suggestions from review

4ecd863

removes frog related oopsie

34ce4e1

Krysonism marked this pull request as ready for review September 28, 2021 23:05

tralezab requested changes Sep 28, 2021

View reviewed changes

indent fix

34c0cb9

tralezab merged commit 65267ba into master Sep 29, 2021

tralezab deleted the dogeatdog branch September 29, 2021 00:07

tgstation-server added a commit that referenced this pull request Sep 29, 2021

Automatic changelog generation for PR #61532 [ci skip]

9d200cb

github-actions bot added a commit that referenced this pull request Sep 29, 2021

Updating GBP balances for #61532

c9ac56e

SkyratBot mentioned this pull request Sep 29, 2021

[MIRROR] Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. [MDB IGNORE] Skyrat-SS13/Skyrat-tg#8471

Merged

ms-mirror-bot mentioned this pull request Sep 29, 2021

[MIRROR] Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. Mojave-Sun/mojave-sun-13#879

Merged

ShizCalev mentioned this pull request Jul 24, 2022

Dog eat dog envirochow not healing or buffing monsters #68717

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. #61532

Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. #61532

Krysonism commented Sep 17, 2021 •

edited

Krysonism commented Sep 17, 2021

Krysonism commented Sep 17, 2021 •

edited

TemporalOroboros commented Sep 17, 2021

Bawhoppen commented Sep 28, 2021

tralezab left a comment

tralezab left a comment •

edited

tralezab Sep 28, 2021

Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. #61532

Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. #61532

Conversation

Krysonism commented Sep 17, 2021 • edited

About The Pull Request

Why It's Good For The Game

Changelog

Krysonism commented Sep 17, 2021

Krysonism commented Sep 17, 2021 • edited

TemporalOroboros commented Sep 17, 2021

Bawhoppen commented Sep 28, 2021

tralezab left a comment

Choose a reason for hiding this comment

tralezab left a comment • edited

Choose a reason for hiding this comment

tralezab Sep 28, 2021

Choose a reason for hiding this comment

Krysonism commented Sep 17, 2021 •

edited

Krysonism commented Sep 17, 2021 •

edited

tralezab left a comment •

edited