every case of initialize that should have mapload, does #61623

tralezab · 2021-09-21T19:12:01Z

About The Pull Request

stop forgetting to include mapload, if you don't include it then every single subtype past it by default doesn't include it

for example, obj/item didn't include mapload so every single item by default didn't fill in mapload

Regex used:

procs without args, not even regex

/Initialize()

procs with args
\/Initialize\((?!mapload)((.)*\w)?

cleanup of things i didn't want to mapload:
\/datum\/(.)*\/Initialize\(mapload

Why It's Good For The Game

Changelog

not player facing

tralezab · 2021-09-21T19:12:26Z

first for

code/datums/components/food/decomposition.dm

…var-args-mapload

commit b463e0417e45a19f9b1a95c48326cf04e4fd814e Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sat Sep 25 01:32:43 2021 -0700 Automatic changelog generation for PR #61676 [ci skip] commit ec69a3433e3b9cca7154e0c0c29a0848887f8e1e Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Sat Sep 25 01:32:40 2021 -0700 Fix incorrect antagonists showing up on be_special (#61676) Fixed not being able to disable specific antagonists randomly. For me, this meant I was unable to toggle cultist and traitor. This might've been a migration bug, though it's safe to just sanitize it on read. commit 472c39ee3ae62682f9093616f72ea559d5466dbd Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sat Sep 25 01:10:23 2021 -0700 Automatic changelog generation for PR #61520 [ci skip] commit 249d6e851c239213551216e76891f625542764a6 Author: necromanceranne <40847847+necromanceranne@users.noreply.github.com> Date: Sat Sep 25 18:10:19 2021 +1000 Meteor guns, the admin weapon, once again harms living mobs (#61520) When explosions got refactored, this stopped harming mobs because it lacked a check. Goof must have missed this, but it's also probably not as simple to put everything back as it was. This mostly restores old behaviour by putting the relevant code into on_hit() and out of Bump() when handling living mobs, since it's a projectile and all. I don't know if the values I added are appropriate but given that the old behaviour was a high damage localized explosion, it almost certainly isn't far off. fixes #61244 commit 95708475a4cdea7ed23a1b4718e8dd4d15c61f21 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sat Sep 25 00:23:08 2021 -0700 Automatic changelog generation for PR #60721 [ci skip] commit 6cf165df4a5bd97c3b40c3da2e35289837d79526 Author: MetalClone <metalclone@protonmail.com> Date: Sat Sep 25 03:23:05 2021 -0400 Added Two New Moustache Styles on the Character Setup. (#60721) commit 091d07e6012dcd1347f5fa98fc32b3f5a13a663d Author: Zephyr <12817816+ZephyrTFA@users.noreply.github.com> Date: Fri Sep 24 21:44:23 2021 -0400 Update acid.dm (#61684) commit 6fd1599516398ba165ff9b5e885500c2fc131b47 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Fri Sep 24 18:35:02 2021 -0700 Automatic changelog generation for PR #61671 [ci skip] commit 2fa44b8eeae0cdf428a8bfa81b6b879626160f13 Author: Krysonism <49783092+Krysonism@users.noreply.github.com> Date: Sat Sep 25 03:34:58 2021 +0200 Fixes neglected fern cell ine amounts + reverts undocumented crate spawner change that removed my brand new fern from the game. (#61671) commit b00b2c0d5d37e0c73877167eb582c0b82174f281 Author: Changelogs <action@github.com> Date: Sat Sep 25 00:10:50 2021 +0000 Automatic changelog compile [ci skip] commit dc3c26dcf6ff9716373aa7e92bc0dfdbe6559a02 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Fri Sep 24 17:02:53 2021 -0700 Automatic changelog generation for PR #61679 [ci skip] commit 6c5d47dc3a5221260de6423ce5013e66e754ab51 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Sat Sep 25 02:02:50 2021 +0200 Refactors borg reskinning (#61679) * refactors borg reskinning * shits fukt * drinking champgne made of an angel's tears and pain but i feel celestial * drinking champagne made by the angel who goes by the name of glittering gabriel * written in the stars * i hate maintainers! i hate maintainers! people driving fancy cars look like biddles in the stars * Update code/modules/mob/living/silicon/robot/robot_model.dm * bitch commit 979e9f44183f9e1b545e20e094dfe66456700e51 Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com> Date: Sat Sep 25 00:04:10 2021 +0200 DeepScan fixes (#61635) This PR fixes a majority of the current high to medium severity issues detected by the DeepScan application, hopefully improving code quality a little bit. Most of the fixes should be quite straightforward - insufficient or unnecessary null checks (like in the required_experiments case where its assigned as an empty list if its null in the first place), or checking a condition that is constant. I have tested ingame all fixes that were possible to reasonably test, and found no problems with them. View fixed issues here: https://deepscan.io/dashboard/#view=project&tid=12157&pid=15129&bid=298738&prid=&subview=issues&b=master&impact=%5B%22High%22%2C%22Medium%22%5D&page=1 commit 6add03af4eba9caf24c6e0ce2fb91d51d63cb2a0 Author: AnturK <AnturK@users.noreply.github.com> Date: Sat Sep 25 00:01:58 2021 +0200 Fix loading persistent randomized recipes without dedicated container. (#61665) Container path will be null if it's unset and is not randomized. Fixes #61661 commit 46b07ecc99b1038b25824873b0e2bb61257bdf6f Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Sat Sep 25 00:00:16 2021 +0200 Remove commented code (#61636) commit 84af3c9e823d377639d8207a31fa75ebb782ea85 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Fri Sep 24 14:59:48 2021 -0700 Automatic changelog generation for PR #61646 [ci skip] commit 6da0b443b5aa7dae546934a8dd290431742d9059 Author: Maurukas <66576896+Maurukas@users.noreply.github.com> Date: Fri Sep 24 14:59:44 2021 -0700 Fix Atmos Tanks Connecting to pipenets when mapped [MDB IGNORE] (#61646) ## About The Pull Request Fixes #61594 #59556 changed atmos tanks so that they do not automatically connect to adjacent pipes, but can support up to 4 directional connection, and merge with neighboring tanks to form one large one. Old tanks would connect based on their dir variable. New tanks would not. A work around was to varedit both dir *and* initialize_direction variables to the same value in the map editor - but this is not expected behavior for mapping. This adds a check for mapload in the tank's initialize proc. If the tank is initializing during mapload, dir will be copied to initialize_directions (as it is in most other atmos devices), and the tank will connect in the specified direction(s). The behavior of player constructed tanks is unchanged. ## Why It's Good For The Game The primary purpose of these large, constructed atmos tanks is to provide a bulk source of gas to a map, such as a plasma tank for the incinerator, or air supply tanks to ruins or disconnected parts of the station. This enables them to be readily used for their purpose. This fixes the 41 broken atmospheric tanks currently mapped in the codebase. commit e8fe67c25d80b27543c6e8183912175abccb7526 Author: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Fri Sep 24 23:59:25 2021 +0200 Fixes the HAS_TRAIT_FROM_ONLY macro (#61650) Fixing a broken macro that's only used in one place (for now). commit a3147aa9b18354f72ac7b66123055fe3dbe670ac Author: tgstation-server <tgstation-server@tgstation13.org> Date: Fri Sep 24 14:59:12 2021 -0700 Automatic changelog generation for PR #61656 [ci skip] commit 6414064859328488756ad64abaf2881ae777aa54 Author: Iamgoofball <iamgoofball@gmail.com> Date: Fri Sep 24 14:59:08 2021 -0700 Fixes the logging text on respawn to correctly say it's respawn instead of "abandon mob" (#61656) Fixes the logging for the respawn button to actually say it's for respawning. commit 90ae5135f0e21bca55137532d2850178cf6f9663 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Fri Sep 24 14:58:49 2021 -0700 Automatic changelog generation for PR #61657 [ci skip] commit 1064b84a9a20456a5aaad783af0f17388ccbacb8 Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Fri Sep 24 14:58:46 2021 -0700 Fully Immersing someone now reminds them to roleplay correctly (#61657) Please roleplay correctly! commit 55dfa7e92668c240ce309446210c9171b31761f5 Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Fri Sep 24 23:58:28 2021 +0200 Remove atoms from vis_contents in Destroy() (#61659) setting vis locs can be used to remove or add it to other objects vis contents and we can use this to null out refs in vis contents in destroy commit 6c01cc2c010c8dc15c5500434ae8e55261511781 Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Fri Sep 24 14:56:50 2021 -0700 every case of initialize that should have mapload, does (#61623) ## About The Pull Request stop forgetting to include mapload, if you don't include it then every single subtype past it by default doesn't include it for example, `obj/item` didn't include mapload so every single item by default didn't fill in mapload ![](https://media.discordapp.net/attachments/823293417186000909/875122648605147146/image0.gif) ## Regex used: procs without args, not even regex `/Initialize()` procs with args `\/Initialize\((?!mapload)((.)*\w)?` cleanup of things i didn't want to mapload: `\/datum\/(.)*\/Initialize\(mapload` commit 02acd28602cf3e29381f88f222e15706b6dedc60 Author: Ghilker <42839747+Ghilker@users.noreply.github.com> Date: Fri Sep 24 23:23:42 2021 +0200 atoms.dm and atoms_movable.dm var name upgrade (#61525) Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> commit c4c10a6a9efa158bafa6ecf45f89cb354806aded Author: tgstation-server <tgstation-server@tgstation13.org> Date: Fri Sep 24 12:49:43 2021 -0700 Automatic changelog generation for PR #61514 [ci skip] commit 8e29010081ed12a7f940aef0d94c2ac72ac1d96c Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Fri Sep 24 12:49:40 2021 -0700 fixes malfunctioning bot's runtimes (#61514) * malf fixed :3 * new icons commit 3a68fc8e0debd50af7bd9aa5e1c7fc7d7baba74d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Fri Sep 24 05:39:50 2021 -0700 Automatic changelog generation for PR #61029 [ci skip] commit 1126f2207364e82f5c009e087d4e9c410964b066 Author: AMonkeyThatCodes <20987591+AMonkeyThatCodes@users.noreply.github.com> Date: Fri Sep 24 14:39:46 2021 +0200 Fixes ooze eating (#61029) Oozes now properly communicates with the edible component to be able to eat objects. commit f13dd0695d97cd0394dfea6f9c69b8d543ad7fa7 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Thu Sep 23 20:07:03 2021 -0700 Spiders/carp will now pull/move water/welding fuel tanks/canisters slower and won't be able to attack stationary atmospherics equipment (#61616) Adds 2 new elements, one for slowing down pulling of dangerous objects (dispenser tanks and canisters), and one for preventing hostile attacking of elements in a typecache. Also updates the obj_flags bitfield 'cause I thought I was gonna use that, but I didn't. Adds these elements to spiders and space carp (from space dragon) commit 029a74c821f68bcbdd04473db1b6b1769256c55d Author: FlamingLily <80451102+FlamingLily@users.noreply.github.com> Date: Fri Sep 24 12:13:39 2021 +1000 Makes sure contractors only get extraction points on station (#61389) Extraction areas are now checked with GLOB.the_station_areas, and not just for being on the same Z level. This fixes #61287 (Contractor dropoff points being inside ruins) There's probably a more elegant way to do this, but it works. commit 14cea9a2bee821679b6b9cc2f868b30529333d30 Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Thu Sep 23 21:04:39 2021 -0500 Fixes some text inaccuracies in the changeling antagonist ui (#61563) The absorb ability is actually called Absorb DNA. Transform Sting is not the sting changelings use to extract DNA. Extract DNA Sting is the correct ability. DNA collected from Extract DNA string do contribute to objectives. Less confusion / misinformation displayed. commit 2d46293b92cdcab320b7f649b85302a3a7a9c4bd Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Thu Sep 23 22:00:42 2021 -0400 Separates checking failing organs and checking damage thresholds on organs (#61614) So I fucked up in #61541 (a86e939bd4435965b81ae14665133e8fbc356b10) - I didn't test/know Inacusiate/Oculine to know thats what the code was for. Snowflake code in their on_life specifically there in case inacusiate/oculine was drank. I thought about trying to make it something all organs did, rather than reverting my change, though I can just revert it if thats preferable. Eyes/Ears can now be repaired with Inacusiate and Oculine again. commit fbaf28561e0843004d691f4819ec47ecf7ac54f5 Author: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com> Date: Fri Sep 24 08:57:44 2021 +0700 Fixes crowbar and welder secondary attack calling the primary one for doors (#61612) RMB-ing tools on doors failed to cancel the attack chain, this fixes that. Fixes #61555 (Doors instantly closing when right clicked) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 44dc49b766adf16db5edd019d4805e4e2bcf3ae8 Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Date: Fri Sep 24 02:56:12 2021 +0100 Proccall handler hotfix (#61642) Fixes proccall handlers runtiming because GLOB.AdminProcCallHandler not being set commit 7a2082afe05057679c149a94900bfae6de71f868 Author: Maurukas <66576896+Maurukas@users.noreply.github.com> Date: Thu Sep 23 17:36:11 2021 -0700 Metastation Merge Conflict marker cleanup (#61667) * Fix merge conflict markers in Meta and Zoo ruin Removes all /obj merge conflicts and doubled up spawners on metastation and abandonedzoo ruin * Kilo too * They're coming out of Tram's walls! commit 36f5a19fea882eeaaa4edc936512ebbb2a54c834 Author: sergeirocks100 <31294280+sergeirocks100@users.noreply.github.com> Date: Thu Sep 23 19:51:58 2021 -0400 Map adjustments to Ice Box's kitchen. (#61479) commit e401aa5db33b8c3f7b6f1f3a0ff82a87ef4b2c81 Author: Zytolg <33048583+Zytolg@users.noreply.github.com> Date: Thu Sep 23 17:47:11 2021 -0600 Cleans up mapmerge artifacts on Delta and Icebox (#61668) * Cleans up mapmerge artifacts on Delta and Icebox * The rest of Delta's Merge Markers commit 8f9a9f574573572c2c9cd4e1fa3b9efdd7de1a84 Author: Zytolg <33048583+Zytolg@users.noreply.github.com> Date: Thu Sep 23 16:23:06 2021 -0600 Emergency Tramstation Fixes (#61653) * Emergency Tramstation Fixes * Fixes disconnected pipes in maint commit 7def9d23b48adc773ffd33b53f936263af3fbd6f Author: FernandoJ8 <80640114+FernandoJ8@users.noreply.github.com> Date: Thu Sep 23 23:34:00 2021 +0200 Removes the superfluous breathing mask from the survival box of plasmamen (#61603) What it says in the title, plasmamen no longer have a breathing mask in their survival box. commit 9902d641355e66267b12b78de4a546ee9c163e22 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Wed Sep 22 20:42:02 2021 -0700 Fix quirks being automatically removed (#61631) Quirks were being validated before the subsystem was setup, this moves to get_quirks() which initiates if needed. commit 3be72ac6279562ff285c407802d950a8b8957352 Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Date: Wed Sep 22 23:39:35 2021 -0400 Refactors offering items, adds cheek kisses (#61590) commit c4f6af36603d0c5ab5b0e41eddabd51365ffa4ff Author: Ghilker <42839747+Ghilker@users.noreply.github.com> Date: Thu Sep 23 04:34:23 2021 +0200 _machinery.dm hotfix (#61618) messed up a couple of places where the parent wasn't being called (deconstruct proc) or the proc wouldn't return the value at the end (attack_robot and check_nap_violation procs), this should fix those commit e26a859016188c3573a36a976db45ce3505523e2 Author: Tim <timothymtorres@gmail.com> Date: Wed Sep 22 21:30:28 2021 -0500 Mapping DLC - Random Spawner Pack [MDB IGNORE] (#60522) First off, I am aware of the Feature Freeze for this month. This PR was initially started in #60401 about a month ago to break the changes into smaller PRs. The end result for this PR is a poor man's attempt at roguelike procedural generation. Enjoy! Link to the README for how the new spawner system works. Added the following new random mapping spawners: pen, crayon, stamp, paper, pamphlet, briefcase, folder, wardrobe closet, wardrobe closet colored, backpack, narcotics, permabrig_weapon, permabrig_gear, prison, material, carpet, ornament, generic decoration, statue, showcase, paint, tool, tool_advanced, tool_rare, material_cheap, material, material_rare, toolbox, flashlight, canister, tank, vending_restock, atmospherics_portable, tracking_beacon, musical_instrument, gambling, coin, money_small, money, money_large, drugs, dice, cigarette_pack, cigarette, cigar, wallet_lighter, lighter, wallet_storage, deck, toy, toy_figure, booze, snack, condiment, cups, minor_healing, injector, surgery_tool, surgery_tool_advanced, surgery_tool_rare, firstaid_rare, firstaid, patient_stretcher, medical supplies, crate, crate_abandoned, girder, grille, lattice, spare_parts, table_or_rack, table, table_fancy, tank_holder, crate_empty, crate_loot, closet_private, closet_hallway, closet_empty, closet_maintencne, chair, chair_maintence, chair_flipped, chair_comfy, barricade, data_disk, graffiti, mopbucket, caution_sign, bucket, soap, box, bin, janitor_supplies, soup, salad, dinner Removed deprecated wizard trap, vault, and armory spawners. commit 21bc0d9e3a2ae0d31005efb80c2042374b898427 Author: JosephJomama <60072879+JosephJomama@users.noreply.github.com> Date: Wed Sep 22 20:21:10 2021 -0400 Adds SEAFOOD foodtype, felinid diet changes (#61506) commit f75ab87abd7c14d623cc08a266d1ad29a48b2bf5 Author: Changelogs <action@github.com> Date: Thu Sep 23 00:11:43 2021 +0000 Automatic changelog compile [ci skip] commit 7335da4aa30259c2e8fd5e3029eccfab0e76e133 Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Thu Sep 23 01:22:35 2021 +0200 Remove unused var (#61637) commit 16d541e975f60f8b1f94ca0a136b3c06af6de5f5 Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Date: Wed Sep 22 23:54:15 2021 +0100 [TM Candidate] Overhauls orbit and POI code to fix part of issue #61508 where players could observe /mob/living/new_player on the lobby. (#61509) commit 511b430f97ef2090961f349db014bce239196b94 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Wed Sep 22 14:23:46 2021 -0700 Automatic changelog generation for PR #61545 [ci skip] commit 8b0e41f8b394a4e66ea187cbdc774a615e687dda Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Date: Wed Sep 22 22:23:43 2021 +0100 Add a couple of missing traits to the global trait list used by VV with minor code cleanup (#61545) Adds a couple of missing traits to the global traits list for mobs. Does minor cleanup on the list's formatting including trailling commas and an indentation cleanup. commit fcc2036611080a20e5a9ae31fe346c3dbbf85302 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Wed Sep 22 14:23:08 2021 -0700 Automatic changelog generation for PR #61546 [ci skip] commit e3c909cf6e4174c52891b1d072d770978406b857 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Wed Sep 22 14:23:04 2021 -0700 Add admin panel for station traits (#61546) Admins can now revert (most) station traits before a round starts, as well as setup the station traits that will run next round. Previously, admins had no control over this system, making it sometimes painful for running planned events. It is not feasible to update the station traits of the current round, considering some apply pre-roundstart, but it is doable to edit the station traits of the next round. commit 7c070d6205d3db2bf728bcaee560d763f0c72b98 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Wed Sep 22 10:53:11 2021 -0700 Automatic changelog generation for PR #61567 [ci skip] commit 23e4d32fcc9e0aeda1612b731b85d9b16e8707db Author: Ghilker <42839747+Ghilker@users.noreply.github.com> Date: Wed Sep 22 19:53:07 2021 +0200 atmos components fix (#61567) fix scrubbers/vents/injectors/etc from being able to be placed on all layer on the same turf commit 547c490ae6feb5997b0100bec73f56fc6a5e8773 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Wed Sep 22 06:05:45 2021 -0700 Automatic changelog generation for PR #61414 [ci skip] commit 19712939edecd894511e96b2e7f8afd448f34076 Author: Krysonism <49783092+Krysonism@users.noreply.github.com> Date: Wed Sep 22 15:05:41 2021 +0200 Cytology content expansion: Jungle mobs. (#61414) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 3e6eec60b58af86c999cbb2ca80121485587b004 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Wed Sep 22 00:04:08 2021 -0700 Automatic changelog generation for PR #61582 [ci skip] commit b7ed43d7a8fce287b15a288b9f46b71e17bba049 Author: Y0SH1M4S73R <legoboyo@earthlink.net> Date: Wed Sep 22 03:04:05 2021 -0400 Adds a Datum port type for Admin Circuits (#61582) Admin circuit components were limited in their utility due to the setvar, getvar, proccall, and signal handler components only being able to operate on atoms. I have improved them by adding the datum datatype, which is used exclusively by the aforementioned components in place of the atom datatype their target port currently uses. Furthermore, an option for the expected output type has been added to the getvar and proccall components. This option defaults to any. commit 9dcd2531998bd6f65c4aebc4146a167357f8ada2 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 23:57:49 2021 -0700 Automatic changelog generation for PR #61586 [ci skip] commit 42a089a2dbf0a2e94a518b3b414b0e6845b34a5e Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Tue Sep 21 23:57:44 2021 -0700 Let you rebind Ctrl/Alt again (#61586) Fixes #61463 commit 579471bce53b7f3dd44717a77ecfe7da80ddc2d8 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:57:30 2021 -0700 Automatic changelog generation for PR #61540 [ci skip] commit d610ab97c80e89383dcf02dea1b53b98599f8f9b Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Date: Tue Sep 21 17:57:27 2021 -0700 Adds keyloop to the autoclearing ss, cleans up ssambience a bit (#61540) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit bd09787340e26735868372ee324cc179c94fb64b Author: Changelogs <action@github.com> Date: Wed Sep 22 00:18:13 2021 +0000 Automatic changelog compile [ci skip] commit ed2bb5944b71ca48698c16c0ef314ea73d1bb100 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:16:42 2021 -0700 Automatic changelog generation for PR #61261 [ci skip] commit 86d20cbee9f25920a5e3ddd1a638fcc4c432988c Author: EricZilla <81941674+EricZilla@users.noreply.github.com> Date: Tue Sep 21 20:16:40 2021 -0400 Updates Greyscale Colors of PDAs and Gives QM a Survival Pen since I was in there anyway. (#61261) About The Pull Request Hallo! This is part two of my PDA update, where I take the old hokey colors that were just left in to not rock the boat, and changes them to better fit the current aesthetic of the game. It also makes the captain's PDA have some more fanfare, without even adding a sprite, I just did a funny trick with the layers. In addition to that, I have updated the sprite for the survival pen, and made it so QMs start with one in their PDA. bespoke final peen Why It's Good For The Game The old PDA colors on the new PDA sprites were odd in a few places, this fixes that. I spent about a week or so going to different players of the different jobs and departments getting their input on what colors they'd like their PDAs to be, and now the best looking options that make sense, will be added in! Woo! Also I just think the QM having a emergency shovel is kind of cool, and its a really neat item that deserves just a little more love, so why not? Changelog cl expansion: Updated old GAGS colors for the PDAs based on user feedback imageadd: Updated appearance of the Survival Pen expansion: The Quartermaster now starts with a Survival Pen because its flavorful. Survival Pen has also been updated to use the fancy font, since, its fancy. /cl commit 2e0f88e9658ac436a1260679768d2b17684f69eb Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:15:51 2021 -0700 Automatic changelog generation for PR #61471 [ci skip] commit e0cd485fbc591e741aca6a17107241ddfe06436b Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Tue Sep 21 17:15:48 2021 -0700 Gives Mediborgs the Qualified Doctor skin from Yogstation#4988 About The Pull Request Original pr: yogstation13/Yogstation#4988 This sprite's origins... HAVE BEEN FOUND! Thank you grimm-hollowknight! Why It's Good For The Game Blutarch Mann found it and he is correct in that it is a hilarious and excellent borg sprite Changelog cl grimm-hollowknight, ported by tralezab with a few overlays imageadd: New borg sprite, from Yogstation! commit 1f4c6f529ce3ffba377f056bf3b8c19dcfecadf4 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:14:56 2021 -0700 Automatic changelog generation for PR #61492 [ci skip] commit 0ce04c12b1163b917a1de3066dea99506a14c166 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Tue Sep 21 17:14:53 2021 -0700 Fix quirks list in preferences menu being empty before SSquirks (#61492) About The Pull Request Fixes #61490 Changelog cl fix: Fixed the quirks list in the preferences menu sometimes being empty. /cl commit 36d03e45844c98cc05936eff912d74a512293167 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:14:09 2021 -0700 Automatic changelog generation for PR #61453 [ci skip] commit 5aee7c8147457a872bd0be9d48116a5ced55f6f4 Author: necromanceranne <40847847+necromanceranne@users.noreply.github.com> Date: Wed Sep 22 10:14:05 2021 +1000 Fixes flatgun drop code (#61453) About The Pull Request Changes the drop code handling from being in pickup (requiring some shitcode to work) to instead handle the same code in equip. This behaviour is nonsense, but it at least now works as intended. fixes #61281 Why It's Good For The Game Shit ruin with bad loot and bullshit like this Changelog cl fix: Stickmen flatguns now properly drop out of your hands when picked up, as intended. /cl commit f7813b8f2cee81dd14e0579b367eb7a57b5d925c Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:12:48 2021 -0700 Automatic changelog generation for PR #61377 [ci skip] commit 5074c3c90f742878d8b0907a26724ff310c1b0f7 Author: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Wed Sep 22 02:12:45 2021 +0200 Fixing an oversight with porta_turret/proc/assess_perp (#61377) About The Pull Request The weapons authorization setting for turrets will now check for weapons on targets without a chameleon identification card instead of those with either a chameleon ID or no ID at all. Why It's Good For The Game I'm pretty sure this is some human error. The setting doesn't currently work on your average crewmember. Changelog cl fix: The weapons authorization setting for turrets will now check for weapons on targets without a chameleon identification card instead of those with either a chameleon ID or no ID at all. /cl commit 9d251db43e7bfb444bb8ac6a359213ea3a7ff27a Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:12:32 2021 -0700 Automatic changelog generation for PR #61574 [ci skip] commit 6fde2a7b9f4de9cd08a5711e6b3126b2ab0b8738 Author: TheSmallBlue <ilanmori@hotmail.com> Date: Tue Sep 21 21:12:29 2021 -0300 Adds the Proximity Pinpointer circuit component! (#61574) commit b080da385f9073a3d59dd0ab5e2d7a90eb536c55 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:11:39 2021 -0700 Automatic changelog generation for PR #61430 [ci skip] commit 549b4590c5d8ea5796fdd702f423f43b7ea7cd0a Author: MMMiracles <lolaccount1@hotmail.com> Date: Tue Sep 21 20:11:35 2021 -0400 Tramstation Department Swap (#61430) About The Pull Request Swaps the Security and Service wing around entirely, including some new maintenance sections. Also makes the asteroid rock leave behind breathable flooring to incentivize digging tunnels through it. Why It's Good For The Game Makes it so that each wing has at least one gameplay-important department attached to it so there are equal reasons to go between each wing fully instead of just mostly the last two. Changelog cl MMMiracles add: Tramstation's Security and Service wing has been flipped around. add: Tramstation's commissary has been placed above in the central wing beside the kitchen. add: Tramstation's EVA and Gateway rooms have been adjusted. EVA now has one extra suit storage unit. add: Tramstation's maintenance near the Service and Security wing has had reworked layouts. add: Tramstation's asteroid now leaves behind breathable turfs so digging out a room isn't as tedious. /cl commit 400bd26a10a812d2427cc8b9ea6876a4be885fd9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Sep 22 12:11:17 2021 +1200 Bump pillow from 8.2.0 to 8.3.2 in /tools (#61358) Bumps [pillow](https://github.com/python-pillow/Pillow) from 8.2.0 to 8.3.2. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst) - [Commits](https://github.com/python-pillow/Pillow/compare/8.2.0...8.3.2) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 402838246fcd16b50aa3f4bdd66763e3d04cc659 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:09:20 2021 -0700 Automatic changelog generation for PR #61482 [ci skip] commit 9295f0d5bd30303325819a67d7086fa82d94eca8 Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Date: Wed Sep 22 01:09:16 2021 +0100 [s] Fixed admins being able to bypass proccall protections via remote sdql and circuits. (#61482) About The Pull Request Admins can bypass IsAdminAdvancedProcCall checks by using these methods of proccall because proccall protection is kinda dumb. This has been tweaked so that there is proper proccall protection for these methods of proccall. Code is hacky, but there's not much of a choice if we want procs to be properly protected from admin proccalls from any sort of remote source. If anyone has a better idea on how to implement this, feel free to hit me up. We need a special global mob that handles proccalls from sources that may not have a usr/client to refer back to. IsAdminAdvancedProcCall() relies usr being defined, so if no usr is defined, then this will always return false. This has been adjusted so that proccalls without a usr/client to refer back to will instead set usr to this special mob, which will then let the IsAdminAdvancedProcCall() return true by comparing whether usr == this special global mob. Why It's Good For The Game Admins can no longer bypass IsAdminAdvancedProcCall checks. Changelog cl admin: Admins are no longer able to bypass proccall protections using remote methods of proccalling. /cl commit 3ba9694b4a9e4269b526c4165eb488da7f7f4235 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:05:38 2021 -0700 Automatic changelog generation for PR #61595 [ci skip] commit e72cbf722c25ed10a5fcc4116fa9ceac033714b2 Author: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Wed Sep 22 02:05:35 2021 +0200 Fixes the mind's name for evolved aliens. (#61595) commit 8b44fc0c8f0699227aa873e17bf437994829cf05 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:05:13 2021 -0700 Automatic changelog generation for PR #61608 [ci skip] commit 8fa08f7945fb0994a907bfe54d5a53f8981f13d2 Author: MrZoraman <MrZoraman@Gmail.com> Date: Tue Sep 21 17:05:10 2021 -0700 Fix the grammar for the message shown when appraising great art. (#61608) commit 397e8581354e578d65c1ffbff3345bb1b05695e0 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:04:10 2021 -0700 Automatic changelog generation for PR #61604 [ci skip] commit e00e12ecebce6406b424476fb8609e58b0e55941 Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Date: Wed Sep 22 01:04:07 2021 +0100 Fixes progress bars (#61604) Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> commit e3808f48a23ad9b6b73453ebbbb175541ffed3cf Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:03:53 2021 -0700 Automatic changelog generation for PR #61601 [ci skip] commit b195036881ff12815988d55935ebef42c61e1197 Author: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Wed Sep 22 02:03:50 2021 +0200 Fixed hitting people accidentally with food if their mouth is covered. (#61601) commit a3e281ff1022e3da2967eef8b5548d6477bc7f3b Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:03:20 2021 -0700 Automatic changelog generation for PR #61602 [ci skip] commit a80026018aff47ad3ebb9863e07033f79f5879c0 Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Date: Wed Sep 22 01:03:15 2021 +0100 Adds the "speaker name" port to the voice activator circuit component (#61602) Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> commit 3e43e7321fb1f0467bbab9a4ebb092456b8f3c1d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:02:49 2021 -0700 Automatic changelog generation for PR #61605 [ci skip] commit cf2106e9eccacbd737dc67fb40c166cd216dea5b Author: Krysonism <49783092+Krysonism@users.noreply.github.com> Date: Wed Sep 22 02:02:46 2021 +0200 Gives mega arachnid's flesh snare a working sprite and moves restraint sprites to their own file. (#61605) commit 0edb6deba40584ce11f2b702d0bb90d33a3e8c89 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 17:02:40 2021 -0700 Automatic changelog generation for PR #61496 [ci skip] commit b1edd353b7aa7cedff09a0e81de12965a8b32847 Author: Aleksej Komarov <stylemistake@gmail.com> Date: Wed Sep 22 03:02:35 2021 +0300 tgui: Remove Flex IE fixes, Fix IE8 button clicks (#61496) At this point we're fixing a corpse, but at least this removes some IE related code. See changelog. computeFlexProps now properly inherits computeBoxProps, which makes its usage a bit cleaner. Changelog cl fix: tgui: IE8: Removed "iefix" css classes from Flex elements which resulted in unusable layout in complex UIs, such as tgui prefs. fix: tgui: IE8: Fixed button clicks. /cl commit c2a45ca9fca6fe614f54668a8fa75391cdccd07a Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 16:53:50 2021 -0700 Automatic changelog generation for PR #60865 [ci skip] commit b2e9d578ff78b0446317813fe9cf0df878c021d0 Author: AxieTheAxolotl <86872535+axietheaxolotl@users.noreply.github.com> Date: Wed Sep 22 09:53:48 2021 +1000 Resprites the CentCom armour suit, and adds mask + helmet to a suit storage thingy (#60865) The old CentCom armour outfit looked like shite, and was old as hell. It's not been updated to have the Cap's armour suit values and an edited version of the Cap's suit sprite, with a complimentary green. Also adds a suit storage unit that contains a unique gas mask as well, because why not. Old armour = cringe, looked bad New armour = very sexy, looks good and a suit storage thingy is good for anyone who wants to add it to a map per se, idk. commit 290fd98c95afce991623365c4a5c293d79dd6b5d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 16:48:45 2021 -0700 Automatic changelog generation for PR #61599 [ci skip] commit 97fcd4cfe77501c9e830ad01a1256f34c9e344ae Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com> Date: Tue Sep 21 20:48:42 2021 -0300 Space heater actually turns On with a right click this time. (#61599) I got bamboozled and this PR of mine #61334 (15c0080506abfadf001d4bf4e1b501aadbf9526b) isn't working as expected. The Space Heater turns on but wasn't processing Atmos to change the temperature around itself. This fixes that. commit 4b912beaec982d9e93d01a4523d8cdbaae432a9f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 16:37:24 2021 -0700 Automatic changelog generation for PR #61426 [ci skip] commit 711bc1526aa666512c2d161fdff452a471861b26 Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Date: Wed Sep 22 00:37:21 2021 +0100 Fixed ntnet components not being type safe (#61426) Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> commit 2fe71664d52f3f234ce64c470bb322d8c182f7dd Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 16:36:03 2021 -0700 Automatic changelog generation for PR #61547 [ci skip] commit c7b390ba069ebaa511ee6b79d787c2b62ea75752 Author: remuluson2 <remuluson2@gmail.com> Date: Wed Sep 22 01:36:00 2021 +0200 Razor Update (#61547) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 3c09dbcf699357c096981dd5ff5b755eba4e7c20 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 09:08:03 2021 -0700 Automatic changelog generation for PR #61583 [ci skip] commit c42ae65fcf1faa8c55fbb71e1ec5dc7f51a1f710 Author: necromanceranne <40847847+necromanceranne@users.noreply.github.com> Date: Wed Sep 22 02:07:58 2021 +1000 fixes a mistake I made with decomp (#61583) I somehow accidentally added a bacteria where it shouldn't have been. Closes #61581 commit acadabe1bdc26d4928708d1e4826243cac80b0b7 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 09:03:50 2021 -0700 Automatic changelog generation for PR #61589 [ci skip] commit 7b0c9266341779018875ae7f7e7497bd2c7c09dc Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Tue Sep 21 09:03:46 2021 -0700 Add support for multiple MOTD in config (#61589) ## About The Pull Request Changes "motd.txt" from being hardcoded to being a list of files which are read sequentially. CC @MrStonedOne for config changes ## Why It's Good For The Game On production, our MOTDs contain several individual sections: - Active Trial Admin threads - General game information - MRP specific information I want to automate number 1, I want number 2 to be shared among all servers, and I want number 3 to be shared among all MRP servers. commit 7c1f548ef40322e7f6936eeceba2ebd928b71b74 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 21 08:32:17 2021 -0700 Automatic changelog generation for PR #61588 [ci skip] commit b2cb5156b60fd1b21d3a322753cb98f3f9b8e0cc Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Tue Sep 21 08:32:13 2021 -0700 Sanitize quirks after being loaded (#61588) Fixes #61468, where quirks being removed/renamed/rebalanced would fuck with your quirk settings. commit 39888a211086b23bc9d518c7e2670cd7fee50389 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 20 17:26:27 2021 -0700 Automatic changelog generation for PR #61552 [ci skip] commit 5c67c53272fd42abdf299455532bf72f62f2b4f5 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Tue Sep 21 02:26:24 2021 +0200 Removes Tactical Resting (#61552) About The Pull Request If you are on combat mode, your bullets will hit people lying down or stunned, otherwise they pass through. Why It's Good For The Game The original PR that added it was labeled a fix (#55495) only mentioning it in the changelog once, when it was a balance change, as resting to avoid bullets was intentionally removed after we added crawling and a rest button, for being fucking stupid. The thing that original pr "fixed" was mobs being bullet sponges, which you can now prevent by switching off combat mode, so it is no longer needed. Avoiding people shooting at you while also having guns of your own you are perfectly able to shoot is stupid. It makes mobs like beepsky super annoying, where unless youre in a large area the robot chasing you with one of the only hardstuns left in the game will be really hard to hit. Changelog cl balance: If you are on Combat Mode, your bullets no longer pass through prone people /cl commit f317230802b239da2270c395b74c90f44a50a5cf Author: Changelogs <action@github.com> Date: Tue Sep 21 00:10:44 2021 +0000 Automatic changelog compile [ci skip] commit 6a6f64119a46805106035e49364b67134aaff045 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 20 16:37:01 2021 -0700 Automatic changelog generation for PR #61516 [ci skip] commit c1d7191ba72a8d2f0acbf9e294d2d9da0f6ab296 Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com> Date: Mon Sep 20 19:36:58 2021 -0400 Fix missing distro pipe on Icebox (#61516) commit 7d429dbf666941e189d24e50648333dc241ee01d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 20 16:35:15 2021 -0700 Automatic changelog generation for PR #61529 [ci skip] commit 9111bb9c8cf18a618245efd10ae61b010d916e99 Author: Zytolg <33048583+Zytolg@users.noreply.github.com> Date: Mon Sep 20 17:35:12 2021 -0600 Icebox Mining Adjustments and Major Fixes (#61529) * Icebox Mining Adjustments This is a small tweak of Icebox Mining geared towards bringing it in line with mapping standards. * Fire Extinguisher I guess I added this while writing the PR * Kills a duplicate railing I missed * Adds layer adapter to pipenet * Airlock Widening You know, you never really appreciate how XL station miners are until you realize that those swole explorers come back with gigantic crates of ore in tow. You can't blame a mapper for forgetting that doorways for mining need to be extra THICC, that's with 3 C's mind you because 1-wide doorways just don't do. Even if they look better. Looks only dictate so much, and while we need to keep worrying about icebox aesthetics (it's really not an aesthetic station, time hasn't done it well) we can't let aesthetics get in the way of design convention. And when your mapwork causes air alarms to go off left right and center, you know you've done something wrong. I want it to be 1-wide, oh I do, but Miners won't like that the firelocks trap them in their icy igloo. Plus, I remapped all this to PREVENT this exact scenario, and I had so much damn fun with it that I almost put it back in. Thank god for excessive review. commit b6580c7304dbb47a5b793a6b07eafa33fc83aa8f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 20 14:39:41 2021 -0700 Automatic changelog generation for PR #61375 [ci skip] commit a2d6c75f312bc6015ad5ec268eb30d7dcd1efdaa Author: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Mon Sep 20 23:39:37 2021 +0200 memories are no longer added if the target isn't aware of them. (#61375) Fixing an oversight with the memories system. Memories shouldn't be added to people who aren't possibly aware of them. commit 57ac5b649ff4fb90de747aa5951aecf6f1ad164d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 20 09:47:24 2021 -0700 Automatic changelog generation for PR #61507 [ci skip] commit e09087398f4bf4c6330ea17a81543b8bd122c5c3 Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Date: Mon Sep 20 17:47:20 2021 +0100 Pushing things by bumping into them now adds fingerprints. (#61507) Bumping into things to push them didn't add fingerprints. This means that it's possible to push things like fuel tanks without any way to track IC or OOC. Now when you bump into a movable atom and it successfully gets moved by you, fingerprints get added the same as if you'd grabbed it and pulled it. commit 37fa4069e21fefb9d5ad90e5a3a1e2648c67e693 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 20 09:46:35 2021 -0700 Automatic changelog generation for PR #61550 [ci skip] commit 394dd217a17b80e36307bce6addcf9e4b08b6cf5 Author: Krysonism <49783092+Krysonism@users.noreply.github.com> Date: Mon Sep 20 18:46:32 2021 +0200 mega arachnid snare fix (#61550) This PR fixes the mega arachnid snare projectile. The trap was never set to armed commit 3ee57fd8f2b060ec6fdd97d3485bf30f99e076c5 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 20 09:35:19 2021 -0700 Automatic changelog generation for PR #61569 [ci skip] commit ebb5a760aeebffa8442c7325203ef075a82f3908 Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Mon Sep 20 18:35:16 2021 +0200 No longer copy underlays and creating a dud object of copied turfs (#61569) I have no idea what the objective behind this code does, but what it does in summary is: -create a dud object -copy underlays onto this dud -apply dud as an underlay This is done so there is an image when it is placed Why this is done i am stumped as all it does is create a copy that will often show over the other tile breaking shuttles and duping lighting underlays Then instead of removing this to fix sometimes it showing for shuttles some shuttle walls got snowflake code to bypass this code commit a08f698230ed6c5b5753f19c02f5c196d8007b37 Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Date: Mon Sep 20 09:17:09 2021 -0700 Harddeletes: Accident edition (#61562) So I started with fixing some timing stuff in #61540, decided to look into foam harddels since I've known about them for a while, got bored, tried to figure out the plane master failures I've seen, and well uh, did. I'm sure there'll be more, but for now: Fixes foam darts sticking around post qdel due to dumb guncode, adds a stack trace to handle it. Makes map popups actually clear the screen they're effecting of their objects, preventing plane master harddels, most commonly sourced from admin pod memes. Not clearing from the screen WAS SOMEHOW AN INTENDED FEATURE!?!@ because "clients log out often anyway and that clears screen so it's fine" I am having a meltdown Changes examine timers from a ref + signal to a ref(), the timer's 1 second, it's not gonna cause any collisions for the love of christ commit d1fd3b524a121f7bce23a78265ff6152560cbb0b Author: Ghilker <42839747+Ghilker@users.noreply.github.com> Date: Mon Sep 20 18:09:10 2021 +0200 _machinery.dm cleanup (#61528) Code cleanup, update to latest contribution guidelines commit 7283dbb15a3c15f9d825541fa187c476a1e7cee5 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 20 08:57:49 2021 -0700 Automatic changelog generation for PR #61418 [ci skip] commit d65566005a8261bcd2d64d12f3a2811e35670c2f Author: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Mon Sep 20 17:57:46 2021 +0200 Fixes stun-harmbatong. (#61418) Title. I have been told the refactor broke stun'n'harm batoning for stunbatons so I'm fixing it. commit 0b27bf0871a1ec99096dbee05b78e712ed82a9f5 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 19:12:31 2021 -0700 Automatic changelog generation for PR #61417 [ci skip] commit 05e7b774d04fe21008a7c395007e3f102585991f Author: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com> Date: Sun Sep 19 22:12:28 2021 -0400 Makes it so certain glasses and headwear can be now displayed above mutant bodyparts and hair (#61417) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 9cd9046d7b8751f003bc8312963dcc643fecf8b9 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 17:45:29 2021 -0700 Automatic changelog generation for PR #61314 [ci skip] commit 7cc177a1e8fda2843b200ea881e1222cf0846765 Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com> Date: Sun Sep 19 21:45:25 2021 -0300 Holofan's new icon (#61314) qol: The atmos holofan barrier has a new animation and is slightly transparent commit 49e737403ed84e6058bd0196f0213b97511f930d Author: Changelogs <action@github.com> Date: Mon Sep 20 00:11:03 2021 +0000 Automatic changelog compile [ci skip] commit 9aa860d295e0167cc7d35117ebe443f1ebe98575 Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Sun Sep 19 17:25:21 2021 -0400 makes xeno organs use organ_trait (#61549) One of them used generic traits while the other one didnt use a define at all, they're both traits given by organs, so they should be organ traits. commit 0b8f8e929c77f97b5906f415e87972553cb3259e Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com> Date: Sun Sep 19 16:52:14 2021 -0400 organize /carbon/emote.dm by alphabet (#61524) commit 1088451f54ebb9edb935f97045a2c24bbce57edf Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 12:54:25 2021 -0700 Automatic changelog generation for PR #61381 [ci skip] commit 464bae0c22fb9b4421a51b4c91b5b6a6af24253f Author: esainane <esainane+github@gmail.com> Date: Mon Sep 20 07:54:22 2021 +1200 tgui: Add new and disambiguate old gas colors (#61381) This PR adds color mappings for new gases, and disambiguates color mappings for old gases where multiple gases used one color - many used red, or purple. Most of these have been around for a while, but were missing color mappings in interfaces. This mainly affects the HFR gas list interface. commit fac93a0d4f447b1675241028497d9b7cd3df7135 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Sun Sep 19 12:24:55 2021 -0700 Change preference cache from addtimer to spawn, ideally preventing the savefile bug from happening pre-init (#61536) The bug #61469 (940d9aa99d1237ca5440ae2bbc276cfbe2276c46) was trying to fix is mostly successful, except in rare cases of a lot of people opening preferences pre-timer SS init, where addtimer is delayed. This changes it to spawn, which is good to run pre-init, though in small amounts. If this doesn't work, then I'm going to make a savefile pass through every proc as an argument, but it's a very tedious and frustrating change to do, and I only really want to do it if necessary. commit eeeebdf05478803ac5d4cfefb738b2cb52858470 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 12:15:51 2021 -0700 Automatic changelog generation for PR #61542 [ci skip] commit cde482bb248def2c16c22e28b915ef9d529d2b04 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Sun Sep 19 12:15:47 2021 -0700 Fix FPS and other preferences not properly applying after reconnect (#61542) Fixes #61515. Preferences were only applied on load_preferences(), which only fires when the preferences datum is created. Preferences datums are cached, and so load_preferences is only called the once. commit cc991d6860acb5abc5ad98cd6823789068b6ce66 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 10:27:09 2021 -0700 Automatic changelog generation for PR #61548 [ci skip] commit a1785d2bd07e020460c87bdc2183b3bc606c3efe Author: manofpepsi <71612753+manofpepsi@users.noreply.github.com> Date: Sun Sep 19 20:27:06 2021 +0300 holographic esword doesnt have blockchance (#61548) fixes the holosword having inherited block chance from its parent after the transforming weapons refactor. commit b0e017b7e5eb544feb322904614c4023e07ca299 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 03:45:04 2021 -0700 Automatic changelog generation for PR #61526 [ci skip] commit 74c6e7bb048a75baf722f91f391415f7a991b9a3 Author: esainane <esainane+github@gmail.com> Date: Sun Sep 19 22:45:01 2021 +1200 HFR: Fix T3 gas production at Fusion Level 2 (#61526) I am once again asking you to observe the /tg/station13 codebase MISSING ANOTHER [MOLES] AAAAAAAAAAA WHAT IS THIS JOKE OF A TYPE SYSTEM commit cc7993500d1aed5ccaa350c658ccf7762846c261 Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com> Date: Sun Sep 19 06:36:42 2021 -0400 Reorganize holidays.dm (#61432) commit 4bb284326362f3adeb0525a06ac0e8e2b00ad166 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 03:35:57 2021 -0700 Automatic changelog generation for PR #61518 [ci skip] commit 7cd0ca96caed6179d8ff71de79ae76fa64827f8a Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Sun Sep 19 03:35:54 2021 -0700 basic critters can now hop in da vim (#61518) commit badafcae90eda621980d1bed64b22681b6eea930 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 03:21:22 2021 -0700 Automatic changelog generation for PR #61530 [ci skip] commit e060c7eedc8769fa061ddac785c99631a07df8ac Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Sun Sep 19 12:21:19 2021 +0200 fix lighting (#61530) commit 2ebe96fee9e5b402f708a7049bf43cf7e1477532 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 03:20:24 2021 -0700 Automatic changelog generation for PR #61541 [ci skip] commit a86e939bd4435965b81ae14665133e8fbc356b10 Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Sun Sep 19 06:20:21 2021 -0400 removes a useless check from organs and fixes maint eyes permanent blindness (#61541) commit 519a15032e307099b9407ba62cef9f92a0805e43 Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Sun Sep 19 12:18:24 2021 +0200 Default Baselighting to white (#61544) commit 4fdaa61596a96b2ae6a1ed95236110ce60fdd748 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 03:17:56 2021 -0700 Automatic changelog generation for PR #61539 [ci skip] commit e8be62061b4f0ca65848124b77ae46dc18889de9 Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Date: Sun Sep 19 11:17:53 2021 +0100 Buffs dragon's explosive resistance towards devastating explosions. Light and heavy explosions unchanged vs dragon. (#61539) Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> commit 383b58bcd37a77f040dd6300f7abc4cad5f1305e Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 03:16:29 2021 -0700 Automatic changelog generation for PR #61538 [ci skip] commit b5fad7387f7f585b73ba0f89e120b5adb4e12f90 Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Date: Sun Sep 19 03:16:26 2021 -0700 Fixes imaginary friends (#61538) commit 6f5ed882b51ec1963ee33784992065ff42557a05 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 03:16:07 2021 -0700 Automatic changelog generation for PR #61534 [ci skip] commit 780afdfa5a3f375a07265e6f122df72e385b1908 Author: carshalash <carshalash@gmail.com> Date: Sun Sep 19 20:16:04 2021 +1000 no more hot arnold palmers (#61534) commit e9d4b9268966e2807b30e8fc0aae5844af3c0c8c Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 03:11:37 2021 -0700 Automatic changelog generation for PR #61543 [ci skip] commit 6c6d8307b8305f23f4ceadb7fed06dd913ba48c8 Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Date: Sun Sep 19 06:11:34 2021 -0400 Ports text emphasis from TGMC (who ported it from Citadel) (#61543) commit e53061ae54d0f4783210ad768bf5fff38e95143a Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Sun Sep 19 01:24:11 2021 -0700 FIXES MASTER BY IMPLEMENTING IDLE_BEHAVIOR ON COWS AND STICKMEN (#61565) commit 50e13616f1ecd02ba48c460917aecc6c58fe74f2 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sun Sep 19 00:21:55 2021 -0700 Automatic changelog generation for PR #61393 [ci skip] commit 21e5cfe8d2c2ef55d16406918d2fe02bb76e011b Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Date: Sun Sep 19 08:21:52 2021 +0100 Adds the interrupt signal to the delay component, reorganises BCI files and circuit code improvements (#61393) Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> commit f2b6fcb253f9cac957a827946b496fcdd0ce0d6f Author: AMonkeyThatCodes <20987591+AMonkeyThatCodes@users.noreply.github.com> Date: Sun Sep 19 08:00:17 2021 +0200 Refactors datum AI idle behaviors into datums (#61455) Co-authored-by: MonkeyThatCodes <monkey> commit 28ba8ee9a089711820df218cdf7b879cdd960ab2 Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Date: Sat Sep 18 22:55:28 2021 -0700 Fixes some mispathed markdown links in the readme/contribution file (#61494) commit 9ba53dff70c685a06e726755e28ea3e2b1bf7af7 Author: DeltaFire <46569814+DeltaFire15@users.noreply.github.com> Date: Sun Sep 19 07:55:11 2021 +0200 Makes copy_research_to slightly better, regarding revealing hidden techs (#61498) commit 1cc4242c0227030c82ce4425fc80cb4f083163d9 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sat Sep 18 17:15:45 2021 -0700 Automatic changelog generation for PR #61521 [ci skip] commit 0c010b93b7d09a9d8ecbb729a675203c49b92c33 Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Date: Sun Sep 19 01:15:41 2021 +0100 BCIs now come with one bci action (#61521) Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> commit e9859030530209ac73fd72b1045d382481e82283 Author: Changelogs <action@github.com> Date: Sun Sep 19 00:11:27 2021 +0000 Automatic changelog compile [ci skip] commit e5c81d25286ac036659dafc921d812d55efdcbeb Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sat Sep 18 14:10:23 2021 -0700 Automatic changelog generation for PR #61527 [ci skip] commit 79f6030ebaaa67762fdc712bfa8b92299d162139 Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Sat Sep 18 14:10:20 2021 -0700 Post Sparring Sect Merge MISTAKE (#61527) I forgot to push one last review, without it there will be like 2 runtimes but no real problem gamewise commit 9e72e7af249c104ca5d69e1cc12efad3fc7a3e71 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sat Sep 18 10:13:20 2021 -0700 Automatic changelog generation for PR #61419 [ci skip] commit d14b6cc849e725437e2a09d7f9377e7d9aabdf0e Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Date: Sat Sep 18 18:13:16 2021 +0100 Radically improves explosion logging. (#61419) Adds some extra vars and logic to explosion code to make powerful logging entries that should help admins narrow down when explosives get misused. Records this new info in the feedback database and bumps the explosion version +1 as a result of this. commit bf0a949ef934f7e9b69ca1bf77a9ddc4699dea07 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sat Sep 18 09:29:59 2021 -0700 Automatic changelog generation for PR #61335 [ci skip] commit cbc6f35f54558c438b92c7557ef450dc426c3b7c Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Date: Sat Sep 18 17:29:55 2021 +0100 Things that love the station may no longer leave the station, even when Dr. Anomaly says they should. (#61335) Bluespace anomalies detonating Move() things. When something is Move()d, none of the logic in forceMove() or doMove() is called, and thus stationloving things can't tell when they've left the z-level (since that's where the logic for it is). There are a number of approaches I could have taken: Refactoring anomalies to use different movement code. Refactoring Movement code to send more signals in various scenarios. Refactoring the stationloving component. I settled on two steps. First, refactoring the component to bring it up to modern code standards. Second, moving the logic for COMSIG_MOVABLE_Z_CHANGED to Moved() so the signal always fires regardless of if Move() or forceMove() or doMove() is used, with an optional var for whether the z-change is communicated to contents. This means the ore box was changed to actually send the signal instead of just returning with no parent call or signal sent. Stationloving ore boxes when? stationloving procs no longer call SIGNAL_HANDLERs directly. Var names are now more descriptive. Things are renamed and documented. At least for the parts of the code I know. Probably some other code cleanups. commit 43a1cb44962cccf49429c06a04804b1729669e17 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Sat Sep 18 09:19:11 2021 -0700 Fix typo in prefs menu documentation (#61519) Feature<number> to FeatureToggle commit c4f3374863f0bee378f752915e3b139fdfb954a5 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sat Sep 18 04:09:56 2021 -0700 Automatic changelog generation for PR #61107 [ci skip] commit 95c87ec3de2c552c1ad4688fa7a73f92ba9877f7 Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Date: Sat Sep 18 12:09:54 2021 +0100 Adds heretic tgui antagonist panel (#61107) Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> commit bdf97a9f24bef083096e662ca0b4b34968940d23 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Sat Sep 18 01:40:20 2021 -0700 Automatic changelog generation for PR #61233 [ci skip] commit 25cfbef9cda60271651bd7bb41aa56c958ec7d58 Author: necromanceranne <40847847+necromanceranne@users.noreply.github.com> Date: Sat Sep 18 18:40:16 2021 +1000 Food decomposition can mold stuff into different items, and not just moldy messes. (#61233) Originally the component only allowed food to decompose into the generic moldy mess. This PR changes the component so that what item the component decomposes something into can be changed per attached object. I've added a few examples; bread types > moldy bread, pizza slice types > moldy pizza slices, dead mice > moldy dead mice (they need a sprite still, I'll get to that later. Kinda catbrained rn.) edit: Makes sure that none of this moldy food touches cytology unnecessarily. Rotten eggs have been added (decomposed eggs), along with rotten boiled eggs. The only way to determine if an egg is good or not requires using a container of water on the egg. If it floats, it's rotten! They also do not produce ants when they decompose, so chickens no longer get eaten alive by swarms of ants for producing all these eggs. fixes #61188 commit 85455b205ced309c0033257a144d9a91c89761f5 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Fri Sep 17 23:36:55 2021 -0700 Automatic changelog generation for PR #61161 [ci skip] commit a5027d2f94ee0bfc1817248c1289e5728984b126 Author: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Sat Sep 18 08:36:52 2021 +0200 Removes the hardcoded material restriction for exporting protolathe designs to autolathes. A new variable is used in its place. (#61161) Title. I have removed the hardcoded iron and glass only restrictions from designs imported to autolathes from R&D and added a new variable autolathe_exportable in its place that restricts designs from getting the AUTOLATHE build type flag if FALSE. Energy bolas, gun part kits, tele shield, enegy bolas and jaws of life currently have said var set FALSE. Currently a draft PR because of a problem I have noticed at the last minute: The MATERIAL_NO_EFFECTS flag has to be replaced with a MATERIAL_EFFECTS one to avoid more snowflake code. EDIT: DO NOT MERGE BEFORE #61166. commit eebb3a841097cc2b6c083360965627f4444a2093 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Fri Sep 17 21:25:50 2021 -0700 Automatic changelog generation for PR #61196 [ci skip] commit 1b8fcac4f57572b9fa13718700154fd53d0745fd Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Date: Sat Sep 18 00:25:46 2021 -0400 N…

See #61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated.

commit c10e1e6 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 20:55:39 2021 -0700 Automatic changelog generation for PR tgstation#61746 [ci skip] commit 9bcc80c Author: 567Turtle <91508746+567Turtle@users.noreply.github.com> Date: Tue Sep 28 22:55:36 2021 -0500 Constructable Filing Cabinets (tgstation#61746) commit 2fd4e1d Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Tue Sep 28 19:12:45 2021 -0700 adds tralezab as a codeowner of datum ais (tgstation#61769) commit f45fb5d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:52:34 2021 -0700 Automatic changelog generation for PR tgstation#61739 [ci skip] commit 8473d44 Author: Zytolg <33048583+Zytolg@users.noreply.github.com> Date: Tue Sep 28 18:52:30 2021 -0600 Ditches the Spare Monkey-Operated Firealarm in Kilostaiton Genetics (tgstation#61739) Co-authored-by: Zytolg <theoriginaldash@gmail,com> commit e135108 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:52:14 2021 -0700 Automatic changelog generation for PR tgstation#61738 [ci skip] commit b626fad Author: Zytolg <33048583+Zytolg@users.noreply.github.com> Date: Tue Sep 28 18:52:10 2021 -0600 Removes Duplicate Disposals Pipe and Glass Table from MetaENG (tgstation#61738) * Removes Duplicate Disposals Pipe and Glass Table from MetaENG * Plumbing and Power too Co-authored-by: Zytolg <theoriginaldash@gmail,com> commit 87cf6e7 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:51:28 2021 -0700 Automatic changelog generation for PR tgstation#61733 [ci skip] commit 6174323 Author: esainane <esainane+github@gmail.com> Date: Wed Sep 29 13:51:25 2021 +1300 Derelict: Remove duplicate APCs (tgstation#61733) Two APCs were fighting for control over `/area/ruin/space/derelict/bridge/access` at (66,80) and (63,61). This removes the APC at (63,61) and the two wires leading up to it. Two APCs were fighting for control over `/area/ruin/space/derelict/hallway/secondary` at (35,23) and (58,24). This removes the APC at (58,24), which is directly over a wire path, so does not require any power cables to be removed. commit a43209f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:51:11 2021 -0700 Automatic changelog generation for PR tgstation#61735 [ci skip] commit 9e40039 Author: Iamgoofball <iamgoofball@gmail.com> Date: Tue Sep 28 17:51:08 2021 -0700 Fixes references to now dead gangs in Families objectives. (tgstation#61735) commit 44c424f Author: Changelogs <action@github.com> Date: Wed Sep 29 00:11:00 2021 +0000 Automatic changelog compile [ci skip] commit 9d200cb Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 17:07:45 2021 -0700 Automatic changelog generation for PR tgstation#61532 [ci skip] commit 65267ba Author: Krysonism <49783092+Krysonism@users.noreply.github.com> Date: Wed Sep 29 02:07:41 2021 +0200 Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. (tgstation#61532) * doggy dog world * space begone * suggestions from review * removes frog related oopsie * indent fix commit 67194ea Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 16:52:16 2021 -0700 Automatic changelog generation for PR tgstation#61722 [ci skip] commit 61c30cc Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com> Date: Wed Sep 29 01:52:12 2021 +0200 ntoscard templates fix (tgstation#61722) commit 378da49 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 16:47:47 2021 -0700 Automatic changelog generation for PR tgstation#61730 [ci skip] commit 81989f0 Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Wed Sep 29 01:47:44 2021 +0200 Fix baselighting not respecting changeturfs (tgstation#61730) commit 1846c2d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 15:03:30 2021 -0700 Automatic changelog generation for PR tgstation#61716 [ci skip] commit e330485 Author: Thunder12345 <Thunder12345@users.noreply.github.com> Date: Tue Sep 28 23:03:27 2021 +0100 Replaces CTF hardsuits with new armoured vests (tgstation#61716) Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk> commit 84c7b68 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 14:21:30 2021 -0700 Automatic changelog generation for PR tgstation#61736 [ci skip] commit 643645b Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com> Date: Tue Sep 28 18:21:27 2021 -0300 Makes colo cup sprites actually consistent, and a small edit to a joke. (tgstation#61736) * Update drinks.dm * adds actual colo cups sprites lol im dumb * fixes a small sprite error commit c1fd222 Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Tue Sep 28 17:16:09 2021 -0400 dehardcodes limb icons (tgstation#61570) This is a small change aimed at helping downstream modularity. Currently the file these sprites use are hardcoded with a define, this removes that and instead moves it to a var. I guess the thing is defaults should be overridable, it's just we've never ran into a case where it's needed, so adding that functionality on its own looks really weird annoying. I don't like adding stuff that's only useful to downstreams, for various reasons, but this seems ok after some thought. fulfills the promise of _DEFAULT. -Lemon commit eec8463 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 12:45:42 2021 -0700 Automatic changelog generation for PR tgstation#61694 [ci skip] commit 496a768 Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com> Date: Tue Sep 28 15:45:38 2021 -0400 [MDB Ignore] Make shuttle windows deconstructable (tgstation#61694) * shuttle windows * refactor reinf windows plasma and shuttle only * messed up one change * i am actually blind * made and did file commit a66ef31 Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Tue Sep 28 14:15:11 2021 -0500 Corrects mapload args that sprug up in the past few days (tgstation#61759) See tgstation#61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated. commit 4fc5897 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 11:56:21 2021 -0700 Automatic changelog generation for PR tgstation#61725 [ci skip] commit 43a2b90 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Tue Sep 28 20:56:17 2021 +0200 renames enable debug verbs to enable mapping verbs (tgstation#61725) its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs commit 4413bbc Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 08:00:07 2021 -0700 Automatic changelog generation for PR tgstation#61724 [ci skip] commit a23b275 Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Tue Sep 28 08:00:01 2021 -0700 Fixes check AI laws collapsing, making them unreadable (tgstation#61724) Previously, this would be putting (x2) next to the first 3 laws, and it would look like the 2nd cyborg had no laws. commit a62262f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 07:58:50 2021 -0700 Automatic changelog generation for PR tgstation#61723 [ci skip] commit 4eee6a1 Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Date: Tue Sep 28 15:58:47 2021 +0100 Fixes contractor drop pods not being clickable due to suspected BYOND issue. (tgstation#61723) Fixes tgstation#61695 When breaking the entire problem down, I identified the point in time at which the pod stopped being clickable Spawning in pods manually and running their various procs couldn't replicate the issue. As a result, I eliminated pod code as the root cause and focused on the pod_landingzone that control them. I considered the debris as a possible cause following: tgstation#61695 However, removing the debris actually removed ALL clickable area for the pods. The debris overlap was the only part that let me click on the pods. So then I set to hacking away at any animation code. At one point I removed both the animates animate(pod.get_filter("motionblur"), y = 0, time = pod.delays[POD_FALLING], flags = ANIMATION_PARALLEL) animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING, flags = ANIMATION_PARALLEL) //Make the pod fall! At an angle! from /obj/effect/pod_landingzone/proc/beginLaunch and the problem still persisted. When I removed pod.add_filter("motionblur",1,list("type"="motion_blur", "x"=0, "y"=3)) after this (the effect was permanently on the pod which made it pretty obvious as a possible cause) the problem vanished entirely. Without the motion blur filter applied, pods now function properly. As a result, I believe this is a BYOND issue. Someone with more brains than me can probably work out a test case. Until someone with more brains than me comes along to fix it, removing the motion blur filter is my solution. commit 1859df5 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 07:55:59 2021 -0700 Automatic changelog generation for PR tgstation#61229 [ci skip] commit 29c49fd Author: dragomagol <66640614+dragomagol@users.noreply.github.com> Date: Tue Sep 28 07:55:55 2021 -0700 Ports animated locker doors (tgstation#61229) ## About The Pull Request Ports locker door animations from Yogstation! yogstation13/Yogstation#9706 Skyrat-SS13/Skyrat-tg#6767 ## Why It's Good For The Game The locker opening animation is really nice, it's a shame we don't have it yet. commit 6189b88 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 02:08:57 2021 -0700 Automatic changelog generation for PR tgstation#61692 [ci skip] commit df1260f Author: CRITAWAKETS <sebastienracicot@hotmail.com> Date: Tue Sep 28 05:08:53 2021 -0400 Fixes the auxiliary base construction console. (tgstation#61692) commit c254707 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 02:05:30 2021 -0700 Automatic changelog generation for PR tgstation#61698 [ci skip] commit 6317b7b Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Tue Sep 28 11:05:27 2021 +0200 Fix connect loc not respecting phasing in some cases when it should (tgstation#61698) commit 26df314 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Tue Sep 28 00:01:11 2021 -0700 Automatic changelog generation for PR tgstation#60920 [ci skip] commit ff41f8a Author: twilightwanderer <88540658+twilightwanderer@users.noreply.github.com> Date: Tue Sep 28 10:01:07 2021 +0300 Fixing the chat client (tgstation#60920) Corrects the chat restriction on using ASII characters only. (This PR was created for Skyrat-TG, but the collaborator of that repository asked me to adapt this PR for tgstation.) This will fix tgstation#54598 In the original code, the chat client uses only ASII standard characters, which is very limited in its capabilities. For example, does not allow you to use specialized characters, which would have taken the atmosphere of the old messengers, as well as regional characters. The lack of regional characters complicates the game for non-English-speaking servers. For example, the Russian-speaking player community Space Station 13 The Fluffy Frontier uses the original Skyrat-tg build. And the players of this community almost do not use the chat client to communicate due to the fact that they can not use Cyrillic characters. commit 3b275f8 Author: Sheits <81964183+Sheits@users.noreply.github.com> Date: Tue Sep 28 16:57:52 2021 +1000 Creates fly.ts for the new tgui prefs menu (tgstation#61728) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> commit 32518f6 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 22:52:08 2021 -0700 Automatic changelog generation for PR tgstation#61715 [ci skip] commit 76c6754 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Tue Sep 28 07:52:05 2021 +0200 secret recipes are now actually secret (tgstation#61715) commit 67e7261 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 20:38:52 2021 -0700 Automatic changelog generation for PR tgstation#61714 [ci skip] commit 1f000ba Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Mon Sep 27 20:38:49 2021 -0700 Fix word bounds on filters, where they would only be applied at the beginning (tgstation#61714) commit 563cb1d Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 19:06:06 2021 -0700 Automatic changelog generation for PR tgstation#61607 [ci skip] commit 744679b Author: Zytolg <33048583+Zytolg@users.noreply.github.com> Date: Mon Sep 27 20:06:02 2021 -0600 Adds brand new ruins to the Icebox Ruins roster. (tgstation#61607) commit 69fc80f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 17:52:00 2021 -0700 Automatic changelog generation for PR tgstation#61680 [ci skip] commit dbfa6c0 Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com> Date: Tue Sep 28 01:51:57 2021 +0100 Fix Genturf on Icebox (tgstation#61680) commit a19f273 Author: Changelogs <action@github.com> Date: Tue Sep 28 00:11:28 2021 +0000 Automatic changelog compile [ci skip] commit c277a6f Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 17:08:07 2021 -0700 Automatic changelog generation for PR tgstation#61621 [ci skip] commit 3c5d622 Author: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Tue Sep 28 02:08:03 2021 +0200 You can now use backslashes as an escape character for text modification. (tgstation#61621) commit eac67c9 Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 17:04:30 2021 -0700 Automatic changelog generation for PR tgstation#61719 [ci skip] commit 74be623 Author: Fikou <23585223+Fikou@users.noreply.github.com> Date: Tue Sep 28 02:04:27 2021 +0200 Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits (tgstation#61719) commit ca4524e Author: tgstation-server <tgstation-server@tgstation13.org> Date: Mon Sep 27 16:35:18 2021 -0700 Automatic changelog generation for PR tgstation#61726 [ci skip] commit d9ede13 Author: tralezab <40974010+tralezab@users.noreply.github.com> Date: Mon Sep 27 16:35:15 2021 -0700 if you give a monkey an instrument, it will begin playing the donkey kong theme (tgstation#61726)

…tation#815) * every case of initialize that should have mapload, does (tgstation#61623) ## About The Pull Request stop forgetting to include mapload, if you don't include it then every single subtype past it by default doesn't include it for example, `obj/item` didn't include mapload so every single item by default didn't fill in mapload ![](https://media.discordapp.net/attachments/823293417186000909/875122648605147146/image0.gif) ## Regex used: procs without args, not even regex `/Initialize()` procs with args `\/Initialize\((?!mapload)((.)*\w)?` cleanup of things i didn't want to mapload: `\/datum\/(.)*\/Initialize\(mapload` * every case of initialize that should have mapload, does Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>

…station#872) * Corrects mapload args that sprug up in the past few days (tgstation#61759) See tgstation#61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated. * Corrects mapload args that sprug up in the past few days Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>

…`) (#72846) ## About The Pull Request Adds a grep for atom initialize overrides which does not include mapload Regex used `^/(obj|mob|turf|area|atom)/.+/Initialize\((?!mapload).*\)` Also replaced some space indentation with some tab indentation in some other greps ![image](https://user-images.githubusercontent.com/51863163/213883049-ef6d953a-e11f-4876-9852-c09633ddc289.png) ## Why It's Good For The Game See #69107, #61759, #61623 ## Changelog No player facing changes

tralezab added 3 commits September 21, 2021 10:56

carry the mapload, solve for var/x

1d1f71c

cleanup (with more regex!!)

4234243

more cleanup

9715f23

tralezab requested review from Cyberboss, ExcessiveUseOfCobblestone, LemonInTheDark, Mothblocks, ninjanomnom and Watermelon914 as code owners September 21, 2021 19:12

tgstation-server added the GitHub Remember that time they had to get us to send them a copy of the repo label Sep 21, 2021

decomposition 😡

19d475a

Cyberboss requested changes Sep 21, 2021

View reviewed changes

code/datums/components/food/decomposition.dm Outdated Show resolved Hide resolved

github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Sep 22, 2021

Merge branch 'master' of https://github.com/tgstation/tgstation into …

bbbe8ae

…var-args-mapload

tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Sep 24, 2021

Cyberboss merged commit 6c01cc2 into tgstation:master Sep 24, 2021

SkyratBot mentioned this pull request Sep 24, 2021

[MIRROR] every case of initialize that should have mapload, does Skyrat-SS13/Skyrat-tg#8374

Merged

ms-mirror-bot mentioned this pull request Sep 24, 2021

[MIRROR] every case of initialize that should have mapload, does Mojave-Sun/mojave-sun-13#815

Merged

This was referenced Sep 28, 2021

Refactor rolling paper to use customizable reagent holder #61758

Merged

Corrects mapload args that sprug up in the past few days #61759

Merged

Cyberboss pushed a commit that referenced this pull request Sep 28, 2021

Corrects mapload args that sprug up in the past few days (#61759)

a66ef31

See #61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated.

ike709 mentioned this pull request Feb 12, 2022

Adds mapload to every Initialize() and fixes gasses being invisible BeeStation/BeeStation-Hornet#6361

Merged

SinguloBot mentioned this pull request Feb 12, 2022

[MIRROR] Adds mapload to every Initialize() and fixes gasses being invisible SinguloStation13/SinguloStation-Blue#362

Open

AustationBot mentioned this pull request Feb 12, 2022

[MIRROR] Adds mapload to every Initialize() and fixes gasses being invisible austation/austation#4770

Merged

SinguloBot mentioned this pull request Feb 12, 2022

[MIRROR] Adds mapload to every Initialize() and fixes gasses being invisible SinguloStation13/SinguloStation-Red#780

Open

SandPoot mentioned this pull request Apr 6, 2022

Every case of initialize that should have mapload, does Citadel-Station-13/Citadel-Station-13#15585

Merged

MrMelbert mentioned this pull request Aug 10, 2022

Fixes 118(give or take) cases of mapload not being passed to initilaize #69107

Merged

Tsar-Salat mentioned this pull request Dec 16, 2022

Ports /tg/ transit_tubes BeeStation/BeeStation-Hornet#8218

Closed

MrMelbert mentioned this pull request Jan 20, 2023

Adds checkgrep for improper or missing atom Initialize args (mapload) #72846

Merged

Gboster-0 mentioned this pull request Dec 1, 2023

The grand emotening part 1 vlggms/lobotomy-corp13#1670

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

every case of initialize that should have mapload, does #61623

every case of initialize that should have mapload, does #61623

tralezab commented Sep 21, 2021

tralezab commented Sep 21, 2021

every case of initialize that should have mapload, does #61623

every case of initialize that should have mapload, does #61623

Conversation

tralezab commented Sep 21, 2021

About The Pull Request

Regex used:

Why It's Good For The Game

Changelog

tralezab commented Sep 21, 2021