Skip to content

fix/projjson clarifications #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix/projjson clarifications #44

wants to merge 3 commits into from
+32 −17

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Oct 1, 2025

  • add required version field
  • add clarifying text and update schemas

d-v-b
d-v-b commented Oct 1, 2025
View reviewed changes
attributes/geo/proj/README.md Outdated
Comment on lines 54 to 55
Unless otherwise stated, a key set to the value `null` is semantically equivalent to
that key being omitted from the object that contains it.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this clarifies that unset keys are the same as keys set to null

d-v-b
d-v-b commented Oct 1, 2025
View reviewed changes
attributes/geo/proj/README.md Outdated
PROJJSON CRS representation

* **Type**: `any`
* **Type**: `[projjson, null]`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelmathot I think these fields might have been auto-generated by the JSON schema? If so, how can I replicate that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No they are not for now. Keep it this way. Thx

@d-v-b d-v-b marked this pull request as ready for review October 2, 2025 13:51
@d-v-b d-v-b requested a review from emmanuelmathot October 2, 2025 13:51
@emmanuelmathot emmanuelmathot mentioned this pull request Oct 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelmathot emmanuelmathot emmanuelmathot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-v-b @emmanuelmathot