This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
created unit test cases for 353(DAWN-472) for ram_limit, weighted cpu… #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Apr 17, 2018
| produce_blocks(1); | ||
| set_code(N(f_tests), code.c_str()); | ||
| produce_blocks(10); | ||
|
|
There was a problem hiding this comment.
This test seems to take more time than needed. Do you need 10 blocks here? Also the loop below to 10, seems like fewer iterations could achieve the same test.
|
Hi I've created another pull request to make the test case run faster. |
heifner
approved these changes
Apr 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created test cases for ram_limit, weighted_cpu_limit, weighted_net_limit for #353