Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections to se_sponge_del4 namelist variables definitions #690

Closed
fvitt opened this issue Nov 9, 2022 · 1 comment
Closed

Corrections to se_sponge_del4 namelist variables definitions #690

fvitt opened this issue Nov 9, 2022 · 1 comment
Assignees
@jtruesdal
Labels
bug Something isn't working correctly CoupledEval3

Comments

@fvitt
Copy link

fvitt commented Nov 9, 2022

Issue Type

Other (please describe below)

Issue Description

Namelist variable se_sponge_del4_nu_div_fac needs to be a real, while se_sponge_del4_lev needs to be an integer.

The corrections to namelist_definition.xml are as follows:

diff --git a/bld/namelist_files/namelist_definition.xml b/bld/namelist_files/namelist_definition.xml
index d371f975..516f973d 100644
--- a/bld/namelist_files/namelist_definition.xml
+++ b/bld/namelist_files/namelist_definition.xml
@@ -7626,7 +7626,7 @@ If < 0, se_sponge_del4_nu_fac is automatically set based on model top locatio
 Default: Set by build-namelist.
 </entry>
 
-<entry id="se_sponge_del4_nu_div_fac" type="integer" category="se"
+<entry id="se_sponge_del4_nu_div_fac" type="real" category="se"
        group="dyn_se_inparm" valid_values="" >
 Divergence damping hyperviscosity coefficient se_nu_div [m^4/s] for u,v is increased to
 se_nu_p*se_sponge_del4_nu_div_fac following a hyperbolic tangent function
@@ -7640,7 +7640,7 @@ If &lt; 0, se_sponge_del4_nu_div_fac is automatically set based on model top loc
 Default: Set by build-namelist.
 </entry>
 
-<entry id="se_sponge_del4_lev" type="real" category="se"
+<entry id="se_sponge_del4_lev" type="integer" category="se"
        group="dyn_se_inparm" valid_values="" >
 Level index around which increased del4 damping is centered.

Will this change answers?

I Don't Know

Will you be implementing this yourself?

Yes
@fvitt fvitt added the bug Something isn't working correctly label Nov 9, 2022
@PeterHjortLauritzen
Copy link
Collaborator

@fvitt Thanks for finding this bug. I don't think it will change answers since namelist_defaults_cam.xml has "-1" for all configurations meaning that the code internally will set the value.

fvitt added a commit to fvitt/CAM that referenced this issue Jan 31, 2023
@fvitt
fix issue ESCOMP#690
514772f 
        modified:   bld/namelist_files/namelist_definition.xml
@fvitt fvitt mentioned this issue Jan 31, 2023
Merged
@nusbaume nusbaume assigned jtruesdal and unassigned fvitt Sep 18, 2023
PeterHjortLauritzen added a commit to jtruesdal/CAM-1 that referenced this issue Sep 22, 2023
@PeterHjortLauritzen
fix issue ESCOMP#690
c7b9a2c
@PeterHjortLauritzen PeterHjortLauritzen mentioned this issue Sep 22, 2023
Merged
jtruesdal added a commit that referenced this issue Oct 6, 2023
@jtruesdal
Merge pull request #887 from jtruesdal/waccmxfv_thermo_fix
8cd44c5 
WACCMX-FV bug fix:convert wet species to dry before calling cam_thermo_dry_air_update
This PR corrects a bug introduced in cam6_3_109. Physics requires constituents mixing ratios to be dry but was using constituent thermodynamic properties based on the wet mixing ratio returned by dynamics. To fix this bug, the routine called to convert mixing ratios from wet to dry was moved further up in d_p_coupling so that it is called before the thermodynamic properties are calculated for physics.

An additional fix to close issue #690 was added to correct namelist default types which are used to control the effect of the SE sponge layer. se_sponge_del4_nu_div_fac has been redefined from and integer to a real type as it controls real valued coefficient. se_sponge_del4_lev was defined as a real but identifies a specific integer model level and has been redefined from a real to integer type.

closes #885
closes #690
closes #893
@nusbaume nusbaume closed this as completed Oct 6, 2023
gold2718 pushed a commit to gold2718/CAM that referenced this issue May 2, 2024
@jtruesdal
ESCOMP tag: cam6_3_130
0109903 
Merge pull request ESCOMP#887 from jtruesdal/waccmxfv_thermo_fix

WACCMX-FV bug fix:convert wet species to dry before calling cam_thermo_dry_air_update
This PR corrects a bug introduced in cam6_3_109. Physics requires constituents mixing ratios to be dry but was using constituent thermodynamic properties based on the wet mixing ratio returned by dynamics. To fix this bug, the routine called to convert mixing ratios from wet to dry was moved further up in d_p_coupling so that it is called before the thermodynamic properties are calculated for physics.

An additional fix to close issue ESCOMP#690 was added to correct namelist default types which are used to control the effect of the SE sponge layer. se_sponge_del4_nu_div_fac has been redefined from and integer to a real type as it controls real valued coefficient. se_sponge_del4_lev was defined as a real but identifies a specific integer model level and has been redefined from a real to integer type.

closes ESCOMP#885
closes ESCOMP#690
closes ESCOMP#893

ESCOMP commit: 8cd44c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtruesdal jtruesdal

Labels
bug Something isn't working correctly CoupledEval3
Projects
CAM Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@PeterHjortLauritzen @jtruesdal @fvitt @cacraigucar @nusbaume