Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to archive derecho baselines #893

Closed
cacraigucar opened this issue Oct 4, 2023 · 0 comments
Closed

Add ability to archive derecho baselines #893

cacraigucar opened this issue Oct 4, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@cacraigucar
Copy link
Collaborator

What is the feature/what would you like to discuss?

Baselines generated on derecho need to be stored via archive_baseline.sh

Is there anyone in particular you want to be part of this conversation?

No response

Will this change (regression test) answers?

No

Will you be implementing this enhancement yourself?

Yes

@cacraigucar cacraigucar added the enhancement New feature or request label Oct 4, 2023
@cacraigucar cacraigucar self-assigned this Oct 4, 2023
jtruesdal added a commit to jtruesdal/CAM-1 that referenced this issue Oct 6, 2023
jtruesdal added a commit that referenced this issue Oct 6, 2023
WACCMX-FV bug fix:convert wet species to dry before calling cam_thermo_dry_air_update
This PR corrects a bug introduced in cam6_3_109. Physics requires constituents mixing ratios to be dry but was using constituent thermodynamic properties based on the wet mixing ratio returned by dynamics. To fix this bug, the routine called to convert mixing ratios from wet to dry was moved further up in d_p_coupling so that it is called before the thermodynamic properties are calculated for physics.

An additional fix to close issue #690 was added to correct namelist default types which are used to control the effect of the SE sponge layer. se_sponge_del4_nu_div_fac has been redefined from and integer to a real type as it controls real valued coefficient. se_sponge_del4_lev was defined as a real but identifies a specific integer model level and has been redefined from a real to integer type.

closes #885
closes #690
closes #893
@nusbaume nusbaume closed this as completed Oct 6, 2023
gold2718 pushed a commit to gold2718/CAM that referenced this issue May 2, 2024
Merge pull request ESCOMP#887 from jtruesdal/waccmxfv_thermo_fix

WACCMX-FV bug fix:convert wet species to dry before calling cam_thermo_dry_air_update
This PR corrects a bug introduced in cam6_3_109. Physics requires constituents mixing ratios to be dry but was using constituent thermodynamic properties based on the wet mixing ratio returned by dynamics. To fix this bug, the routine called to convert mixing ratios from wet to dry was moved further up in d_p_coupling so that it is called before the thermodynamic properties are calculated for physics.

An additional fix to close issue ESCOMP#690 was added to correct namelist default types which are used to control the effect of the SE sponge layer. se_sponge_del4_nu_div_fac has been redefined from and integer to a real type as it controls real valued coefficient. se_sponge_del4_lev was defined as a real but identifies a specific integer model level and has been redefined from a real to integer type.

closes ESCOMP#885
closes ESCOMP#690
closes ESCOMP#893

ESCOMP commit: 8cd44c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants