-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_3_151: "Science optimize" SE-CSLAM dycore and stabilize WACCM #968
cam6_3_151: "Science optimize" SE-CSLAM dycore and stabilize WACCM #968
Conversation
unused pg4 topo files
ZM clean up in preparation for using via CCPP and remove zmconv_microp feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I did have some small suggestions and a few questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some initial comments
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I have a few more questions
else | ||
allocate(kvm_sponge(1)) | ||
kvm_sponge(1) = 0.0_r8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need to allocate for low top model were it is not doing anything?
|
||
if (masterproc) then | ||
write(iulog,*)'Initializing vertical diffusion (vertical_diffusion_init)' | ||
if (allocated(kvm_sponge(:))) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If kvm_sponge
is always allocated then this check is not needed.
do k=1,size(kvm_sponge(:),1) | ||
kvm(:ncol,1) = kvm(:ncol,1)+kvm_sponge(k) | ||
end do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If kvm_sponge
is allocated only for higher top models (MT and higher) then a check for allocated is needed here.
@fvitt Sorry, I understand your concern now! The variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. Thanks.
waccm_phys="1" is true for WACCM-x
Merge pull request ESCOMP#968 from PeterHjortLauritzen/cam-opt
Merge pull request ESCOMP#968 from PeterHjortLauritzen/cam-opt cam6_3_152: "Science optimize" SE-CSLAM dycore and stabilize WACCM ESCOMP commit: 39b31b4
Increase computational throughput of the SE-CSLAM dynamical core by:
etc. every vertical remapping time-step with CSLAM values (interpolated from physics grid to GLL grid)
Provide stable configuration for WACCM with spectral-elements (ne30pg3 and ne16pg3): namelist changes
Resolve #864 (qneg issue)
Resolve #552 (read in topo file on GLL grid if available)
Resolve #951 (remove namelist defaults for pg4 grids)
Resolve #970 (Remove deprecated 'imp' module)