Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default turn off resolution checking in CTSM #871

Closed
ekluzek opened this issue Dec 17, 2019 · 6 comments · Fixed by #883
Closed

By default turn off resolution checking in CTSM #871

ekluzek opened this issue Dec 17, 2019 · 6 comments · Fixed by #883
Assignees
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability
Milestone

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 17, 2019

The CTSM build-namelist by default turns on the option "-chk_res" which then checks that the input resolution is a valid one that CTSM knows about. This is set in the namelist_defaults_overall.xml file. Since, it's now more common to run at unsupported resolutions, we want to make this default off. The user could still turn it on if they want to. This also leaves in the place the supported resolution list that we find useful for running the CTSM inputfile tool chain. That toolchain already has a way to run an unsupported resolution, so the list of supported resolutions is still useful in that context. If someone provides an unsupported resolution, the namelist will still fail when it doesn't find the needed input surface dataset.

@barlage @negin513

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability tag: simple bfb labels Dec 17, 2019
@ekluzek ekluzek self-assigned this Dec 17, 2019
@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 17, 2019

This was something requested by the variable mesh group. It was something that I thought we should fix for sometime (and thought we had an issue for it), but I was thinking the solution was to change the valid resolution list to reading the list of grids in cime config_grids.xml. Doing that would be a bigger project. This solution is so simple that we can take advantage of it right away.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 17, 2019

Here's the code diff to do this...

diff --git a/bld/namelist_files/namelist_defaults_overall.xml b/bld/namelist_files/namelist_defaults_overall.xml
index f7f2d041..042a973b 100644
--- a/bld/namelist_files/namelist_defaults_overall.xml
+++ b/bld/namelist_files/namelist_defaults_overall.xml
@@ -43,8 +43,7 @@ determine default values for namelists.
 <sim_year_range>constant</sim_year_range>
 
 <!-- Check resolution and land/mask before continuing -->
-<chk_res mode="clm_stndln" >1</chk_res>
-<chk_res mode="ext_cesm"   >0</chk_res>
+<chk_res >0</chk_res>
 
 <!-- Add note to namelist files documenting the options given to build-namelist -->
 <note mode="clm_stndln" >1</note>

(NOTE: the above "mode" attribute is a holdover from CLM3.5 when CLM had it's own "standalone" mode. That attribute is no longer used. Note, also that it was setup to only check
resolution when the CLM standalone mode was used, not for CESM. So it's a bug that crept in
when CESM became the standard way of running the model.)

To turn if off based on XML variables in current versions, you can add this to a given case...

./xmlchange --append CLM_BLDNML_OPTS="-no-chk_res"

@ekluzek ekluzek added the branch tag: release Changes go on release branch as well as master label Jan 15, 2020
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jan 15, 2020

There are some grids defined in the release branch, that aren't in our resolution list. So this change should go on the release branch as well.

@ekluzek ekluzek added this to the cesm2.1.2 milestone Jan 15, 2020
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jan 16, 2020
@patcal
Copy link

patcal commented Feb 7, 2020

Erik,
I verified that adding ./xmlchange --append CLM_BLDNML_OPTS="-no-chk_res" to the shell_commands file solves this problem for adding VRM grids.

@billsacks
Copy link
Member

@ekluzek did this make it onto the release branch? @mvertens was wondering about it.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 6, 2020

Yes, it's on the release branch.

@ekluzek ekluzek removed the branch tag: release Changes go on release branch as well as master label Mar 23, 2020
fritzt pushed a commit to CESM-GC/CTSM that referenced this issue May 19, 2021
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants