Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make surface dataset and landuse dataset consistent for singlept script #935

Closed
swensosc opened this issue Feb 24, 2020 · 3 comments · Fixed by #1461
Closed

Make surface dataset and landuse dataset consistent for singlept script #935

swensosc opened this issue Feb 24, 2020 · 3 comments · Fixed by #1461
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix tag: support tools only Only modifies offline support tools (example in tools/contrib) so less testing required type: enhancement new capability or improved behavior of existing capability
Projects
NEON-NCAR collaboration Single point

Comments

@swensosc
Copy link
Contributor

In the tool/contrib/singlept script, the user can specify a few changes to the surface data file that may be more appropriate for a site, e.g.
overwrite_single_pft = True
dominant_pft = 7 #BETr
zero_nonveg_pfts = True
uniform_snowpack = True
no_saturation_excess = True

However, these modifications are not performed for the landuse file, and where appropriate should also be made in order to keep the files consistent. An additional issue is that the 'zero_nonveg_pfts' variable should probably be renamed 'zero_nonveg_landunits'
@ekluzek ekluzek added tag: next this issue should get some attention in the next week or two tag: support tools only Only modifies offline support tools (example in tools/contrib) so less testing required labels Feb 24, 2020
@billsacks billsacks added type: enhancement new capability or improved behavior of existing capability and removed tag: next this issue should get some attention in the next week or two labels Feb 25, 2020
@ekluzek ekluzek added the branch tag: release Changes go on release branch as well as master label Mar 26, 2020
@ekluzek
Copy link
Contributor

ekluzek commented Apr 7, 2020

OK, I can see what to do here, but will take a bit to make sure it's correct.

ekluzek added a commit to ekluzek/CTSM that referenced this issue Apr 7, 2020
@ekluzek
Change zero_nonveg_pfts to zero_nonveg_landunits according to ESCOMP#935
f4fb1ff
@ekluzek ekluzek mentioned this issue Apr 7, 2020
Merged
@wwieder wwieder moved this from To do to In progress in NEON-NCAR collaboration Apr 6, 2021
@negin513 negin513 mentioned this issue Apr 21, 2021
Closed
3 tasks
fritzt pushed a commit to CESM-GC/CTSM that referenced this issue May 19, 2021
@ekluzek @fritzt
Change zero_nonveg_pfts to zero_nonveg_landunits according to ESCOMP#935
b87ea0e
@wwieder wwieder moved this from In progress to To do in NEON-NCAR collaboration Jun 29, 2021
@wwieder wwieder added this to To do in Single point via automation Nov 16, 2021
@wwieder
Copy link
Contributor

wwieder commented Jan 22, 2022

should be closed (again) with #1606

@wwieder wwieder linked a pull request Jan 22, 2022 that will close this issue
Reorganizing subset_data.py to follow SE recommendations #1461
Merged
@wwieder wwieder moved this from To do to In progress in Single point Jan 22, 2022
@wwieder wwieder moved this from To do to In progress in NEON-NCAR collaboration Jan 22, 2022
@ekluzek ekluzek added closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix and removed branch tag: release Changes go on release branch as well as master labels Feb 2, 2022
@ekluzek
Copy link
Contributor

ekluzek commented Feb 2, 2022

I had put the release label on this, but the release-clm5.0 is old enough now that I'd recommend people use the latest development version of the code rather than this one.

And actually as subset_data now supersedes the contrib/singlept script I'm closing this as a WONTFIX.

@ekluzek ekluzek closed this as completed Feb 2, 2022
NEON-NCAR collaboration automation moved this from In progress to Done Feb 2, 2022
Single point automation moved this from In progress to Done Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix tag: support tools only Only modifies offline support tools (example in tools/contrib) so less testing required type: enhancement new capability or improved behavior of existing capability
Projects
NEON-NCAR collaboration
Status: Done
NEON-NCAR collaboration
Done
Single point
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorganizing subset_data.py to follow SE recommendations negin513/ctsm
4 participants
@billsacks @wwieder @ekluzek @swensosc