-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Compsets, Testlist, and Grid list #173
Update Compsets, Testlist, and Grid list #173
Conversation
To be evaluated in conjunction with ESMCI/ccs_config_cesm#177 |
param_templates/MOM_input.yaml
Outdated
@@ -3623,8 +3344,8 @@ Global: | |||
EFACTOR - Applies an enhancement factor to the KPP..."" | |||
datatype: string | |||
value: | |||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID != "wtx0.66v1" : "EFACTOR" | |||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID == "wtx0.66v1" : "SURFACE_BANDS" | |||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID != "wtx2_3v2" : "EFACTOR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to $WAV_GRID == "ww3a"
param_templates/MOM_input.yaml
Outdated
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID != "wtx0.66v1" : "EFACTOR" | ||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID == "wtx0.66v1" : "SURFACE_BANDS" | ||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID != "wtx2_3v2" : "EFACTOR" | ||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID == "wtx2_3v2" : "SURFACE_BANDS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to $WAV_GRID in ["wtx2_3v2", "wgx3v7"]
param_templates/MOM_input.yaml
Outdated
@@ -3633,28 +3354,28 @@ Global: | |||
INPUT - Testing with fixed values. | |||
datatype: string | |||
value: | |||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID == "wtx0.66v1" : "COUPLER" | |||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID == "wtx2_3v2" : "COUPLER" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to $WAV_GRID in ["wtx2_3v2", "wgx3v7"]
param_templates/MOM_input.yaml
Outdated
STOKES_DDT: | ||
description: | | ||
default = False | ||
Flag to use Stokes d/dt | ||
datatype: string | ||
value: | ||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID == "wtx0.66v1" : True | ||
$COMP_WAV in ["ww3", "ww3dev"] and $WAV_GRID == "wtx2_3v2" : True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to $WAV_GRID in ["wtx2_3v2", "wgx3v7"] here and lines 3371, 3378, 3387, and 3394.
@@ -46,7 +46,6 @@ | |||
<default_value>zstar_65L</default_value> | |||
<values> | |||
<value grid="oi%tx0.25v1">hycom1</value> | |||
<value grid="oi%gx1v6">zstar_60L</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to drop support for the 60 level vertical grid? I think it would be two steps:
- remove
zstar_60L
from thevalid_values
list three lines up - remove all
zstar_60L
occurrences inMOM_input.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gustavo-marques Any reason to keep the 60 level vertical grid option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason. Thanks.
@gustavo-marques, @mnlevy1981, The two commits I've just pushed should address your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
@@ -58,15 +40,15 @@ | |||
<option name="wallclock">01:30:00</option> | |||
</options> | |||
</test> | |||
<test name="SMS" grid="T62_t025" compset="CMOM"> | |||
<test name="SMS" grid="T62_t025" compset="C"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you still supporting the t025 grid in MOM here? Also, still supporting the older CORE forcing?
</machines> | ||
<options> | ||
<option name="wallclock">01:00:00</option> | ||
</options> | ||
</test> | ||
<test name="SMS_Ld2" grid="f09_t232" compset="B1850MOM" testmods="mom/bcompset"> | ||
<test name="SMS_Ld2" grid="f09_t232" compset="B1850" testmods="mom/bcompset"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be ne30pg3 or something?
<machines> | ||
<machine name="derecho" compiler="gnu" category="aux_mom"/> | ||
</machines> | ||
<options> | ||
<option name="wallclock">01:30:00</option> | ||
</options> | ||
</test> | ||
<test name="ERS" grid="TL319_t061_wt061" compset="GMOM_JRA_WD"> | ||
<test name="ERS" grid="TL319_t232_wg37" compset="GW_JRA"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I still test g37 and g17 in the standalone D compsets? (ice only)
Testing: aux_mom.derecho b4b.