correct way to add aws settings #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fischer-ncar
approved these changes
Jul 12, 2022
|
@briandobbins have you had a chance to try this on aws. I need this PR to start the next round of alpha testing. |
|
I have not, but I'll set it up right now and get back to you this
afternoon. Sorry for the delay!
- Brian
…On Thu, Jul 14, 2022 at 11:09 AM fischer-ncar ***@***.***> wrote:
@briandobbins <https://github.com/briandobbins> have you had a chance to
try this on aws. I need this PR to start the next round of alpha testing.
—
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACL2HPINMNMOYN7NKZO6NYDVUBCS3ANCNFSM53ML5EGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This worked fine; you're all set, Chris. Thanks!
- Brian
…On Thu, Jul 14, 2022 at 11:41 AM Brian Dobbins ***@***.***> wrote:
I have not, but I'll set it up right now and get back to you this
afternoon. Sorry for the delay!
- Brian
On Thu, Jul 14, 2022 at 11:09 AM fischer-ncar ***@***.***>
wrote:
> @briandobbins <https://github.com/briandobbins> have you had a chance to
> try this on aws. I need this PR to start the next round of alpha testing.
>
> —
> Reply to this email directly, view it on GitHub
> <#51 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACL2HPINMNMOYN7NKZO6NYDVUBCS3ANCNFSM53ML5EGQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
@briandobbins , can you approve the changes, thanks. |
briandobbins
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously added aws settings were being activated on all systems because mach attribute was
used in the wrong place. We probably need better testing and error checking for this.