only do this check on ncar systems #4228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rljacob
reviewed
Apr 14, 2022
| mach == probed_machine, | ||
| f"Current machine {probed_machine} does not match case machine {mach}.", | ||
| ) | ||
| if "NCAR_HOST" in os.environ: |
There was a problem hiding this comment.
We should not be putting site-specific stuff like this in the CCS.
There was a problem hiding this comment.
I welcome suggestions for alternative solutions.
There was a problem hiding this comment.
I think the more portable way is a machine file setting that marks such a config. But I'm fine with this going in now as is.
There was a problem hiding this comment.
@rljacob I've given some thought to how a field in the machine definition could resolve this issue, but haven't come up with anything, if you have any specific suggestions, I'm interested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check should only be done on systems with a common filesystem but separate login nodes (ncar)
Test suite: Ran SMS.f19_g17.X.cheyenne_intel and tried to run on casper, ran ./create_test SMS.f19_g17.X.cori-knl_intel SMS.f19_g17.X on cori.
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #4226
User interface changes?:
Update gh-pages html (Y/N)?: