Updates config_batch.xml to facilitate queue specific flags #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jedwards4b @jgfouca I've written this fix to be backwards compatible, the normal Are we fine with this behavior or should I remove the |
jedwards4b
approved these changes
Sep 16, 2022
jedwards4b
added a commit
that referenced
this pull request
Oct 17, 2022
if the submit option cannot be resolved do not add the flag Fixes an issue introduced in PR #4307 when $PROJECT isn't defined the project flag should not be used. Test suite: scripts regression tests Test baseline: Test namelist changes: Test status: bit for bit Fixes User interface changes?: Update gh-pages html (Y/N)?:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
config_batch.xmlto facilitate queue specific flags e.g.<argument job_queue="long">-w docker</argument>would onlyapply when the queue name is
long. The behavior ofargumentis now inline with the rest of the XML system, i.e. the argument is
now stored in the XML nodes text not in attributes of the node.
Test suite: scripts_regression_tests.py
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a
Fixes #4120
User interface changes?: n/a
Update gh-pages html (Y/N)?: N