Move _get_time_bounds from preprocessor._time to cmor.check to avoid circular import with cmor module #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bouweandela frenly ping so we can fix the failing tests sooner than later 👍 |
bouweandela
requested changes
Mar 9, 2021
|
Thanks for looking into this @valeriupredoi! |
valeriupredoi
changed the title
bouweandela
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1036
as a thumb rule, we should really not use variable names like
timeas well as we should make a proper__init__.pyfile for thecmormodule - this fix here is not elegant at all but until we de-convolutecmormodule frompreprocessormodue via a good__init__file I can't see another solution