-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CESM2 CMORizer #1678
Added CESM2 CMORizer #1678
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1678 +/- ##
==========================================
+ Coverage 91.47% 91.48% +0.01%
==========================================
Files 206 207 +1
Lines 11204 11218 +14
==========================================
+ Hits 10249 10263 +14
Misses 955 955
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @schlunma, nice to have another model supported! This PR looks fine to me. Reusing shared fixes for native model output significantly reduces the number of code lines. I have a couple of minor suggestions, feel free to have a look. In particular, I would suggest to slightly expand the documentation to clarify which variables are currently supported and maybe how support could be added in the future for other cases.
Thanks for the review @remi-kazeroni! I expanded the doc and addressed all your comments. Let me know if you need anything else! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @schlunma! This looks good to me as it is 👍
fellas @schlunma @remi-kazeroni I am ready to merge this if there are no major objections so I can include it in the 2.7 freezer ☃️ Please yell at me if otherwise, if not I will merge it by the end of day today 👍 |
OK fellas, she's going in 🚢 |
Thanks V! Sorry for the late reply, we had a public holiday yesterday 😄 |
Description
This PR implements a prototype of the on-the-fly CMORizer for the CESM2 model.
Link to documentation: https://esmvaltool--1678.org.readthedocs.build/projects/ESMValCore/en/1678/quickstart/find_data.html#cesm
Depends on #1718
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: