Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on-the-fly cmoriser for ACCESS native data #2430
on-the-fly cmoriser for ACCESS native data #2430
Changes from 60 commits
b774a36
5acf65c
e7277a0
a0a05bc
a32a48f
efcea11
9c0c9b8
f98406d
2b5f8d5
8043643
a86e1d9
c8bc262
f389559
7815a07
6db0088
4018368
0e864b6
200e2d6
803c544
fbfefdc
88047fc
0cd3498
7cd6cf8
7c91b6c
b446f6f
9a0104f
64054ba
b8c6057
869c481
6885d9a
8cc0f3b
c803837
d2d1da3
013d5f0
b116bfc
c371ba0
84fe2ed
6d80f5f
a566cfd
b666121
f7fb9d7
97acf57
645a203
5f587df
f10b23c
fb3ef3f
fdaf89d
857b9d1
1753b8d
b0e1400
7a06b34
7f2ffeb
24ef703
c5c7393
4569cf5
cadd99e
42ec653
7422346
41c6530
c92373d
fe5e4d6
fecb98b
8f744ff
1456249
bd3769e
e160394
573b4f1
f7081ba
b5143bd
08722f0
8e89122
2b93eb3
8743481
e909bf4
21481a3
17789cb
2ee9aa0
320ec83
8ab57f7
66b7d7e
f29e18d
442b2db
7022df1
151642e
2f500ea
5d6d519
4f26996
814ece5
d08ae67
0451b7d
18ceca5
e15236e
dcb13a7
1d3a0cf
bac5051
44af431
1106514
5a837e5
04921ea
9105512
ce60ea0
41aeee0
ef3e7de
b36738d
07519cb
475f4b8
5fd5b64
862d318
70d4258
cb87ce6
155c7cc
71252bd
f429566
d48dac9
043b229
ab151ab
78e9a68
0e97c34
f033eea
0f2ff15
43279b0
bc69800
f750d5a
81be7d3
fdf9f56
18d31cc
7370733
c5acc53
54caba7
987bdd9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is intentional or can be confusing as currently searching for published CMIP6 we use
dataset: ACCESS-ESM1-5
eg:does it make more sense to have
{ institute: ACCESS_ESM, dataset: ACCESS-ESM1-5 }
(switch them)?then change input_dir default above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look resolved to me.
ACCESS-ESM1-5
is not the institute, but rather the name of the model, right? So this probably would be a better fit fordataset
(you can then rename your fix file fromcmor/_fixes/access/access_esm.py
tocmor/_fixes/access/access_esm1_5.py
and possible extend this with more fix files if you want to look at other versions of the model. Then you can get rid ofinstitute
altogether.