Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update externals based on ESCOMP/CESM tag 'cesm2_3_beta17' #68

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Update externals based on ESCOMP/CESM tag 'cesm2_3_beta17' #68

merged 4 commits into from
Aug 23, 2024

Conversation

gdicker1
Copy link
Contributor

This is the first of a series of PRs that will update EarthWorks to more closely match the current development of ESCOMP/CESM.

This PR combines changes to use externals based on those used in the cesm2_3_beta17 tag and to update the cime_config folder with CESM changes.

@gdicker1 gdicker1 added external Has to do with externals EW specific This has to do with EarthWorks only - files, goals, code that probably won't be wanted upstream upstream Related to the upstream repo (ESCOMP/CESM) labels Aug 20, 2024
@gdicker1
Copy link
Contributor Author

gdicker1 commented Aug 20, 2024 •
edited
Loading

Sub PRs:

@gdicker1 gdicker1 self-assigned this Aug 20, 2024
@gdicker1 gdicker1 force-pushed the update/cesm2_3_beta17 branch from c9f2ff7 to e77f058 Compare August 20, 2024 22:32
gdicker1 added a commit to gdicker1/EarthWorks that referenced this pull request Aug 20, 2024
@gdicker1
Merge branch 'update/cesm2_3_beta17' into develop (PR EarthWorksOrg#68)
05c30b4 
Update externals and cime_config based on the ESCOMP/CESM tag 'cesm2_3_beta17'
@gdicker1 gdicker1 marked this pull request as ready for review August 20, 2024 23:56
@gdicker1 gdicker1 mentioned this pull request Aug 21, 2024
Merged
@gdicker1
Change branch for clm external
7563b99 
Since there was problems with the proposed update branch for clm, the
branch has been replaced/regenerated.
@gdicker1
Copy link
Contributor Author

Note this comment above was updated to reflect the changes in 7563b99

(i.e. that the EWOrg/CTSM PR has been replaced)

@gdicker1
Copy link
Contributor Author

After making the updates (to EWOrg/CTSM), I think this PR is ready to be merged.

Testing the ew-pr category against runs of the same test category using the ew2.3.001 tag revealed:

  • QPC6 with nvhpc had NLCOMP and DIFF fails 1
  • CHAOS2000dev with nvhpc, gnu, and intel had NLCOMP and DIFF fails
  • F2000climoEW with nvhpc had NLCOMP and DIFF fails
  • FullyCoupledEW with nvhpc had NLCOMP and DIFF fails
  • FHS94 with nvhpc only had NLCOMP fail
  • FKESSLER with nvhpc only had NLCOMP fail

I think in light of CLUBB namelist changes and development in CTSM (namelist and otherwise) in cesm2_3_beta17, these failures make sense.

Footnotes

  1. NLCOMP fail means some namelist(s) changed between the test and the baseline. DIFF (also BASELINE in output) means that differences appeared when comparing output from the test and baseline. ↩

This was referenced Aug 23, 2024
Merged
Merged
Merged
Merged
Merged
@gdicker1
Finalize the cesm2_3_beta17 update
9d16d13 
Use tags from merged Sub-PRs for EarthWorksOrg externals
@gdicker1 gdicker1 merged commit 1ecf7b7 into EarthWorksOrg:develop Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gdicker1 gdicker1

Labels
EW specific This has to do with EarthWorks only - files, goals, code that probably won't be wanted upstream external Has to do with externals upstream Related to the upstream repo (ESCOMP/CESM)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gdicker1