Remove routine renames from mpas_ocn_okubo_weiss.F90 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2023 13:57
This isn't where it was meant to be, see src/analysis_members
The various qsort references in the module uses have been eliminated as sort is no longer in the used modules.
|
@dazlich, did I explain this correctly? I don't see any reason to not move this through! |
|
That’s a good description. I think it broke when the atm framework changed. I think in the future we will want to consolidate to one framework.
…Sent from my iPhone
On Apr 27, 2023, at 9:30 PM, gdicker1 ***@***.***> wrote:
** Caution: EXTERNAL Sender **
@dazlich<https://github.com/dazlich>, did I explain this correctly? I don't see any reason to not move this through!
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWABI5SNW4HMUHKXBFDXDM2W5ANCNFSM6AAAAAAXOVRF7A>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
dazlich
approved these changes
Apr 28, 2023
sherimickelson
approved these changes
Apr 28, 2023
gdicker1
commented
Apr 28, 2023
There was a problem hiding this comment.
From recent looks at the code, I think we can merge this. There aren't any qsort routines left in the framework that I can find, so these renames aren't doing anything.
(Merge or don't merge have the same functionality, but merging would be cleaner in my opinion.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unneeded renaming of module-specific qsort routines to dummy*. Since those qsort routines aren't used in mpas_ocn_okubo_weiss anymore, they don't need to be renamed.
Also removes a duplicate of mpas_ocn_okubo_weiss.F90