Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Intel OneAPI builds #4

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Conversation

gdicker1
Copy link
Contributor

This fix addresses an Internal Compiler Error that would occur with only the OneAPI compilers in mpas_seaice_core_interface.F90.

This fix addresses an Internal Compiler Error that would occur with only
the OneAPI compilers
@gdicker1 gdicker1 requested a review from dazlich January 29, 2024 23:03
gdicker1 added a commit that referenced this pull request Jan 29, 2024
Copy link
Contributor

@dazlich dazlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this with the fully coupled model at 120, 60, 30 and 15km with ifx - they all pass and I've updated the required runs document.

Looks good, thanks

@dazlich
Copy link
Contributor

dazlich commented Jan 30, 2024

@gdicker1 - There is also a one line change in cime-config/buildlib that got missed for v2.0 that needs to also be committed for intel-oneapi compilation:

diff --git a/cime_config/buildlib b/cime_config/buildlib
index f7f333c..ee61712 100755
--- a/cime_config/buildlib
+++ b/cime_config/buildlib
@@ -113,7 +113,7 @@ def _build_mpassi():
if compiler == 'intel':
fixedflags = '"-UCPRINTEL -free"'
elif compiler == 'intel-oneapi':

  •        fixedflags =  '-free'
    
  •        fixedflags =  '"-UCPRINTEL -free"'
       elif compiler == 'gnu':
           fixedflags =  '-ffree-form'
       elif compiler == 'nvhpc':
    

@gdicker1
Copy link
Contributor Author

@dazlich thanks for the catch! Does c4c33ad fix it for you?

@dazlich
Copy link
Contributor

dazlich commented Jan 30, 2024 via email

@gdicker1 gdicker1 changed the base branch from ew-main to ew-develop February 4, 2024 02:05
@gdicker1 gdicker1 merged commit 7a06b5c into ew-develop Feb 4, 2024
@gdicker1 gdicker1 deleted the fix/oneapi_core_interface branch April 23, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants