Use the FabricClientCommandSource
to replace calls to other methods
#416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407. This PR replaces most occurrences of
MinecraftClient#getInstance
withFabricClientCommandSource#getClient
and replacesClientCommandHelper#sendFeedback
andClientCommandHelper#sendError
withFabricClientCommandSource#sendFeedback
andFabricClientCommandSource#sendError
respectively. Where applicable, access of the player or world through the client instance have been replaced with the according methods ofFabricClientCommandSource
. In some occasions it wasn't possible or wouldn't have been beneficial towards the readability of the code to replace a call toMinecraftClient#getInstance
(for exampleFindItemCommand
andMoteCommand
), so I didn't apply any changes there.