This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Make the width of the version dropdown dynamic and fix doesServerKnow #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaming32
changed the title
|
New issue: items don't get added back to the creative menu ever |
|
This is because CreativeModeTabs.wouldRebuildSameContents only returns false when the feature flags or operator state changes, and the items are only refreshed when this returns false. The fix (which I am about to implement) is to mixin to this method and also add a check for protocol version. |
Also applies to items not getting removed if you joined a newer server first.
|
now heres the solution for the crashing lol |
Earthcomputer
approved these changes
Feb 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, names in extensions can get... longer. This means that sometimes the names overflow the version dropdown's width, which look really bad.