Allow to search by related entities fields #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we can make add columns of an related entity in the "list" actions, there is no way to search by them.
```yml
easy_admin:
entities:
Campaign:
list:
fields:
- property: name
- property: domain.name // <---
```
```yml
easy_admin:
entities:
Campaign:
search:
fields:
- domain.name // <--- throwing error
```
These changes are making that it will now be possible.
What do you think about it?
Fix multiple join
maximecolin
reviewed
Feb 7, 2018
| if (false !== strpos($fieldName, '.')) { | ||
| list($associatedEntityName, $associatedFieldName) = explode('.', $fieldName); | ||
| if (!in_array($associatedEntityName, $entitiesAlreadyJoined)) { | ||
| $queryBuilder->leftJoin('entity.'.$associatedEntityName, $associatedEntityName); |
There was a problem hiding this comment.
Why leftJoin ? If you search on a related entity field, the related entity has to be not null to match the search. A join sound totally appropriate as it will get only the lines where the relation is available and avoid searching against null values in the where clause.
There was a problem hiding this comment.
IMO leftJoin is fine, because rows not related to the joined table can match the search.
There was a problem hiding this comment.
leftJoin allows to search on NULL values in the future
There was a problem hiding this comment.
@yceruto Indeed, I didn't think about this use case.
|
@ktrzos @maximecolin this feature is finally merged! Thanks a lot for your work and reviews. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 10, 2018
…imecolin, javiereguiluz) This PR was merged into the 1.17.x-dev branch. Discussion ---------- Allow to search by related entities fields This finishes #1991. Commits ------- 7ed99c6 Added docs for the new feature 851fce9 Added tests for the new feature f136e6f Fix tests 6248c60 Fixed tests 6f201dd Fixes db3b4b4 Code syntax fixes and tweaks b60b986 Merge pull request #1 from maximecolin/patch-3 e73afa4 Fix multiple join 984018f Searching by related entities fields
|
works well, great move ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes #1991.