Allow to have empty page titles #5549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiereguiluz I think you're right with the empty string translation in Symfony, as this makes a logical sense. Thank you for the fix! |
|
By the way, the underlying translation issue with empty strings in Symfony has been fixed (symfony/symfony#48833) and it will be available in the next patch releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5545.
The proposed behavior (
null=== use the default title;(empty string)=== don't show any title) fits well with the behavior of the rest of features of this bundle.As @Lustmored said, the only issue is that you'll see a new "missing translation" for the empty string:
I think someone could send a PR to Symfony to "fix" this and to simply output an empty string when "translating" an empty string.