Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Url Fix for linking from Edit/Detail to Index pages. #6252

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Admin Url Fix for linking from Edit/Detail to Index pages. #6252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc2a959
Admin Url Fix for linking from Edit/Detail to Index pages.
nopenopenope Apr 10, 2024
990cd64
Apply Linter requirements.
nopenopenope Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Router/AdminUrlGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,11 @@ public function generateUrl(): string
$this->unset(EA::DASHBOARD_CONTROLLER_FQCN);
}

// if the current action is 'index' and an entity ID is defined, remove the entity ID to prevent exceptions automatically
if (Action::INDEX === $this->get(EA::CRUD_ACTION) && null !== $this->get(EA::ENTITY_ID)) {
$this->unset(EA::ENTITY_ID);
}

// this happens when generating URLs from outside EasyAdmin (AdminContext is null) and
// no Dashboard FQCN has been defined explicitly
if (null === $this->dashboardRoute) {
Expand Down