Added option to specify target attribute for link menus #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a very welcome feature the new link menus imo lack the ability to open them in a new tab. This is especially useful for external links where you do not want the user to leave your application.
While opening new tabs is still possible via scroll click, ctrl + click etc this patch makes it possible to make that the default behaviour.
A new
target
property can be set on the link menus which then will be passed on to the generated anchor tag.Possible values:
_blank|_self|_parent|_top|framename
where_blank
is by far the most useful one.@javiereguiluz please tell me how to go about adding tests for this feature.