Allow user override of default API timeouts #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nwithan8
commented
Jan 28, 2022
nwithan8
commented
- Add setters/getters for all three timeouts
- Add test to check that setters/getters operate as expected
- Code rearrangement per file layout rules
|
Gonna wait for the linting task to land so this isn't so large or a PR containing things that aren't related. |
|
@nwithan8 can you rebase and I'll take another look? |
jchen293
reviewed
Jan 29, 2022
jontsai
reviewed
Jan 30, 2022
…imeouts - Add setters/getters for all three timeouts - Add test to check that setters/getters operate as expected - Code rearrangement per file layout rules
Co-authored-by: Justin Hammond <39606064+Justintime50@users.noreply.github.com>
Co-authored-by: Justin Hammond <39606064+Justintime50@users.noreply.github.com>
Justintime50
approved these changes
Feb 1, 2022
jchen293
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.