Improve create list tracker #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve the createList method in the Tracker class
Why?
Currently, our createList method in the Tracker class is doing extra work which refactors the user input. The user is also creating an extra list and map. Overall, this extra work would downgrade the runtime performance which takes O(n) time complexity for createList method, and when the user mistypes "trackers" as the key for input map, a NullPointerException could be thrown.
How?
Instead of asking the user to input a map that must have "trackers" as the key and a list of maps as value, we now just need the user to enter a map of maps where the key is the number of trackers and value is a map of tracking_code and carrier.
Testing?
Modify the unit test to accommodate the code change.