Skip to content

bump to v5.1.1 fix SmartRate response JSON format #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2021
Merged

bump to v5.1.1 fix SmartRate response JSON format #125

merged 2 commits into from
May 19, 2021

Conversation

jontsai
Copy link
Contributor

@jontsai jontsai commented May 18, 2021

No description provided.

@jontsai jontsai requested a review from Roguelazer May 18, 2021 16:17
Justintime50
Justintime50 previously approved these changes May 18, 2021
@jontsai jontsai requested a review from Justintime50 May 18, 2021 16:29
Copy link
Contributor

@Roguelazer Roguelazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing version.py.

@jontsai jontsai requested a review from Roguelazer May 19, 2021 06:23
Copy link

@bgreen-ep bgreen-ep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion of auto-populating version from version.py is non-blocking.

@@ -23,7 +24,7 @@

setup(
name='easypost',
version='5.1.0',
version='5.1.1',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it's too easy for this to get out of sync with version.py. Maybe this should be automatically populated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestions. Perhaps a unit test or something.

An earlier version was trying to to some introspection, but it messed with packaging/setuptools.

@jontsai jontsai requested review from Roguelazer and removed request for Roguelazer May 19, 2021 16:43
@jontsai jontsai merged commit 5c6a9a3 into master May 19, 2021
@jontsai jontsai deleted the v5.1.1 branch May 19, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants