Skip to content

feat: add payment method and refund functions #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 9, 2023
Merged

feat: add payment method and refund functions #249

merged 7 commits into from
Jan 9, 2023

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Dec 14, 2022 •
edited
Loading

Description

  • Adds new billing functionality for ReferralCustomer users
    • add_payment_method can add a pre-existing Stripe bank account or credit card to your EasyPost account
    • refund_by_amount refunds your wallet by a dollar amount
    • refund_by_payment_log refunds you wallet by a PaymentLog ID

Testing

Adds new tests that assert the proper errors since we won't have valid data for any of this.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team December 14, 2022 17:45
jchen293
jchen293 reviewed Dec 14, 2022
View reviewed changes
jchen293
jchen293 previously approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nwithan8
nwithan8 previously approved these changes Dec 15, 2022
View reviewed changes
@Justintime50 Justintime50 marked this pull request as draft December 15, 2022 20:31
@Justintime50
Copy link
Member Author

This is no longer valid since the functionality provided by Stripe is deprecated.

@Justintime50 Justintime50 reopened this Jan 4, 2023
@Justintime50 Justintime50 force-pushed the payment_method_refund branch from 90f2d45 to 4b79eaa Compare January 5, 2023 17:58
@Justintime50 Justintime50 marked this pull request as ready for review January 5, 2023 17:58
nwithan8
nwithan8 suggested changes Jan 5, 2023
View reviewed changes
@Justintime50 Justintime50 requested a review from nwithan8 January 5, 2023 22:02
jchen293
jchen293 previously approved these changes Jan 6, 2023
View reviewed changes
nwithan8
nwithan8 suggested changes Jan 6, 2023
View reviewed changes
@Justintime50 Justintime50 requested a review from nwithan8 January 6, 2023 20:50
@Justintime50 Justintime50 merged commit 6b002bb into master Jan 9, 2023
@Justintime50 Justintime50 deleted the payment_method_refund branch January 9, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@nwithan8 nwithan8 nwithan8 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justintime50 @nwithan8 @jchen293