Skip to content

Improves error deserialization to handle bad format returned from the… #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2023
Merged

Improves error deserialization to handle bad format returned from the… #263

merged 1 commit into from
Apr 7, 2023

Conversation

jchen293
Copy link
Contributor

@jchen293 jchen293 commented Apr 6, 2023

… JSON

Description

Improves error deserialization to handle bad format returned from the JSON response

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team April 6, 2023 18:18
@jchen293 jchen293 force-pushed the improve_error_des branch from 4401a80 to ccd8b22 Compare April 6, 2023 18:32
@jchen293 jchen293 merged commit 5a0d969 into master Apr 7, 2023
@jchen293 jchen293 deleted the improve_error_des branch April 7, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nwithan8 nwithan8 nwithan8 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchen293 @nwithan8