Services1 #274
Merged
Services1 #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwithan8
reviewed
May 12, 2023
nwithan8
approved these changes
May 12, 2023
jchen293
approved these changes
May 15, 2023
| self._client = client | ||
| self._model_class = Batch.__name__ | ||
|
|
||
| def create(self, **params) -> List[Any]: |
There was a problem hiding this comment.
Suggested change
| def create(self, **params) -> List[Any]: | |
| def create(self, **params) -> Batch: |
| """Create a Batch.""" | ||
| return self._create_resource(self._model_class, **params) | ||
|
|
||
| def all(self, **params) -> List[Any]: |
There was a problem hiding this comment.
Suggested change
| def all(self, **params) -> List[Any]: | |
| def all(self, **params) -> List[Batch]: |
| """Update a CarrierAccount.""" | ||
| return self._update_resource(self._model_class, id, **params) | ||
|
|
||
| def delete(self, id): |
There was a problem hiding this comment.
Suggested change
| def delete(self, id): | |
| def delete(self, id) -> None: |
|
@jchen293 thanks Jack! I'll make sure to do a good pass over everything once done to fix type hints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the following services and models:
Updates various base service functions to handle new flows or differing names.
Testing
Updated tests
Pull Request Type
Please select the option(s) that are relevant to this PR.