Service and Model Cleanup #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justintime50
commented
May 16, 2023
| @@ -45,7 +43,7 @@ def get_lowest_object_rate( | |||
| return lowest_rate | |||
|
|
|||
|
|
|||
| def get_lowest_smart_rate(smart_rates, delivery_days: int, delivery_accuracy: str) -> Rate: | |||
There was a problem hiding this comment.
Reviewer Note
These type hints were removed due to circular import issues. Will try and revisit this when I come back and fix all type hints
There was a problem hiding this comment.
Put single quotes around the word Rate
There was a problem hiding this comment.
It's the import itself that is a problem. I already tried that approach
jchen293
reviewed
May 17, 2023
jchen293
approved these changes
May 17, 2023
nwithan8
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up cleanup after breaking out services and models and does the following:
__init__files for cleaner names inside the libraryI have another PR planned to cleanup the requestor and EasyPost object files which will follow this.
Testing
Fixed various tests that needed that and re-recorded cassettes.
Pull Request Type
Please select the option(s) that are relevant to this PR.