Skip to content

[chore] Import style guide from examples submodule #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2023
Merged

[chore] Import style guide from examples submodule #287

merged 4 commits into from
Jun 13, 2023

Conversation

nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Jun 13, 2023 •
edited
Loading

Description

  • Reference the style guides from the examples submodule when formatting/linting (thankfully, no symlinking needed)
  • Update Make steps, CI as needed to account for style guide imports
  • Apply suggested linting/formatting as needed

Testing

  • Make steps work as expected locally

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team June 13, 2023 18:25
nwithan8 added 4 commits June 13, 2023 12:27
@nwithan8
- Delete local style guides, add to .gitignore
95f369a 
- New Makefile step to download style guides from examples repo
- New script to modify style guides as needed during download
@nwithan8
- Remove style guide modification script
912d244 
- Ref style guides in examples submodule rather than curl download
- Re-org Make steps as needed
@nwithan8
- Linting
787058d
@nwithan8
- Remove unused Make step
405ff6a
Justintime50
Justintime50 requested changes Jun 13, 2023
View reviewed changes
@nwithan8 nwithan8 marked this pull request as draft June 13, 2023 19:01
@nwithan8 nwithan8 marked this pull request as ready for review June 13, 2023 22:07
@nwithan8 nwithan8 merged commit d7f6bd7 into master Jun 13, 2023
@nwithan8 nwithan8 deleted the style_guide branch June 13, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@Justintime50 Justintime50 Justintime50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50