Skip to content

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Dec 19, 2023

Description

Fixes the return type of the regenerate_rates function. Closes #317

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team December 19, 2023 23:30
nwithan8
nwithan8 previously approved these changes Dec 20, 2023
jchen293
jchen293 previously approved these changes Dec 20, 2023
@Justintime50 Justintime50 dismissed stale reviews from jchen293 and nwithan8 via a765612 December 20, 2023 21:28
@Justintime50 Justintime50 merged commit d387ff6 into master Dec 20, 2023
@Justintime50 Justintime50 deleted the fix_regenerate_rates_type branch December 20, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ShipmentService.regenerate_rates has incorrect return value type
4 participants