Skip to content

feat: add tracking_codes as param for all on TrackerService #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Oct 24, 2024

Description

tracking_codes is the preferred param to use for filtering tracking codes on the index endpoint - added here

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team as a code owner October 24, 2024 19:09
Copy link
Contributor

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a unit test for this

@Justintime50
Copy link
Member Author

Can we have a unit test for this

I don't feel one is warranted. I've hit the API directly with this param and it works as intended. This parameter isn't specific to this library and the function is already tested. Adding another param to an already working function is effectively a no-op.

@Justintime50 Justintime50 merged commit 0f38da0 into master Oct 25, 2024
11 checks passed
@Justintime50 Justintime50 deleted the tracking_codes_all_param branch October 25, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants