RNG refactoring #2459
Draft
RNG refactoring #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DNKpp <DNKpp2011@gmail.com>
…stem Signed-off-by: DNKpp <DNKpp2011@gmail.com>
Signed-off-by: DNKpp <DNKpp2011@gmail.com>
|
Jenkins: Test this please |
|
Well, I've mixed up the c++ versions. Most _v type_trait suffixes are from c++17. Questions is, when do you plan upgrading version? If it's planned for the near future I'll simply wait and instead upgrading the other parts to c++17 . |
fdelapena
added
the
Awaiting Rebase
|
Since we do use c++17 now, this should be looked at again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already discussed on discord, the current workflow of locking and unlocking rng seems quite dirty. My solution is wrapping the rng in a simple polymorphic adapter class, which let's us exchange the behavior during runtime (e.g. for tests).
I also added a simple ScopedRNGWrapper class, which will exchange the current global rng with a newly created one and exchanges it back on destruction.
Finally I added some test cases.