Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maniac Patch: Final contribution #2797

Merged
merged 11 commits into from
Sep 3, 2022
Merged

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented May 29, 2022

This concludes my Maniac Patch contributions for now.

New stuff:

  • Most Conditional Branch enhancements except "Game was just loaded"
  • The Keyboard part of KeyInputProcEx (not very useful, see it as an alternative to Ineluki). Joypad mapping part not supported as we have our own Joypad code and remapper (soon ^^')
  • Control Global Save Command
  • Control Variable enhancements including the Expression parser
    • Unsupported are assignment operators (+=, etc.) because they assign in expressions which violates the purpose of the ControlVariables command
    • Array operations are unsupported as I consider them not too useful

The final one for later this year is Show String Picture. This is lots of work to add.

Fix #491

@Ghabry Ghabry marked this pull request as ready for review August 23, 2022 21:42
Also refactored Control Variables to make code in the Interpreter less verbose.

Makes sharing with Maniac Patch easier.
@Ghabry
Copy link
Member Author

Ghabry commented Aug 23, 2022

Needs some more testing but is otherwise finished.

@gadesx
Copy link

gadesx commented Aug 24, 2022

I've heard that the latest maniacs patch it's a bit broken, atleast the editor.
I don't know what release version works fine to use "show string picture"
Latest actually: patch_maniacs_211010

Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea about manic patch games, that use all features to test.

Nice refactor, though.

@carstene1ns carstene1ns merged commit c94d563 into EasyRPG:master Sep 3, 2022
@Ghabry Ghabry deleted the maniac/events3 branch June 12, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support more keys for KeyInputProc
4 participants