Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Resolutions 1/? #2872

Merged
merged 20 commits into from
Dec 27, 2022
Merged

Custom Resolutions 1/? #2872

merged 20 commits into from
Dec 27, 2022

Conversation

BlisterB
Copy link
Member

@BlisterB BlisterB commented Dec 13, 2022

This PR make some element "responsive" by not being dependant of a fixed resolution :

  • Startup scene : The EasyRPG logo is now centered
  • Loading/Saving scene : the bottom border dans the cursor are placed at the bottom of the screen, no matter the resolution

Just to track the status, not the tasklist of this PR :)

  • Game Browser (should be fine with full stretch?)
  • Startup
  • Main Menu
  • Items
  • Skills
  • Equipment
  • Status
  • This dumb reorder scene nobody uses
  • Save/Load
  • Name input (Change Hero Name)
  • Debug
  • End Game
  • Shop
  • Battle
  • Map (Message Box & Gold)
  • Map (Screen Pan)
  • Map (Weather Effects)
  • Map (Correct Panorama rendering)
  • Map (Correct Picture offsetting)

@BlisterB BlisterB changed the title Center the EasyRPG logo at startup Make some element "responsive" Dec 13, 2022
@BlisterB
Copy link
Member Author

The Message Window is now centered.
Here are example with base resolution and "wide" resolution.
Apres Base Resolution
Apres Wide Resolution

@BlisterB
Copy link
Member Author

  • The map now prevents displaying the outside of the map
  • The camera now centers the player : if he moves and if he teleports

@BlisterB
Copy link
Member Author

The Save/Load menu is now centered.
Before Save Load Menu Widescreen
After Save Load Menu Widescreen

@BlisterB
Copy link
Member Author

For the Gold Window, I prefered to place it at top-right. Here are the two renders.
image
image

@BlisterB
Copy link
Member Author

Here is the actual look of the main menu, fully centered:
image

@BlisterB
Copy link
Member Author

The item menu is now centered (after/before):
Après Objets Widescreen
Avant Objets

@BlisterB
Copy link
Member Author

BlisterB commented Dec 16, 2022

The skills menu is now centered (after/before):
Après Techniques WidescreenAvant Techniques

@BlisterB
Copy link
Member Author

BlisterB commented Dec 16, 2022

The equipment menu is now centered (before/after):
Equipment Widescreen BeforeEquipment Widescreen After

@BlisterB
Copy link
Member Author

The status menu is now centered (before/after):
Status Widescreen Before
Status Widescreen After

@Ghabry
Copy link
Member

Ghabry commented Dec 16, 2022

Because these scenes have a item list wouldn't it make sense to stretch this item to the bottom so it can show more menu items at once?

@BlisterB
Copy link
Member Author

This dumb reorder scene nobody uses is now centered.
Well not really but it wasn't already centered in base resolution.
Formation Widescreen BeforeFormation Widescreen After

@BlisterB
Copy link
Member Author

Because these scenes have a item list wouldn't it make sense to stretch this item to the bottom so it can show more menu items at once?

Honestly it looks wrong because you come from the main menu which is 320x240 and centered. The margin "disapears".
For now only the Save/Load Menu is vertically streched because it's ugly without that.

@BlisterB
Copy link
Member Author

The change name menu is now centered (before/after):
ChangeName Widescreen BeforeChangeName Widescreen After

@BlisterB
Copy link
Member Author

Shop menu is now centered (before/after):

Shop Widescreen Before
Shop Widescreen After

@BlisterB
Copy link
Member Author

This PR is over, don't hesitate to test and report bugs. :)

Linked to #2873

@BlisterB
Copy link
Member Author

Weather seems to work correctly
(Maybe need to double-check the "density" of particule, but looks OK at first look)

@BlisterB
Copy link
Member Author

Weather Mist Widescreen Before
Weather Rain Widescreen Before
Weather Sandstorm Widescreen Before
Weather Snow Widescreen Before

@BlisterB
Copy link
Member Author

Looping panorama does seem to work.
image

@BlisterB
Copy link
Member Author

Looping map (with looping panorama) seems to work.
image

@BlisterB
Copy link
Member Author

Pictures (with and without "scroll with map") seems to work (here are two Sans, one in (0,0).

As discussed in the Discord. A "legacy" mode could be implemented for centering picture in older games.

image

@BlisterB
Copy link
Member Author

A vertical margin has been added for Message Box when screen height is > 240 (3% of the screen height).
image
image
image

Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with everything except for "Custom resolution: Center the camera around the player". I would prefer to have this commit removed by now, as this is a behaviour change compared to everything else which is a visual change.

I'm 99.9% sure that it breaks the "Pan Screen" event command and if it doesn't break it likely reintroduces weird edge cases. Problem is that instead of GetPanX/Y you use now a complete new formula so the behaviour could change.

@BlisterB
Copy link
Member Author

I've dropped the commit "Custom resolution: Center the camera around the player"

Works by calculating the correct default values.
@Ghabry Ghabry added this to the 0.7.1 milestone Dec 18, 2022
@Ghabry Ghabry added Enhancement UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design Window/Scenes labels Dec 18, 2022
@BlisterB BlisterB changed the title Make some element "responsive" Make UI/Map compatible with Custom Resolutions Dec 18, 2022
@BlisterB
Copy link
Member Author

Not very important, but while testing the resolution 426x240, I noticed that the camera display the outside of the map (at the right in the screenshot).
Most likely because the witdh of the screen is not a multiple of 16.

image

@BlisterB
Copy link
Member Author

I confirm, it doesn't happens with 416x240 resolution. :)

@fdelapena fdelapena merged commit 9ee72af into EasyRPG:master Dec 27, 2022
@BlisterB BlisterB changed the title Make UI/Map compatible with Custom Resolutions Custom Resolutions 1/? Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design Window/Scenes
Development

Successfully merging this pull request may close these issues.

3 participants