-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Resolutions 1/? #2872
Custom Resolutions 1/? #2872
Conversation
|
Because these scenes have a item list wouldn't it make sense to stretch this item to the bottom so it can show more menu items at once? |
Honestly it looks wrong because you come from the main menu which is 320x240 and centered. The margin "disapears". |
This PR is over, don't hesitate to test and report bugs. :) Linked to #2873 |
Weather seems to work correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with everything except for "Custom resolution: Center the camera around the player". I would prefer to have this commit removed by now, as this is a behaviour change compared to everything else which is a visual change.
I'm 99.9% sure that it breaks the "Pan Screen" event command and if it doesn't break it likely reintroduces weird edge cases. Problem is that instead of GetPanX/Y
you use now a complete new formula so the behaviour could change.
I've dropped the commit "Custom resolution: Center the camera around the player" |
Works by calculating the correct default values.
I confirm, it doesn't happens with 416x240 resolution. :) |
This PR make some element "responsive" by not being dependant of a fixed resolution :
Just to track the status, not the tasklist of this PR :)