Skip to content

Refactor String Vars#3141

Merged
4 commits merged into
EasyRPG:masterfrom
Ghabry:maniac/stringvars
Nov 17, 2023
Merged

Refactor String Vars#3141
4 commits merged into
EasyRPG:masterfrom
Ghabry:maniac/stringvars

Conversation

@Ghabry

@Ghabry Ghabry commented Nov 2, 2023

Copy link
Copy Markdown
Member

Noteworthy changes:

  • unordered_map instead of vector to reduce huge waste of memory for sparse string usage (e.g. starting at 1000)
  • StringView used where possible to reduce copying
  • Bugfix: Setting variables didn't refresh the interpreter

@Ghabry Ghabry added the Refactor label Nov 2, 2023
@Ghabry Ghabry added this to the 0.8.1 milestone Nov 2, 2023
@Ghabry Ghabry force-pushed the maniac/stringvars branch from e80859d to d3d36b0 Compare November 2, 2023 13:05
@ghost ghost added the Performance Related to improvements on memory, less CPU or disk usage, battery savings, etc. label Nov 2, 2023
@jetrotal

Copy link
Copy Markdown
Contributor

Hi, we spoke about supporting more file types for the StrVars load/save files,
maybe those change could also fit this pr:

image
image

@ghost ghost merged commit e614030 into EasyRPG:master Nov 17, 2023
@Ghabry Ghabry deleted the maniac/stringvars branch September 2, 2024 18:52
sevenc-nanashi pushed a commit to sevenc-nanashi/easyrpg-player that referenced this pull request May 31, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Performance Related to improvements on memory, less CPU or disk usage, battery savings, etc. Refactor

Development

Successfully merging this pull request may close these issues.

2 participants