Skip to content

Fix/issue 324 #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 10, 2025
Merged

Fix/issue 324 #353

merged 12 commits into from
Aug 10, 2025

Conversation

tehkillerbee
Copy link
Collaborator

No description provided.

@Nokse22
Copy link
Contributor

Nokse22 commented Aug 3, 2025

I have tested it and it works pretty well for me.

I am not a fan of having both V1 and V2 parsers/endpoints

I agree, for Page we can remove parseV2, but for PageCategory it's harder because they have reused the TRACK_LIST type

I made a pull request against this branch to remove parseV2

@Nokse22
Copy link
Contributor

Nokse22 commented Aug 4, 2025

FYI it's also missing the title for the Home Page

@tehkillerbee
Copy link
Collaborator Author

tehkillerbee commented Aug 4, 2025

Yeah, most of the base fields were not really populated properly. But I have a fix now. I am also trying to get the "view all" endpoint working.

…creating subclass instance, based on the type field.

Formatting
@nyabinary
Copy link

High-Tide is using a patched version of python-tidal for now

@tehkillerbee tehkillerbee marked this pull request as ready for review August 10, 2025 12:30
@tehkillerbee tehkillerbee merged commit bb1c5df into main Aug 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants