Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[FEATURE] Adding onClick prop in the Button component for better intellisense #10141

Open
1 task done
nidhish-srivastava opened this issue Jan 13, 2024 · 3 comments
Open
1 task done
Assignees
Labels
⭐ goal: addition undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@nidhish-srivastava
Copy link

Is this a unique feature?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.

The button uses onClick event very often and in the Button component,we dont have a prop for onClick

Proposed Solution

In the Button component,we have ...restProps but i will add an onClick prop for better developer experience and intellisense

Screenshots

No response

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

No response

@nidhish-srivastava nidhish-srivastava added ⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Jan 13, 2024
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
@SaraJaoude
Copy link
Member

Thank you for raising. I have assigned this to you.

Please also add href as that is used just as frequently.

@SaraJaoude SaraJaoude added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 2 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Jan 20, 2024
@github-actions github-actions bot unlocked this conversation Jan 20, 2024
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⭐ goal: addition undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants