-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metadata toml fields for wezterm #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wez
reviewed
Jul 19, 2022
wez
reviewed
Jul 19, 2022
wez
reviewed
Jul 19, 2022
EdenEast
reviewed
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on.
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Co-authored-by: EdenEast <edenofest@gmail.com>
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Co-authored-by: EdenEast <edenofest@gmail.com>
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Hopefully all is good now? Updated tpl as per sugg's, and precompiles. |
EdenEast
approved these changes
Jul 20, 2022
LGTM |
wez
added a commit
to wez/wezterm
that referenced
this pull request
Jul 20, 2022
note that "_bash (Gogh)" is removed by this as it is actually a duplicate of nightfox but with a different name, according to my dedup logic. I may add a way to express aliases as a followup. refs: EdenEast/nightfox.nvim#184 refs: EdenEast/nightfox.nvim#183 refs: EdenEast/nightfox.nvim#156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #183 #156 and for wezterm to properly parse the metadata content for nightfox related toml tempmlates.
also update comment referring to cmd to run to generate the templates