-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdenEast
added
extras
Relates to extra template generation
breaking
A change that introduces a breaking change for users
compiler
Change relating to style compiler
labels
Mar 15, 2022
BREAKING CHANGE: Deprecate `.load()` in favour of builtin
BREAKING CHANGE: .setup() function has been changed. All settings have been moved under `options`.
This make it so that the recipe is not the same as the extra folder.
Update screenshots wezterm settingsScreenshots taken on a mac with no padding and window decorations for the clean rounded corners. return {
window_padding = { left = 0, right = 0, top = 0, bottom = 0 },
window_decorations = "RESIZE",
initial_cols = 160,
initial_ros = 48,
font_size = 18,
-- font -> "Hack Nerd Font Mono"
} |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr is a rewrite of nightfox to be based around the concept of
pallets
, andspecs
.The goal of this rewrite is to define a set of colors for each style (
pallets
). These styles then are mapped to aspecification (
spec
) that is used by the groups/modules. Users can override a color pallet or just a spec mapping. Forexample you would like to just change functions to be
cyan
instead of blue. You can override just this and still haveeverything else the same.
With all these configuration settings it is also important to have a way to precompute the results and cache the results
to make sure startup times are unaffected. This rewrite adds the concept of
compiled
files that are the vim callsrequired to set the colorscheme. Nightfox also comes with its default settings precompiled to speed up startup time.
List of Breaking Changes:
nightfox.load()
has been removed in favour of setting colorschemes using the builtin:colorscheme
commandnightfox.setup()
function now takes configuration options as an optional keyfox
has been removed in favour of setting colorschemes using the builtin:colorscheme
commandtransparent
has been moved tooptions.transparent
terminal_color
has been moved tooptions.terminal_color
alt_nc
has been moved tooptions.dim_inactive
styles
has been moved tooptions.styles
inverse
has been moved tooptions.inverse
colors
has been replaced with the concept of palletshlgroups
has been replaced with the concept of groups