Update unique ID for share referral links #4891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
requested changes
Mar 10, 2024
src/components/themed/SideMenu.tsx
Outdated
| const refId = hashjs.sha256().update(data).digest('hex') | ||
|
|
||
| const website = `${config.website}?af=referred_${refId}` | ||
| console.debug(website) |
src/components/themed/SideMenu.tsx
Outdated
| const data = Uint8Array.from(Buffer.from(account.rootLoginId, 'hex')) | ||
| const refId = hashjs.sha256().update(data).digest('hex') | ||
|
|
||
| const website = `${config.website}?af=referred_${refId}` |
There was a problem hiding this comment.
Just so it's not so long, remove the 0x prefix and truncate to 10 digits. also, prefix should be appreferred_
Jon-edge
force-pushed
the
jon/share-link-hash
branch
from
6780ec7 to
4d014d1
Compare
paullinator
requested changes
Mar 12, 2024
src/components/themed/SideMenu.tsx
Outdated
| const website = `${config.website}?af=referred_${refId}` | ||
| console.debug(website) | ||
| // Truncate the refId to 10 characters using the first and last 5 chars: | ||
| refId = refId.substring(0, 5) + refId.substring(refId.length - 5) |
There was a problem hiding this comment.
Just use the first 10 characters. refId is a hash so it doesn't matter.
Jon-edge
force-pushed
the
jon/share-link-hash
branch
from
96e09e3 to
2f5d4ed
Compare
paullinator
approved these changes
Mar 12, 2024
paullinator
approved these changes
Mar 12, 2024
fixup! Update unique ID for share referral links
Jon-edge
force-pushed
the
jon/share-link-hash
branch
from
2f5d4ed to
f59a3bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the unique ID used for generating share referral links. It replaces the previous method of using base58ToUuid with a new method that generates an anonymized referral ID using hash.js. This ensures that the referral links are more secure and unique.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: