Skip to content
This repository has been archived by the owner on Apr 16, 2023. It is now read-only.

Show version from package.json #27

Closed
wants to merge 1 commit into from
Closed

Conversation

pfeerick
Copy link
Member

@pfeerick pfeerick commented Aug 25, 2021

I don't know if this works for your workflow... but it looks like this is one way to get the version to display - from the package.json.

Then you could either run npm version patch before pushing a commit (or minor / major as needed), or use a pre-commit hook so that git will do it automatically. It looks like it also survives the package being built, as it shows on a built windows package. Or I guess even have the github action somehow do that, then it really can't be forgotten!

Just another approach - a timestamp or even git commit hash would be fine, but it doesn't seem to want to co-operate atm.

image

@CoderElectronics
Copy link
Collaborator

CoderElectronics commented Sep 7, 2021

Although i like the idea, it appears to be working perfectly fine at the moment for me. Plus the current method will only display it if github builds it, so you can tell if its an unofficial build or not.

@pfeerick
Copy link
Member Author

pfeerick commented Sep 8, 2021

I don't think it being an official or unofficial build is of any real importance due there the being no actual validation via use of a signature or such. With access to the source, it's easy enough to spoof anyway.

It currently is still not working on "official" Windows builds, but I think from screenshots I've seen from JimB that it is working on Mac, so it is probably only working on `nix derived platforms.

I think we should be headed down the path of a version number in any respect, as commit hashes have little meaning to the end user - it's only really useful for developers.

image

This is more meaningful... 1.0.7 is the current version... I'm running 1.0.4... there's been three build releases since my last update... I can't figure that out from a commit hash just by looking at it. (I'm not even considering the update check capability yet).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants